* [PATCH v2] drm/amdgpu: remove internal/unused kernel module parameters
@ 2018-07-17 20:12 Sonny Jiang
[not found] ` <1531858354-3530-1-git-send-email-sonny.jiang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sonny Jiang @ 2018-07-17 20:12 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Sonny Jiang
Signed-off-by: Sonny Jiang <sonny.jiang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 ------------
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index d852d11..a9f09da 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -106,11 +106,8 @@ extern int amdgpu_vm_fault_stop;
extern int amdgpu_vm_debug;
extern int amdgpu_vm_update_mode;
extern int amdgpu_dc;
-extern int amdgpu_dc_log;
extern int amdgpu_sched_jobs;
extern int amdgpu_sched_hw_submission;
-extern int amdgpu_no_evict;
-extern int amdgpu_direct_gma_size;
extern uint amdgpu_pcie_gen_cap;
extern uint amdgpu_pcie_lane_cap;
extern uint amdgpu_cg_mask;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 529500c..8843a06 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -104,11 +104,8 @@ int amdgpu_vram_page_split = 512;
int amdgpu_vm_update_mode = -1;
int amdgpu_exp_hw_support = 0;
int amdgpu_dc = -1;
-int amdgpu_dc_log = 0;
int amdgpu_sched_jobs = 32;
int amdgpu_sched_hw_submission = 2;
-int amdgpu_no_evict = 0;
-int amdgpu_direct_gma_size = 0;
uint amdgpu_pcie_gen_cap = 0;
uint amdgpu_pcie_lane_cap = 0;
uint amdgpu_cg_mask = 0xffffffff;
@@ -341,9 +338,6 @@ module_param_named(exp_hw_support, amdgpu_exp_hw_support, int, 0444);
MODULE_PARM_DESC(dc, "Display Core driver (1 = enable, 0 = disable, -1 = auto (default))");
module_param_named(dc, amdgpu_dc, int, 0444);
-MODULE_PARM_DESC(dc_log, "Display Core Log Level (0 = minimal (default), 1 = chatty");
-module_param_named(dc_log, amdgpu_dc_log, int, 0444);
-
/**
* DOC: sched_jobs (int)
* Override the max number of jobs supported in the sw queue. The default is 32.
@@ -366,12 +360,6 @@ module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444);
MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))");
module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444);
-MODULE_PARM_DESC(no_evict, "Support pinning request from user space (1 = enable, 0 = disable (default))");
-module_param_named(no_evict, amdgpu_no_evict, int, 0444);
-
-MODULE_PARM_DESC(direct_gma_size, "Direct GMA size in megabytes (max 96MB)");
-module_param_named(direct_gma_size, amdgpu_direct_gma_size, int, 0444);
-
/**
* DOC: pcie_gen_cap (uint)
* Override PCIE gen speed capabilities. See the CAIL flags in drivers/gpu/drm/amd/include/amd_pcie.h.
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1531858354-3530-1-git-send-email-sonny.jiang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH v2] drm/amdgpu: remove internal/unused kernel module parameters [not found] ` <1531858354-3530-1-git-send-email-sonny.jiang-5C7GfCeVMHo@public.gmane.org> @ 2018-07-17 20:16 ` Alex Deucher [not found] ` <CADnq5_PHtzD4A3uok1uNPcAfMmJtARXjGxzjz_fL24MTJXF5tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Alex Deucher @ 2018-07-17 20:16 UTC (permalink / raw) To: Sonny Jiang; +Cc: amd-gfx list On Tue, Jul 17, 2018 at 4:12 PM, Sonny Jiang <sonny.jiang@amd.com> wrote: > Signed-off-by: Sonny Jiang <sonny.jiang@amd.com> Please add a basic commit message. With that: Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 ------------ > 2 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index d852d11..a9f09da 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -106,11 +106,8 @@ extern int amdgpu_vm_fault_stop; > extern int amdgpu_vm_debug; > extern int amdgpu_vm_update_mode; > extern int amdgpu_dc; > -extern int amdgpu_dc_log; > extern int amdgpu_sched_jobs; > extern int amdgpu_sched_hw_submission; > -extern int amdgpu_no_evict; > -extern int amdgpu_direct_gma_size; > extern uint amdgpu_pcie_gen_cap; > extern uint amdgpu_pcie_lane_cap; > extern uint amdgpu_cg_mask; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 529500c..8843a06 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -104,11 +104,8 @@ int amdgpu_vram_page_split = 512; > int amdgpu_vm_update_mode = -1; > int amdgpu_exp_hw_support = 0; > int amdgpu_dc = -1; > -int amdgpu_dc_log = 0; > int amdgpu_sched_jobs = 32; > int amdgpu_sched_hw_submission = 2; > -int amdgpu_no_evict = 0; > -int amdgpu_direct_gma_size = 0; > uint amdgpu_pcie_gen_cap = 0; > uint amdgpu_pcie_lane_cap = 0; > uint amdgpu_cg_mask = 0xffffffff; > @@ -341,9 +338,6 @@ module_param_named(exp_hw_support, amdgpu_exp_hw_support, int, 0444); > MODULE_PARM_DESC(dc, "Display Core driver (1 = enable, 0 = disable, -1 = auto (default))"); > module_param_named(dc, amdgpu_dc, int, 0444); > > -MODULE_PARM_DESC(dc_log, "Display Core Log Level (0 = minimal (default), 1 = chatty"); > -module_param_named(dc_log, amdgpu_dc_log, int, 0444); > - > /** > * DOC: sched_jobs (int) > * Override the max number of jobs supported in the sw queue. The default is 32. > @@ -366,12 +360,6 @@ module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444); > MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))"); > module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444); > > -MODULE_PARM_DESC(no_evict, "Support pinning request from user space (1 = enable, 0 = disable (default))"); > -module_param_named(no_evict, amdgpu_no_evict, int, 0444); > - > -MODULE_PARM_DESC(direct_gma_size, "Direct GMA size in megabytes (max 96MB)"); > -module_param_named(direct_gma_size, amdgpu_direct_gma_size, int, 0444); > - > /** > * DOC: pcie_gen_cap (uint) > * Override PCIE gen speed capabilities. See the CAIL flags in drivers/gpu/drm/amd/include/amd_pcie.h. > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CADnq5_PHtzD4A3uok1uNPcAfMmJtARXjGxzjz_fL24MTJXF5tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v2] drm/amdgpu: remove internal/unused kernel module parameters [not found] ` <CADnq5_PHtzD4A3uok1uNPcAfMmJtARXjGxzjz_fL24MTJXF5tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2018-07-18 6:58 ` Christian König 0 siblings, 0 replies; 3+ messages in thread From: Christian König @ 2018-07-18 6:58 UTC (permalink / raw) To: Alex Deucher, Sonny Jiang; +Cc: amd-gfx list Am 17.07.2018 um 22:16 schrieb Alex Deucher: > On Tue, Jul 17, 2018 at 4:12 PM, Sonny Jiang <sonny.jiang@amd.com> wrote: >> Signed-off-by: Sonny Jiang <sonny.jiang@amd.com> > Please add a basic commit message. With that: > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Oh, thanks. Got to clean that up on my todo list for ages. Patch is Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 ------------ >> 2 files changed, 15 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> index d852d11..a9f09da 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> @@ -106,11 +106,8 @@ extern int amdgpu_vm_fault_stop; >> extern int amdgpu_vm_debug; >> extern int amdgpu_vm_update_mode; >> extern int amdgpu_dc; >> -extern int amdgpu_dc_log; >> extern int amdgpu_sched_jobs; >> extern int amdgpu_sched_hw_submission; >> -extern int amdgpu_no_evict; >> -extern int amdgpu_direct_gma_size; >> extern uint amdgpu_pcie_gen_cap; >> extern uint amdgpu_pcie_lane_cap; >> extern uint amdgpu_cg_mask; >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> index 529500c..8843a06 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >> @@ -104,11 +104,8 @@ int amdgpu_vram_page_split = 512; >> int amdgpu_vm_update_mode = -1; >> int amdgpu_exp_hw_support = 0; >> int amdgpu_dc = -1; >> -int amdgpu_dc_log = 0; >> int amdgpu_sched_jobs = 32; >> int amdgpu_sched_hw_submission = 2; >> -int amdgpu_no_evict = 0; >> -int amdgpu_direct_gma_size = 0; >> uint amdgpu_pcie_gen_cap = 0; >> uint amdgpu_pcie_lane_cap = 0; >> uint amdgpu_cg_mask = 0xffffffff; >> @@ -341,9 +338,6 @@ module_param_named(exp_hw_support, amdgpu_exp_hw_support, int, 0444); >> MODULE_PARM_DESC(dc, "Display Core driver (1 = enable, 0 = disable, -1 = auto (default))"); >> module_param_named(dc, amdgpu_dc, int, 0444); >> >> -MODULE_PARM_DESC(dc_log, "Display Core Log Level (0 = minimal (default), 1 = chatty"); >> -module_param_named(dc_log, amdgpu_dc_log, int, 0444); >> - >> /** >> * DOC: sched_jobs (int) >> * Override the max number of jobs supported in the sw queue. The default is 32. >> @@ -366,12 +360,6 @@ module_param_named(sched_hw_submission, amdgpu_sched_hw_submission, int, 0444); >> MODULE_PARM_DESC(ppfeaturemask, "all power features enabled (default))"); >> module_param_named(ppfeaturemask, amdgpu_pp_feature_mask, uint, 0444); >> >> -MODULE_PARM_DESC(no_evict, "Support pinning request from user space (1 = enable, 0 = disable (default))"); >> -module_param_named(no_evict, amdgpu_no_evict, int, 0444); >> - >> -MODULE_PARM_DESC(direct_gma_size, "Direct GMA size in megabytes (max 96MB)"); >> -module_param_named(direct_gma_size, amdgpu_direct_gma_size, int, 0444); >> - >> /** >> * DOC: pcie_gen_cap (uint) >> * Override PCIE gen speed capabilities. See the CAIL flags in drivers/gpu/drm/amd/include/amd_pcie.h. >> -- >> 2.7.4 >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 20:12 [PATCH v2] drm/amdgpu: remove internal/unused kernel module parameters Sonny Jiang
[not found] ` <1531858354-3530-1-git-send-email-sonny.jiang-5C7GfCeVMHo@public.gmane.org>
2018-07-17 20:16 ` Alex Deucher
[not found] ` <CADnq5_PHtzD4A3uok1uNPcAfMmJtARXjGxzjz_fL24MTJXF5tQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-18 6:58 ` Christian König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).