From: Nirmoy <nirmodas@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
"Nirmoy Das" <nirmoy.das@amd.com>,
amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, pmenzel+amd-gfx@molgen.mpg.de,
Tianci.Yin@amd.com, Leo.Liu@amd.com
Subject: Re: [PATCH 1/2] Revert "drm/amdgpu: disable gpu-sched load balance for uvd"
Date: Wed, 2 Sep 2020 11:42:25 +0200 [thread overview]
Message-ID: <9a284eba-3485-2eb4-bcce-5c0d55fd86e5@amd.com> (raw)
In-Reply-To: <e09d9528-e2a2-5f17-dd0c-2cf94f9cc0b6@amd.com>
On 9/2/20 8:55 AM, Christian König wrote:
> Am 01.09.20 um 21:49 schrieb Nirmoy Das:
>> This reverts commit e0300ed8820d19fe108006cf1b69fa26f0b4e3fc.
>>
>> We should also disable load balance for AMDGPU_HW_IP_UVD_ENC jobs.
>
> Well revert and re-apply is usually not the best option. Just provide
> a delta patch and Alex might decide to squash it into the original one
> during upstreaming.
I wasn't sure how to handle that. Thanks, I will send a delta patch.
Regards,
Nirmoy
>
> Christian.
>
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> index 7cd398d25498..59032c26fc82 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> @@ -114,9 +114,7 @@ static int amdgpu_ctx_init_entity(struct
>> amdgpu_ctx *ctx, u32 hw_ip,
>> scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
>> num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;
>> - if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
>> - hw_ip == AMDGPU_HW_IP_VCN_DEC ||
>> - hw_ip == AMDGPU_HW_IP_UVD) {
>> + if (hw_ip == AMDGPU_HW_IP_VCN_ENC || hw_ip ==
>> AMDGPU_HW_IP_VCN_DEC) {
>> sched = drm_sched_pick_best(scheds, num_scheds);
>> scheds = &sched;
>> num_scheds = 1;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-09-02 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 19:49 [PATCH 1/2] Revert "drm/amdgpu: disable gpu-sched load balance for uvd" Nirmoy Das
2020-09-01 19:49 ` [PATCH 2/2] drm/amdgpu: disable gpu-sched load balance for uvd Nirmoy Das
2020-09-02 6:55 ` [PATCH 1/2] Revert "drm/amdgpu: disable gpu-sched load balance for uvd" Christian König
2020-09-02 9:42 ` Nirmoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a284eba-3485-2eb4-bcce-5c0d55fd86e5@amd.com \
--to=nirmodas@amd.com \
--cc=Leo.Liu@amd.com \
--cc=Tianci.Yin@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=nirmoy.das@amd.com \
--cc=pmenzel+amd-gfx@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox