Re: [PATCH 1/3] drm/amdgpu: remove non-sense NULL ptr check

[Chunming Zhou <zhoucm1-5C7GfCeVMHo@public.gmane.org>]

The series is Reviewed-by: Chunming Zhou <david1.zhou@amd.com>

在 2019/3/8 22:31, Christian König 写道:
> It's a bug having a dead pointer in the IDR, silently returning
> is the worst we can do.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> index 736ed1d67ec2..b7289f709644 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> @@ -570,12 +570,6 @@ void amdgpu_ctx_mgr_entity_flush(struct amdgpu_ctx_mgr *mgr)
>   
>   	mutex_lock(&mgr->lock);
>   	idr_for_each_entry(idp, ctx, id) {
> -
> -		if (!ctx->adev) {
> -			mutex_unlock(&mgr->lock);
> -			return;
> -		}
> -
>   		for (i = 0; i < num_entities; i++) {
>   			struct drm_sched_entity *entity;
>   
> @@ -596,10 +590,6 @@ void amdgpu_ctx_mgr_entity_fini(struct amdgpu_ctx_mgr *mgr)
>   	idp = &mgr->ctx_handles;
>   
>   	idr_for_each_entry(idp, ctx, id) {
> -
> -		if (!ctx->adev)
> -			return;
> -
>   		if (kref_read(&ctx->refcount) != 1) {
>   			DRM_ERROR("ctx %p is still alive\n", ctx);
>   			continue;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx