From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two Date: Tue, 11 Sep 2018 08:49:44 +0200 Message-ID: <9b61bb4c-4721-c8af-0810-4ecc18ed1ea4@gmail.com> References: <20180909180339.1910-1-christian.koenig@amd.com> <20180909180339.1910-2-christian.koenig@amd.com> <60b9c96a-d31d-cd61-df22-c8414f0166dc@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <60b9c96a-d31d-cd61-df22-c8414f0166dc-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org WWVhaCB3ZWxsIHRoZSB3aG9sZSBwYXRjaCBzZXQgZGVwZW5kcyBvbiB0aGF0IDopCgpPdGhlcndp c2Ugd2UgZG9uJ3QgZ2V0IHBhZ2VzIGxhcmdlciB0aGFuIDJNQiBmb3IgdGhlIEwxIG9uIFZlZ2Ex MC4KCkJ1dCBhbm90aGVyIHF1ZXN0aW9uOiBXaHkgZG8geW91IHdhbnQgdG8gY2xlYXIgVlJBTSBv biBhbGxvY2F0aW9uPyBXZSAKcGVyZmVjdGx5IHN1cHBvcnQgYWxsb2NhdGluZyBWUkFNIHdpdGhv dXQgY2xlYXJpbmcgaXQuCgpSZWdhcmRzLApDaHJpc3RpYW4uCgpBbSAxMS4wOS4yMDE4IHVtIDAy OjA4IHNjaHJpZWIgRmVsaXggS3VlaGxpbmc6Cj4gVGhpcyBsb29rcyBnb29kLiBCdXQgaXQgY29t cGxpY2F0ZXMgc29tZXRoaW5nIEkndmUgYmVlbiBsb29raW5nIGF0Ogo+IFJlbWVtYmVyaW5nIHdo aWNoIHByb2Nlc3MgZHJtX21tX25vZGVzIGxhc3QgYmVsb25nZWQgdG8sIHNvIHRoYXQgdGhleQo+ IGRvbid0IG5lZWQgdG8gYmUgY2xlYXJlZCBuZXh0IHRpbWUgdGhleSBhcmUgYWxsb2NhdGVkIGJ5 IHRoZSBzYW1lCj4gcHJvY2Vzcy4gSGF2aW5nIG1vc3Qgbm9kZXMgdGhlIHNhbWUgc2l6ZSAodnJh bV9wYWdlX3NwbGl0IHBhZ2VzKSB3b3VsZAo+IG1ha2UgdGhpcyB2ZXJ5IGVhc3kgYW5kIGVmZmlj aWVudCBmb3IgdGhlIG1vc3QgY29tbW9uIGNhc2VzIChsYXJnZQo+IGFsbG9jYXRpb25zIHdpdGhv dXQgYW55IGV4b3RpYyBhZGRyZXNzIGxpbWl0YXRpb25zIG9yIGFsaWdubWVudAo+IHJlcXVpcmVt ZW50cykuCj4KPiBEb2VzIGFueXRoaW5nIGVsc2UgaW4gdGhpcyBwYXRjaCBzZXJpZXMgZGVwZW5k IG9uIHRoaXMgb3B0aW1pemF0aW9uPwo+Cj4gUmVnYXJkcywKPiAgwqAgRmVsaXgKPgo+Cj4gT24g MjAxOC0wOS0wOSAwMjowMyBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPj4gVHJ5IHRvIGFs bG9jYXRlIFZSQU0gaW4gcG93ZXIgb2YgdHdvIHNpemVzIGFuZCBvbmx5IGZhbGxiYWNrIHRvIHZy YW0KPj4gc3BsaXQgc2l6ZXMgaWYgdGhhdCBmYWlscy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQ2hy aXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+PiAtLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYyB8IDUyICsrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwg MTIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfdnJhbV9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV92cmFtX21nci5jCj4+IGluZGV4IDljZmE4YTlhZGE5Mi4uM2Y5ZDVkMDBjOWIzIDEwMDY0NAo+ PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYwo+PiBAQCAt MTI0LDYgKzEyNCwyOCBAQCB1NjQgYW1kZ3B1X3ZyYW1fbWdyX2JvX3Zpc2libGVfc2l6ZShzdHJ1 Y3QgYW1kZ3B1X2JvICpibykKPj4gICAJcmV0dXJuIHVzYWdlOwo+PiAgIH0KPj4gICAKPj4gKy8q Kgo+PiArICogYW1kZ3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQgLSB1cGRhdGUgdmlydHVhbCBzdGFy dCBhZGRyZXNzCj4+ICsgKgo+PiArICogQG1lbTogdHRtX21lbV9yZWcgdG8gdXBkYXRlCj4+ICsg KiBAbm9kZToganVzdCBhbGxvY2F0ZWQgbm9kZQo+PiArICoKPj4gKyAqIENhbGN1bGF0ZSBhIHZp cnR1YWwgQk8gc3RhcnQgYWRkcmVzcyB0byBlYXNpbHkgY2hlY2sgaWYgZXZlcnl0aGluZyBpcyBD UFUKPj4gKyAqIGFjY2Vzc2libGUuCj4+ICsgKi8KPj4gK3N0YXRpYyB2b2lkIGFtZGdwdV92cmFt X21ncl92aXJ0X3N0YXJ0KHN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtLAo+PiArCQkJCSAgICAgICBz dHJ1Y3QgZHJtX21tX25vZGUgKm5vZGUpCj4+ICt7Cj4+ICsJdW5zaWduZWQgbG9uZyBzdGFydDsK Pj4gKwo+PiArCXN0YXJ0ID0gbm9kZS0+c3RhcnQgKyBub2RlLT5zaXplOwo+PiArCWlmIChzdGFy dCA+IG1lbS0+bnVtX3BhZ2VzKQo+PiArCQlzdGFydCAtPSBtZW0tPm51bV9wYWdlczsKPj4gKwll bHNlCj4+ICsJCXN0YXJ0ID0gMDsKPj4gKwltZW0tPnN0YXJ0ID0gbWF4KG1lbS0+c3RhcnQsIHN0 YXJ0KTsKPj4gK30KPj4gKwo+PiAgIC8qKgo+PiAgICAqIGFtZGdwdV92cmFtX21ncl9uZXcgLSBh bGxvY2F0ZSBuZXcgcmFuZ2VzCj4+ICAgICoKPj4gQEAgLTE3NiwxMCArMTk4LDI1IEBAIHN0YXRp YyBpbnQgYW1kZ3B1X3ZyYW1fbWdyX25ldyhzdHJ1Y3QgdHRtX21lbV90eXBlX21hbmFnZXIgKm1h biwKPj4gICAJcGFnZXNfbGVmdCA9IG1lbS0+bnVtX3BhZ2VzOwo+PiAgIAo+PiAgIAlzcGluX2xv Y2soJm1nci0+bG9jayk7Cj4+IC0JZm9yIChpID0gMDsgaSA8IG51bV9ub2RlczsgKytpKSB7Cj4+ ICsJZm9yIChpID0gMDsgcGFnZXNfbGVmdCA+PSBwYWdlc19wZXJfbm9kZTsgKytpKSB7Cj4+ICsJ CXVuc2lnbmVkIGxvbmcgcGFnZXMgPSByb3VuZGRvd25fcG93X29mX3R3byhwYWdlc19sZWZ0KTsK Pj4gKwo+PiArCQlyID0gZHJtX21tX2luc2VydF9ub2RlX2luX3JhbmdlKG1tLCAmbm9kZXNbaV0s IHBhZ2VzLAo+PiArCQkJCQkJcGFnZXNfcGVyX25vZGUsIDAsCj4+ICsJCQkJCQlwbGFjZS0+ZnBm biwgbHBmbiwKPj4gKwkJCQkJCW1vZGUpOwo+PiArCQlpZiAodW5saWtlbHkocikpCj4+ICsJCQli cmVhazsKPj4gKwo+PiArCQl1c2FnZSArPSBub2Rlc1tpXS5zaXplIDw8IFBBR0VfU0hJRlQ7Cj4+ ICsJCXZpc191c2FnZSArPSBhbWRncHVfdnJhbV9tZ3JfdmlzX3NpemUoYWRldiwgJm5vZGVzW2ld KTsKPj4gKwkJYW1kZ3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQobWVtLCAmbm9kZXNbaV0pOwo+PiAr CQlwYWdlc19sZWZ0IC09IHBhZ2VzOwo+PiArCX0KPj4gKwo+PiArCWZvciAoOyBwYWdlc19sZWZ0 OyArK2kpIHsKPj4gICAJCXVuc2lnbmVkIGxvbmcgcGFnZXMgPSBtaW4ocGFnZXNfbGVmdCwgcGFn ZXNfcGVyX25vZGUpOwo+PiAgIAkJdWludDMyX3QgYWxpZ25tZW50ID0gbWVtLT5wYWdlX2FsaWdu bWVudDsKPj4gLQkJdW5zaWduZWQgbG9uZyBzdGFydDsKPj4gICAKPj4gICAJCWlmIChwYWdlcyA9 PSBwYWdlc19wZXJfbm9kZSkKPj4gICAJCQlhbGlnbm1lbnQgPSBwYWdlc19wZXJfbm9kZTsKPj4g QEAgLTE5MywxNiArMjMwLDcgQEAgc3RhdGljIGludCBhbWRncHVfdnJhbV9tZ3JfbmV3KHN0cnVj dCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+PiAgIAo+PiAgIAkJdXNhZ2UgKz0gbm9kZXNb aV0uc2l6ZSA8PCBQQUdFX1NISUZUOwo+PiAgIAkJdmlzX3VzYWdlICs9IGFtZGdwdV92cmFtX21n cl92aXNfc2l6ZShhZGV2LCAmbm9kZXNbaV0pOwo+PiAtCj4+IC0JCS8qIENhbGN1bGF0ZSBhIHZp cnR1YWwgQk8gc3RhcnQgYWRkcmVzcyB0byBlYXNpbHkgY2hlY2sgaWYKPj4gLQkJICogZXZlcnl0 aGluZyBpcyBDUFUgYWNjZXNzaWJsZS4KPj4gLQkJICovCj4+IC0JCXN0YXJ0ID0gbm9kZXNbaV0u c3RhcnQgKyBub2Rlc1tpXS5zaXplOwo+PiAtCQlpZiAoc3RhcnQgPiBtZW0tPm51bV9wYWdlcykK Pj4gLQkJCXN0YXJ0IC09IG1lbS0+bnVtX3BhZ2VzOwo+PiAtCQllbHNlCj4+IC0JCQlzdGFydCA9 IDA7Cj4+IC0JCW1lbS0+c3RhcnQgPSBtYXgobWVtLT5zdGFydCwgc3RhcnQpOwo+PiArCQlhbWRn cHVfdnJhbV9tZ3JfdmlydF9zdGFydChtZW0sICZub2Rlc1tpXSk7Cj4+ICAgCQlwYWdlc19sZWZ0 IC09IHBhZ2VzOwo+PiAgIAl9Cj4+ICAgCXNwaW5fdW5sb2NrKCZtZ3ItPmxvY2spOwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==