[PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

[PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

[Sunil Khatri]

Print PD address of VM root instead of GPU address in the debugfs.
On modern GPU's this is what UMR tool expects in the registers
as well.

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 127091de0f34..a70651050acf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -2155,7 +2155,7 @@ static int amdgpu_pt_info_read(struct seq_file *m, void *unused)
 		return -EINVAL;
 	}
 
-	seq_printf(m, "gpu_address: 0x%llx\n", amdgpu_bo_gpu_offset(fpriv->vm.root.bo));
+	seq_printf(m, "pd_address: 0x%llx\n", amdgpu_gmc_pd_addr(fpriv->vm.root.bo));
 	seq_printf(m, "max_pfn: 0x%llx\n", adev->vm_manager.max_pfn);
 	seq_printf(m, "num_level: 0x%x\n", adev->vm_manager.num_level);
 	seq_printf(m, "block_size: 0x%x\n", adev->vm_manager.block_size);
-- 
2.34.1

Re: [PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

[Christian König]

On 18.08.25 15:48, Sunil Khatri wrote:
> Print PD address of VM root instead of GPU address in the debugfs.
> On modern GPU's this is what UMR tool expects in the registers
> as well.
> 
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 127091de0f34..a70651050acf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -2155,7 +2155,7 @@ static int amdgpu_pt_info_read(struct seq_file *m, void *unused)
>  		return -EINVAL;
>  	}
>  
> -	seq_printf(m, "gpu_address: 0x%llx\n", amdgpu_bo_gpu_offset(fpriv->vm.root.bo));
> +	seq_printf(m, "pd_address: 0x%llx\n", amdgpu_gmc_pd_addr(fpriv->vm.root.bo));
>  	seq_printf(m, "max_pfn: 0x%llx\n", adev->vm_manager.max_pfn);
>  	seq_printf(m, "num_level: 0x%x\n", adev->vm_manager.num_level);
>  	seq_printf(m, "block_size: 0x%x\n", adev->vm_manager.block_size);

Re: [PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

[Alex Deucher]

On Mon, Aug 18, 2025 at 9:48 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>
> Print PD address of VM root instead of GPU address in the debugfs.
> On modern GPU's this is what UMR tool expects in the registers
> as well.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Please add a Fixes tag.  With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 127091de0f34..a70651050acf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -2155,7 +2155,7 @@ static int amdgpu_pt_info_read(struct seq_file *m, void *unused)
>                 return -EINVAL;
>         }
>
> -       seq_printf(m, "gpu_address: 0x%llx\n", amdgpu_bo_gpu_offset(fpriv->vm.root.bo));
> +       seq_printf(m, "pd_address: 0x%llx\n", amdgpu_gmc_pd_addr(fpriv->vm.root.bo));
>         seq_printf(m, "max_pfn: 0x%llx\n", adev->vm_manager.max_pfn);
>         seq_printf(m, "num_level: 0x%x\n", adev->vm_manager.num_level);
>         seq_printf(m, "block_size: 0x%x\n", adev->vm_manager.block_size);
> --
> 2.34.1
>

RE: [PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

[Khatri, Sunil]

[AMD Official Use Only - AMD Internal Distribution Only]

Sure Alex.

Thanks

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com>
Sent: Monday, August 18, 2025 7:20 PM
To: Khatri, Sunil <Sunil.Khatri@amd.com>
Cc: Koenig, Christian <Christian.Koenig@amd.com>; amd-gfx@lists.freedesktop.org; StDenis, Tom <Tom.StDenis@amd.com>
Subject: Re: [PATCH 3/3] drm/amdgpu: print root PD address in PDE format instead of GPU

On Mon, Aug 18, 2025 at 9:48 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>
> Print PD address of VM root instead of GPU address in the debugfs.
> On modern GPU's this is what UMR tool expects in the registers as
> well.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Please add a Fixes tag.  With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 127091de0f34..a70651050acf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -2155,7 +2155,7 @@ static int amdgpu_pt_info_read(struct seq_file *m, void *unused)
>                 return -EINVAL;
>         }
>
> -       seq_printf(m, "gpu_address: 0x%llx\n", amdgpu_bo_gpu_offset(fpriv->vm.root.bo));
> +       seq_printf(m, "pd_address: 0x%llx\n",
> + amdgpu_gmc_pd_addr(fpriv->vm.root.bo));
>         seq_printf(m, "max_pfn: 0x%llx\n", adev->vm_manager.max_pfn);
>         seq_printf(m, "num_level: 0x%x\n", adev->vm_manager.num_level);
>         seq_printf(m, "block_size: 0x%x\n",
> adev->vm_manager.block_size);
> --
> 2.34.1
>