From: Alex Deucher <alexdeucher@gmail.com>
To: Yunxiang Li <Yunxiang.Li@amd.com>
Cc: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com
Subject: Re: [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf
Date: Mon, 28 Jul 2025 13:59:40 -0400 [thread overview]
Message-ID: <CADnq5_NMU+_DFNV=grOQ4SpH928HSUEF2Z2msom2j0vR06JyTw@mail.gmail.com> (raw)
In-Reply-To: <20250728130128.875-1-Yunxiang.Li@amd.com>
On Mon, Jul 28, 2025 at 9:18 AM Yunxiang Li <Yunxiang.Li@amd.com> wrote:
>
> On multi-vf setup if the VM have two vf assigned, perhaps from two
> different gpus, mgpu fan boost will fail.
>
> Signed-off-by: Yunxiang Li <Yunxiang.Li@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 684d66bc0b5f..e0faf7200ec5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3389,7 +3389,7 @@ static int amdgpu_device_enable_mgpu_fan_boost(void)
> for (i = 0; i < mgpu_info.num_dgpu; i++) {
> gpu_ins = &(mgpu_info.gpu_ins[i]);
> adev = gpu_ins->adev;
> - if (!(adev->flags & AMD_IS_APU) &&
> + if (!(adev->flags & AMD_IS_APU || amdgpu_sriov_multi_vf_mode(adev)) &&
> !gpu_ins->mgpu_fan_enabled) {
> ret = amdgpu_dpm_enable_mgpu_fan_boost(adev);
> if (ret)
> --
> 2.50.1
>
prev parent reply other threads:[~2025-07-28 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 13:01 [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf Yunxiang Li
2025-07-28 17:59 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_NMU+_DFNV=grOQ4SpH928HSUEF2Z2msom2j0vR06JyTw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Yunxiang.Li@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).