amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf
@ 2025-07-28 13:01 Yunxiang Li
  2025-07-28 17:59 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Yunxiang Li @ 2025-07-28 13:01 UTC (permalink / raw)
  To: amd-gfx, alexander.deucher; +Cc: Yunxiang Li

On multi-vf setup if the VM have two vf assigned, perhaps from two
different gpus, mgpu fan boost will fail.

Signed-off-by: Yunxiang Li <Yunxiang.Li@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 684d66bc0b5f..e0faf7200ec5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3389,7 +3389,7 @@ static int amdgpu_device_enable_mgpu_fan_boost(void)
 	for (i = 0; i < mgpu_info.num_dgpu; i++) {
 		gpu_ins = &(mgpu_info.gpu_ins[i]);
 		adev = gpu_ins->adev;
-		if (!(adev->flags & AMD_IS_APU) &&
+		if (!(adev->flags & AMD_IS_APU || amdgpu_sriov_multi_vf_mode(adev)) &&
 		    !gpu_ins->mgpu_fan_enabled) {
 			ret = amdgpu_dpm_enable_mgpu_fan_boost(adev);
 			if (ret)
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf
  2025-07-28 13:01 [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf Yunxiang Li
@ 2025-07-28 17:59 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2025-07-28 17:59 UTC (permalink / raw)
  To: Yunxiang Li; +Cc: amd-gfx, alexander.deucher

On Mon, Jul 28, 2025 at 9:18 AM Yunxiang Li <Yunxiang.Li@amd.com> wrote:
>
> On multi-vf setup if the VM have two vf assigned, perhaps from two
> different gpus, mgpu fan boost will fail.
>
> Signed-off-by: Yunxiang Li <Yunxiang.Li@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 684d66bc0b5f..e0faf7200ec5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3389,7 +3389,7 @@ static int amdgpu_device_enable_mgpu_fan_boost(void)
>         for (i = 0; i < mgpu_info.num_dgpu; i++) {
>                 gpu_ins = &(mgpu_info.gpu_ins[i]);
>                 adev = gpu_ins->adev;
> -               if (!(adev->flags & AMD_IS_APU) &&
> +               if (!(adev->flags & AMD_IS_APU || amdgpu_sriov_multi_vf_mode(adev)) &&
>                     !gpu_ins->mgpu_fan_enabled) {
>                         ret = amdgpu_dpm_enable_mgpu_fan_boost(adev);
>                         if (ret)
> --
> 2.50.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-28 17:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28 13:01 [PATCH] drm/amdgpu: skip mgpu fan boost for multi-vf Yunxiang Li
2025-07-28 17:59 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).