amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: fix typos
@ 2025-08-13  0:46 Alexandre Demers
  2025-08-13 14:21 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Demers @ 2025-08-13  0:46 UTC (permalink / raw)
  To: amd-gfx; +Cc: alexander.deucher

Various small typos found around.

Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
 drivers/gpu/drm/radeon/radeon_test.c   | 4 ++--
 drivers/gpu/drm/radeon/radeon_vce.c    | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index 40b49bd4a10b..5328ff18ed61 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -555,7 +555,7 @@ int radeon_wb_init(struct radeon_device *rdev)
  * cover the whole aperture even if VRAM size is inferior to aperture size
  * Novell bug 204882 + along with lots of ubuntu ones
  *
- * Note 3: when limiting vram it's safe to overwritte real_vram_size because
+ * Note 3: when limiting vram it's safe to overwrite real_vram_size because
  * we are not in case where real_vram_size is inferior to mc_vram_size (ie
  * note affected by bogus hw of Novell bug 204882 + along with lots of ubuntu
  * ones)
@@ -563,7 +563,7 @@ int radeon_wb_init(struct radeon_device *rdev)
  * Note 4: IGP TOM addr should be the same as the aperture addr, we don't
  * explicitly check for that thought.
  *
- * FIXME: when reducing VRAM size align new size on power of 2.
+ * FIXME: when reducing VRAM size, align new size on power of 2.
  */
 void radeon_vram_location(struct radeon_device *rdev, struct radeon_mc *mc, u64 base)
 {
diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_test.c
index c9fef9b61ced..818554e60537 100644
--- a/drivers/gpu/drm/radeon/radeon_test.c
+++ b/drivers/gpu/drm/radeon/radeon_test.c
@@ -455,7 +455,7 @@ static void radeon_test_ring_sync2(struct radeon_device *rdev,
 
 	r = radeon_ring_lock(rdev, ringC, 64);
 	if (r) {
-		DRM_ERROR("Failed to lock ring B %p\n", ringC);
+		DRM_ERROR("Failed to lock ring C %p\n", ringC);
 		goto out_cleanup;
 	}
 	radeon_semaphore_emit_signal(rdev, ringC->idx, semaphore);
@@ -481,7 +481,7 @@ static void radeon_test_ring_sync2(struct radeon_device *rdev,
 
 	r = radeon_ring_lock(rdev, ringC, 64);
 	if (r) {
-		DRM_ERROR("Failed to lock ring B %p\n", ringC);
+		DRM_ERROR("Failed to lock ring C %p\n", ringC);
 		goto out_cleanup;
 	}
 	radeon_semaphore_emit_signal(rdev, ringC->idx, semaphore);
diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
index 761e8b453e1e..0b9bca3860ba 100644
--- a/drivers/gpu/drm/radeon/radeon_vce.c
+++ b/drivers/gpu/drm/radeon/radeon_vce.c
@@ -86,7 +86,7 @@ int radeon_vce_init(struct radeon_device *rdev)
 
 	r = request_firmware(&rdev->vce_fw, fw_name, rdev->dev);
 	if (r) {
-		dev_err(rdev->dev, "radeon_vce: Can't load firmware \"%s\"\n",
+		dev_err(rdev->dev, "radeon_vce: can't load firmware \"%s\"\n",
 			fw_name);
 		return r;
 	}
@@ -126,7 +126,7 @@ int radeon_vce_init(struct radeon_device *rdev)
 
 	rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
 
-	/* we can only work with this fw version for now */
+	/* we can only work with these fw versions for now */
 	if ((rdev->vce.fw_version != ((40 << 24) | (2 << 16) | (2 << 8))) &&
 	    (rdev->vce.fw_version != ((50 << 24) | (0 << 16) | (1 << 8))) &&
 	    (rdev->vce.fw_version != ((50 << 24) | (1 << 16) | (2 << 8))))
@@ -281,7 +281,7 @@ static void radeon_vce_idle_work_handler(struct work_struct *work)
  *
  * @rdev: radeon_device pointer
  *
- * Make sure VCE is powerd up when we want to use it
+ * Make sure VCE is powered up when we want to use it
  */
 void radeon_vce_note_usage(struct radeon_device *rdev)
 {
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/radeon: fix typos
  2025-08-13  0:46 [PATCH] drm/radeon: fix typos Alexandre Demers
@ 2025-08-13 14:21 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2025-08-13 14:21 UTC (permalink / raw)
  To: Alexandre Demers; +Cc: amd-gfx, alexander.deucher

Applied.  Thanks!

On Tue, Aug 12, 2025 at 8:46 PM Alexandre Demers
<alexandre.f.demers@gmail.com> wrote:
>
> Various small typos found around.
>
> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
>  drivers/gpu/drm/radeon/radeon_test.c   | 4 ++--
>  drivers/gpu/drm/radeon/radeon_vce.c    | 6 +++---
>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index 40b49bd4a10b..5328ff18ed61 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -555,7 +555,7 @@ int radeon_wb_init(struct radeon_device *rdev)
>   * cover the whole aperture even if VRAM size is inferior to aperture size
>   * Novell bug 204882 + along with lots of ubuntu ones
>   *
> - * Note 3: when limiting vram it's safe to overwritte real_vram_size because
> + * Note 3: when limiting vram it's safe to overwrite real_vram_size because
>   * we are not in case where real_vram_size is inferior to mc_vram_size (ie
>   * note affected by bogus hw of Novell bug 204882 + along with lots of ubuntu
>   * ones)
> @@ -563,7 +563,7 @@ int radeon_wb_init(struct radeon_device *rdev)
>   * Note 4: IGP TOM addr should be the same as the aperture addr, we don't
>   * explicitly check for that thought.
>   *
> - * FIXME: when reducing VRAM size align new size on power of 2.
> + * FIXME: when reducing VRAM size, align new size on power of 2.
>   */
>  void radeon_vram_location(struct radeon_device *rdev, struct radeon_mc *mc, u64 base)
>  {
> diff --git a/drivers/gpu/drm/radeon/radeon_test.c b/drivers/gpu/drm/radeon/radeon_test.c
> index c9fef9b61ced..818554e60537 100644
> --- a/drivers/gpu/drm/radeon/radeon_test.c
> +++ b/drivers/gpu/drm/radeon/radeon_test.c
> @@ -455,7 +455,7 @@ static void radeon_test_ring_sync2(struct radeon_device *rdev,
>
>         r = radeon_ring_lock(rdev, ringC, 64);
>         if (r) {
> -               DRM_ERROR("Failed to lock ring B %p\n", ringC);
> +               DRM_ERROR("Failed to lock ring C %p\n", ringC);
>                 goto out_cleanup;
>         }
>         radeon_semaphore_emit_signal(rdev, ringC->idx, semaphore);
> @@ -481,7 +481,7 @@ static void radeon_test_ring_sync2(struct radeon_device *rdev,
>
>         r = radeon_ring_lock(rdev, ringC, 64);
>         if (r) {
> -               DRM_ERROR("Failed to lock ring B %p\n", ringC);
> +               DRM_ERROR("Failed to lock ring C %p\n", ringC);
>                 goto out_cleanup;
>         }
>         radeon_semaphore_emit_signal(rdev, ringC->idx, semaphore);
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
> index 761e8b453e1e..0b9bca3860ba 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -86,7 +86,7 @@ int radeon_vce_init(struct radeon_device *rdev)
>
>         r = request_firmware(&rdev->vce_fw, fw_name, rdev->dev);
>         if (r) {
> -               dev_err(rdev->dev, "radeon_vce: Can't load firmware \"%s\"\n",
> +               dev_err(rdev->dev, "radeon_vce: can't load firmware \"%s\"\n",
>                         fw_name);
>                 return r;
>         }
> @@ -126,7 +126,7 @@ int radeon_vce_init(struct radeon_device *rdev)
>
>         rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
>
> -       /* we can only work with this fw version for now */
> +       /* we can only work with these fw versions for now */
>         if ((rdev->vce.fw_version != ((40 << 24) | (2 << 16) | (2 << 8))) &&
>             (rdev->vce.fw_version != ((50 << 24) | (0 << 16) | (1 << 8))) &&
>             (rdev->vce.fw_version != ((50 << 24) | (1 << 16) | (2 << 8))))
> @@ -281,7 +281,7 @@ static void radeon_vce_idle_work_handler(struct work_struct *work)
>   *
>   * @rdev: radeon_device pointer
>   *
> - * Make sure VCE is powerd up when we want to use it
> + * Make sure VCE is powered up when we want to use it
>   */
>  void radeon_vce_note_usage(struct radeon_device *rdev)
>  {
> --
> 2.50.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-13 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13  0:46 [PATCH] drm/radeon: fix typos Alexandre Demers
2025-08-13 14:21 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).