[PATCH xf86-video-ati] glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

[PATCH xf86-video-ati] glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

We continued using the stale cached handle, causing issues e.g. when
resizing the screen via RandR.

Reported-by: iive on IRC
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 src/radeon.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/radeon.h b/src/radeon.h
index 450c69aa8..1a1edb1ba 100644
--- a/src/radeon.h
+++ b/src/radeon.h
@@ -735,6 +735,7 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
 		    return TRUE;
 
 		radeon_buffer_unref(&priv->bo);
+		priv->handle_valid = FALSE;
 	    }
 
 	    drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);
-- 
2.18.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH xf86-video-ati] glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

[Alex Deucher]

On Tue, Jul 17, 2018 at 5:43 AM, Michel Dänzer <michel@daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> We continued using the stale cached handle, causing issues e.g. when
> resizing the screen via RandR.
>
> Reported-by: iive on IRC
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  src/radeon.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/radeon.h b/src/radeon.h
> index 450c69aa8..1a1edb1ba 100644
> --- a/src/radeon.h
> +++ b/src/radeon.h
> @@ -735,6 +735,7 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
>                     return TRUE;
>
>                 radeon_buffer_unref(&priv->bo);
> +               priv->handle_valid = FALSE;
>             }
>
>             drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);
> --
> 2.18.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx