From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4B1ED1267A for ; Tue, 5 Nov 2024 10:15:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 583BD10E124; Tue, 5 Nov 2024 10:15:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kode54.net header.i=@kode54.net header.b="jlwJqGnI"; dkim-atps=neutral Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20BA010E124 for ; Tue, 5 Nov 2024 10:15:12 +0000 (UTC) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kode54.net; s=key1; t=1730801710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yCK/jIu4+/eQ9rMKru1nGfLzJOuNt5rtQEg1bUXqW+I=; b=jlwJqGnI65jXo/ALzYwviSqMluhCblUHuyPkpfbw7J0MlzDjKKO4MU/HeOmMIqagmtxBOT Q3lT8Hl856211zWflv7K1PPflNkvKxouZk9aeNixjF9dcUoWXrK7wYE08aJbVnQdp2rNEB Sz5qHx5CMgh0cG/QYwaw/cfUIdoSmWHkohsG0OqX+vGFqUxUTWzc80NIWNRCY3Z21d1yYj BX2Oa7GahknL++kNPIagwYbQgCIxAfqRn1Z43pkwt25hZVrh62/YpQ5p2hCJch4V26T2k9 Z+gUit/4PShCYcGcr8B3aH0wZPmm5jD2qu09XgnEF/0tBHDda0rCVMty3h90EQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 Nov 2024 02:15:03 -0800 Message-Id: Cc: , "Simon Ser" , "Thomas Zimmermann" , , , "Daniel Stone" , "Xaver Hugl" , "Harry Wentland" , "Simona Vetter" , "Alex Deucher" , "Maarten Lankhorst" , "Maxime Ripard" , , , , "Leo Li" , =?utf-8?q?Christian_K=C3=B6nig?= , "David Airlie" , "Rodrigo Siqueira" , "Xinhui Pan" , Subject: Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Christopher Snowhill" To: =?utf-8?q?Andr=C3=A9_Almeida?= References: <20241101-tonyk-async_flip-v9-0-681814efbfbe@igalia.com> <20241101-tonyk-async_flip-v9-1-681814efbfbe@igalia.com> <00a99b3e-3fad-42fb-8dc8-4f45d158c4c1@igalia.com> In-Reply-To: <00a99b3e-3fad-42fb-8dc8-4f45d158c4c1@igalia.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon Nov 4, 2024 at 12:52 PM PST, Andr=C3=A9 Almeida wrote: > Hi Christopher, > > Em 03/11/2024 03:36, Christopher Snowhill escreveu: > > On Fri Nov 1, 2024 at 11:23 AM PDT, Andr=C3=A9 Almeida wrote: > >> Currently, DRM atomic uAPI allows only primary planes to be flipped > >> asynchronously. However, each driver might be able to perform async > >> flips in other different plane types. To enable drivers to set their o= wn > >> restrictions on which type of plane they can or cannot flip, use the > >> existing atomic_async_check() from struct drm_plane_helper_funcs to > >> enhance this flexibility, thus allowing different plane types to be ab= le > >> to do async flips as well. > >> > >> In order to prevent regressions and such, we keep the current policy: = we > >> skip the driver check for the primary plane, because it is always > >> allowed to do async flips on it. > >> > >> Signed-off-by: Andr=C3=A9 Almeida > >=20 > > Should I do a R-b too?=20 > > If you can review the code, it's always really appreciated. I mean, I did review your changes, they looked good to me. I just didn't know the protocol for reporting review in addition to testing. > > > The changes looked sound enough for me to feel > > like testing it as well. Tested Borderlands Game of the Year Enhanced o= n > > my RX 7700 XT at maximum settings at 1080p165, and the tearing support = in > > labwc allowed it to reach over 700fps. No problems from the hardware > > cursor. > > Thanks for testing and reporting! > > >=20 > > Tested-by: Christopher Snowhill > >=20