From: Conor Dooley <conor.dooley@microchip.com>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: stylon.wang@amd.com, Wesley Chalmers <Wesley.Chalmers@amd.com>,
Sunpeng.Li@amd.com, Bhawanpreet.Lakha@amd.com,
qingqing.zhuo@amd.com, Wenjing Liu <wenjing.liu@amd.com>,
roman.li@amd.com, amd-gfx@lists.freedesktop.org,
solomon.chiu@amd.com, jerry.zuo@amd.com,
Aurabindo.Pillai@amd.com, hamza.mahfooz@amd.com,
wayne.lin@amd.com, Harry.Wentland@amd.com,
agustin.gutierrez@amd.com, pavle.kotarac@amd.com
Subject: Re: [PATCH 21/37] drm/amd/display: move dp capability related logic to link_dp_capability
Date: Thu, 19 Jan 2023 10:15:07 +0000 [thread overview]
Message-ID: <Y8kYKwU1Ky/b+3LW@wendy> (raw)
In-Reply-To: <20230110165535.3358492-22-Rodrigo.Siqueira@amd.com>
[-- Attachment #1: Type: text/plain, Size: 2679 bytes --]
Hello!
On Tue, Jan 10, 2023 at 11:55:19AM -0500, Rodrigo Siqueira wrote:
> From: Wenjing Liu <wenjing.liu@amd.com>
>
> Reviewed-by: Wesley Chalmers <Wesley.Chalmers@amd.com>
> Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Signed-off-by: Wenjing Liu <wenjing.liu@amd.com>
I haven't done a bisection, but I am getting build failures due to code
added by this patch (d5a43956b73bd in next-20230119) when running
allmodconfig for RISC-V with gcc-11.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:233:21: error: 'union hdmi_encoded_link_bw' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
233 | const union hdmi_encoded_link_bw hdmi_encoded_link_bw)
| ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:233:42: error: parameter 2 ('hdmi_encoded_link_bw') has incomplete type
233 | const union hdmi_encoded_link_bw hdmi_encoded_link_bw)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:231:17: error: function declaration isn't a prototype [-Werror=strict-prototypes]
231 | static uint32_t intersect_frl_link_bw_support(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c: In function 'get_active_converter_info':
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1125:76: error: storage size of 'hdmi_encoded_link_bw' isn't known
1125 | union hdmi_encoded_link_bw hdmi_encoded_link_bw;
| ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1129:101: error: 'struct <anonymous>' has no member named 'MAX_ENCODED_LINK_BW_SUPPORT'
1129 | hdmi_color_caps.bits.MAX_ENCODED_LINK_BW_SUPPORT);
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:1125:76: error: unused variable 'hdmi_encoded_link_bw' [-Werror=unused-variable]
1125 | union hdmi_encoded_link_bw hdmi_encoded_link_bw;
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-19 18:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 16:54 [PATCH 00/37] DC Patches Jan 10, 2023 Rodrigo Siqueira
2023-01-10 16:54 ` [PATCH 01/37] drm/amd/display: Update BW alloc after new DMUB logic Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 02/37] Revert "drm/amd/display: Speed up DML fast_validate path" Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 03/37] drm/amd/display: fix multi edp panel instancing Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 04/37] drm/amd/display: Fix DPIA link encoder assignment issue Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 05/37] drm/amd/display: Implement FIFO enable sequence on DCN32 Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 06/37] drm/amd/display: refactor hpd logic from dc_link to link_hpd Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 07/37] drm/amd/display: refactor ddc logic from dc_link_ddc to link_ddc Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 08/37] drm/amd/display: move dpcd logic from dc_link_dpcd to link_dpcd Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 09/37] drm/amd/display: move dc_link_dpia logic to link_dp_dpia Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 10/37] drm/amd/display: Update dmub header to match DMUB Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 11/37] drm/amd/display: add hubbub_init related Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 12/37] drm/amd/display: Optimize subvp and drr validation Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 13/37] drm/amd/display: Account for DCC Meta pitch in DML MALL surface calculations Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 14/37] drm/amd/display: Account for Subvp Phantoms " Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 15/37] drm/amd/display: Use DML for MALL SS and Subvp allocation calculations Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 16/37] drm/amd/display: cleanup function args in dml Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 17/37] drm/amd/display: Change i2c speed for hdcp Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 18/37] drm/amd/display: Remove SubVp support if src/dst rect does not equal stream timing Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 19/37] drm/amd/display: move dp link training logic to link_dp_training Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 20/37] drm/amd/display: move dp phy related logic to link_dp_phy Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 21/37] drm/amd/display: move dp capability related logic to link_dp_capability Rodrigo Siqueira
2023-01-19 10:15 ` Conor Dooley [this message]
2023-01-19 19:00 ` Alex Deucher
2023-01-19 19:11 ` Conor Dooley
2023-01-10 16:55 ` [PATCH 22/37] Revert "drm/amd/display: Demote Error Level When ODM Transition Supported" Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 23/37] drm/amd/display: fix an error check condition for synced pipes Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 24/37] drm/amd/display: Optimize link power-down when link powered externally Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 25/37] drm/amd/display: Remove unused code Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 26/37] drm/amd/display: set active bit for desktop with VSDBv3 Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 27/37] drm/amd/display: Add extra mblk for DCC Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 28/37] drm/amd/display: Remove DISPCLK dentist programming for dcn32 Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 29/37] drm/amd/display: contional remove disable dig_fifo when blank Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 30/37] drm/amd/display: Skip backlight control delay on external powered links Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 31/37] drm/amd/display: fix mapping to non-allocated address Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 32/37] drm/amd/display: Request min clocks after disabling pipes on init Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 33/37] drm/amd/display: Allow subvp on vactive pipes that are 2560x1440@60 Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 34/37] drm/amd/display: Account for MPO planes in dcn32 mall alloc calculations Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 35/37] drm/amd/display: phase2 enable mst hdcp multiple displays Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 36/37] drm/amd/display: hdcp not enabled on connector 0 Rodrigo Siqueira
2023-01-10 16:55 ` [PATCH 37/37] drm/amd/display: 3.2.218 Rodrigo Siqueira
2023-01-16 15:29 ` [PATCH 00/37] DC Patches Jan 10, 2023 Wheeler, Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8kYKwU1Ky/b+3LW@wendy \
--to=conor.dooley@microchip.com \
--cc=Aurabindo.Pillai@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=agustin.gutierrez@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=jerry.zuo@amd.com \
--cc=pavle.kotarac@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=roman.li@amd.com \
--cc=solomon.chiu@amd.com \
--cc=stylon.wang@amd.com \
--cc=wayne.lin@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox