From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402F4C4338F for ; Wed, 4 Aug 2021 18:33:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 030DE60FC4 for ; Wed, 4 Aug 2021 18:33:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 030DE60FC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14B966E431; Wed, 4 Aug 2021 18:33:38 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 646646E431 for ; Wed, 4 Aug 2021 18:33:36 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 8496dbbf-f552-11eb-8d1a-0050568cd888; Wed, 04 Aug 2021 18:33:52 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 365E9194B00; Wed, 4 Aug 2021 20:33:58 +0200 (CEST) Date: Wed, 4 Aug 2021 20:33:30 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, bbrezillon@kernel.org, nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, Dan.Sneddon@microchip.com, tomi.valkeinen@ideasonboard.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces Message-ID: References: <20210803090704.32152-1-tzimmermann@suse.de> <20210803090704.32152-12-tzimmermann@suse.de> <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 17:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > > don't benefit from using it. > > > > > > DRM IRQ callbacks are now being called directly or inlined. > > > > > > Calls to platform_get_irq() can fail with a negative errno code. > > > Abort initialization in this case. The DRM IRQ midlayer does not > > > handle this case correctly. > > > > I cannot see why the irq_enabled flag is needed here, and the changelog > > do not help me. > > What do I miss? > > That's a good point. Usually, only the DRM IRQ helpers use irq_enabled in > struct drm_device. It'll become legacy and we can ignore it for the driver > conversion. > > The exception is tilcdc, which also uses irq_enabled to make its error > rollback work correctly. So I duplicated the state in the local private > structure. > > I'll add this explanation to the commit message. With this added: Acked-by: Sam Ravnborg