Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

Steven Rostedt
2022-01-19T16:45:46Z

On Wed, 19 Jan 2022 11:15:08 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; }
>
>
>
> Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others
> (enable/disable) it will not be possible to keep on one line. And hence
> style will be broken among similar functions.

Agreed. Functions should always be of the normal format:

type func(params)
{
body;
}

Unless it is a stub function.

type func(params) { return 0; }

-- Steve