From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9020EC433F5 for ; Wed, 19 Jan 2022 21:14:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD21710E6E0; Wed, 19 Jan 2022 21:14:40 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9632810E1D0; Wed, 19 Jan 2022 21:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642626331; x=1674162331; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3TDiFifv04AcCVYzOm6HZ64dJH3KSAV3f2PXyUIwWhM=; b=EhcDk7iWSYY8RHR7iC/JCqn798xGRTdfZBv6WIp8TDO20oeHL7rWRgvs lL9z8P6z/wUvQyq9QyqETGltxZPZBXPKM/KeO08/UlvIpMIQeupCLTQXo OHEGCE1PIzN7evxX9GHkYUl6mFHUDCDzezoXsseyS5biKxab/LCpUO0nL pKc1HL3dsC9H8pelyMUqwayy7DOMn93dc/uidOShLcpct5LmCBy4IC7H3 UATYT/IbQV7K2+aqd2CoJAGn+N+d2YCZI++b/VmoUsMj0MFKjPwQXe/GS /fuwLb5LTwoiWFZJci4QQe4fIozp6PjvWVgsdYfpxPQJM+wdjv/kXZ+bg w==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="244012662" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="244012662" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 13:05:25 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="765084718" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 13:05:17 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAI7i-00CH8V-7G; Wed, 19 Jan 2022 23:04:06 +0200 Date: Wed, 19 Jan 2022 23:04:05 +0200 From: Andy Shevchenko To: Steven Rostedt Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> <20220119100635.6c45372b@gandalf.local.home> <20220119160017.65bd1fa5@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119160017.65bd1fa5@gandalf.local.home> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Wed, 19 Jan 2022 21:14:39 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Joonas Lahtinen , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , amd-gfx@lists.freedesktop.org, Ben Skeggs , Jakub Kicinski , Harry Wentland , Petr Mladek , Sakari Ailus , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Lucas De Marchi , Jani Nikula , Julia Lawall , Rahul Lakkireddy , Rodrigo Vivi , Mikita Lipski , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, Daniel Vetter , netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Jan 19, 2022 at 04:00:17PM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > > Checkpatch says "100" I think we need to simply update the docs (the > documentation always lags the code ;-) The idea of checkpatch change is for old code to avoid tons of patches to satisfy 80 rule in (mostly) staging code. Some maintainers started / have been using relaxed approach. -- With Best Regards, Andy Shevchenko