From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24D3EC433EF for ; Mon, 14 Feb 2022 08:43:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 342A888F16; Mon, 14 Feb 2022 08:43:57 +0000 (UTC) X-Greylist: delayed 330 seconds by postgrey-1.36 at gabe; Sat, 12 Feb 2022 16:52:58 UTC Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id E459010E151; Sat, 12 Feb 2022 16:52:58 +0000 (UTC) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 21CGkxsP010096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Feb 2022 11:47:00 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1847215C0040; Sat, 12 Feb 2022 11:46:59 -0500 (EST) Date: Sat, 12 Feb 2022 11:46:59 -0500 From: "Theodore Ts'o" To: Qing Wang Subject: Re: [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment Message-ID: References: <1644546640-23283-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644546640-23283-1-git-send-email-wangqing@vivo.com> X-Mailman-Approved-At: Mon, 14 Feb 2022 08:43:42 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , Mike Snitzer , David Airlie , Michael Turquette , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Hans Verkuil , dm-devel@redhat.com, Benjamin Tissoires , Srinivas Pandruvada , linux-clk@vger.kernel.org, Alasdair Kergon , amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-media@vger.kernel.org, Konrad Rzeszutek Wilk , intel-gfx@lists.freedesktop.org, Jiri Kosina , Jani Nikula , linux-block@vger.kernel.org, Rodrigo Vivi , Mauro Carvalho Chehab , Jens Axboe , Stephen Boyd , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Roger Pau =?iso-8859-1?Q?Monn=E9?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_is_xxx() directly instead of jiffies judgment > for understanding. Hi Wang, "judgement" doesn't really make sense as a description to an English speaker. The following a commit desription (for all of these series) is probably going to be a bit more understable: Use the helper function time_is_{before,after}_jiffies() to improve code readability. Cheers, - Ted