AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: "Zhang, Yifan" <Yifan1.Zhang@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5
Date: Thu, 24 Feb 2022 11:49:21 +0800	[thread overview]
Message-ID: <YhcAQWU2QkCEjwmB@amd.com> (raw)
In-Reply-To: <20220224034543.1631630-1-yifan1.zhang@amd.com>

On Thu, Feb 24, 2022 at 11:45:43AM +0800, Zhang, Yifan wrote:
> SMU MSG index should be used as parameter.
> 
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>

Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> index 093b9144464b..8ee5bcb60370 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
> @@ -245,14 +245,9 @@ static int smu_v13_0_5_post_smu_init(struct smu_context *smu)
>  
>  static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)
>  {
> -	int ret = 0, index = 0;
> -
> -	index = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_MSG,
> -				SMU_MSG_GfxDeviceDriverReset);
> -	if (index < 0)
> -		return index == -EACCES ? 0 : index;
> +	int ret = 0;
>  
> -	ret = smu_cmn_send_smc_msg_with_param(smu, (uint16_t)index, type, NULL);
> +	ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_GfxDeviceDriverReset, type, NULL);
>  	if (ret)
>  		dev_err(smu->adev->dev, "Failed to mode reset!\n");
>  
> -- 
> 2.25.1
> 

      parent reply	other threads:[~2022-02-24  3:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24  3:45 [PATCH] drm/amd/pm: fix mode2 reset fail for smu 13.0.5 Yifan Zhang
2022-02-24  3:47 ` Alex Deucher
2022-02-24  3:49 ` Huang Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhcAQWU2QkCEjwmB@amd.com \
    --to=ray.huang@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Yifan1.Zhang@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox