From: Christoph Hellwig <hch@infradead.org>
To: Shiwu Zhang <shiwu.zhang@amd.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: add the accelerator pcie class
Date: Mon, 22 May 2023 23:37:06 -0700 [thread overview]
Message-ID: <ZGxfEklioAu6orvo@infradead.org> (raw)
In-Reply-To: <20230523040232.21756-1-shiwu.zhang@amd.com>
On Tue, May 23, 2023 at 12:02:32PM +0800, Shiwu Zhang wrote:
> + { PCI_DEVICE(0x1002, PCI_ANY_ID),
> + .class = PCI_CLASS_ACCELERATOR_PROCESSING << 8,
> + .class_mask = 0xffffff,
> + .driver_data = CHIP_IP_DISCOVERY },
Probing for every single device of a given class for a single vendor
to a driver is just fundamentaly wrong. Please list the actual IDs
that the driver can handle.
next prev parent reply other threads:[~2023-05-23 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 4:02 [PATCH] drm/amdgpu: add the accelerator pcie class Shiwu Zhang
2023-05-23 4:12 ` Zhang, Morris
2023-05-23 6:37 ` Christoph Hellwig [this message]
2023-05-23 14:02 ` Alex Deucher
2023-05-25 9:46 ` Christoph Hellwig
2023-05-25 20:52 ` Deucher, Alexander
2023-05-26 6:55 ` Christoph Hellwig
2023-05-30 18:22 ` Deucher, Alexander
2023-06-08 19:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGxfEklioAu6orvo@infradead.org \
--to=hch@infradead.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=shiwu.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox