From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4ACDC27C53 for ; Wed, 19 Jun 2024 07:13:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FF8F10EA63; Wed, 19 Jun 2024 07:13:09 +0000 (UTC) X-Greylist: delayed 451 seconds by postgrey-1.36 at gabe; Tue, 18 Jun 2024 09:18:45 UTC Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68D9610E289; Tue, 18 Jun 2024 09:18:45 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9BFAC1C0082; Tue, 18 Jun 2024 11:13:31 +0200 (CEST) Date: Tue, 18 Jun 2024 11:13:30 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nicholas Kazlauskas , Mario Limonciello , Alex Deucher , Charlene Liu , Alex Hung , Daniel Wheeler , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, martin.leung@amd.com, wayne.lin@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 5.10 1/7] drm/amd/display: Exit idle optimizations before HDCP execution Message-ID: References: <20240527155845.3866271-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YGoPnplstVZpGpv1" Content-Disposition: inline In-Reply-To: <20240527155845.3866271-1-sashal@kernel.org> X-Mailman-Approved-At: Wed, 19 Jun 2024 07:13:04 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --YGoPnplstVZpGpv1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > [WHY] > PSP can access DCN registers during command submission and we need > to ensure that DCN is not in PG before doing so. >=20 > [HOW] > Add a callback to DM to lock and notify DC for idle optimization exit. > It can't be DC directly because of a potential race condition with the > link protection thread and the rest of DM operation. Why is this picked for 5.10-stable? It adds an callback, but noone is going to use it in 5.10. Best regards, Pavel > +++ b/drivers/gpu/drm/amd/display/modules/inc/mod_hdcp.h > @@ -143,6 +143,13 @@ struct mod_hdcp_ddc { > } funcs; > }; > =20 > +struct mod_hdcp_dm { > + void *handle; > + struct { > + void (*exit_idle_optimizations)(void *handle); > + } funcs; > +}; > + > struct mod_hdcp_psp { > void *handle; > void *funcs; > @@ -252,6 +259,7 @@ struct mod_hdcp_display_query { > struct mod_hdcp_config { > struct mod_hdcp_psp psp; > struct mod_hdcp_ddc ddc; > + struct mod_hdcp_dm dm; > uint8_t index; > }; > =20 --=20 DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --YGoPnplstVZpGpv1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZnFPugAKCRAw5/Bqldv6 8n/jAJ4vdLX0NDgd9EnqTJMgp289HWx28ACdG5FSE6Odu7KzIHv1ij/9v0enmII= =5AhM -----END PGP SIGNATURE----- --YGoPnplstVZpGpv1--