From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D646C52D71 for ; Fri, 9 Aug 2024 08:50:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60B6210E87D; Fri, 9 Aug 2024 08:50:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; secure) header.d=ffwll.ch header.i=@ffwll.ch header.b="UnPmbTi/"; dkim-atps=neutral Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8AE810E87A for ; Fri, 9 Aug 2024 08:50:52 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5af2329d5e1so147075a12.3 for ; Fri, 09 Aug 2024 01:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1723193451; x=1723798251; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lQRObQqCFZFZYE2PihhMktYKpOnSYLhGhrUknpNXXAI=; b=UnPmbTi/T6qh3cqfZ1RCeV+afFtyMSR0UNKFW0LI/2NaKzKs5ZRmjUUFi8DQnp4Ro7 86BtIGknpkp/SnplOIacdBqJLB62yVfg6BZ+2Oyok/+NSDcf2WdbqhOlue+YaR7NNFb6 0cHjeuRTkEfnvgInrXR18ZMGJr416Dgg/wyAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723193451; x=1723798251; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lQRObQqCFZFZYE2PihhMktYKpOnSYLhGhrUknpNXXAI=; b=ABDtvI+3Zy4kYdjF8FAervEoGFo4/4MqrS0MW/QFweYuDVLRqsnoxcVvbpcJF9Mlro AeYoNNwUutQX+RAD27mktwxaMzQ7UG6XOcy6kLHkPuPXp2KaPJ+ZBEWFgRGiVOQ3EUaG UybsdBJ/XfwjAeGC5QSjk+FtxZdEoSwCtKq/ca+3lOLueJDYqOyE7P/QNsjfNTxUKuKv o6r6oXCqYfa3/RYqMLoe4xbd/tJzRKvHKBze8t2WixMbJhH3T4t2/SD1+2j3l32m4gk/ +26Hq3L/5n3dH4yHYuo5uIm/FNckYgWDaO5rwcN5SZGvlu4LjUBMOfKQkE+hmURFRtoo aoQA== X-Forwarded-Encrypted: i=1; AJvYcCVBu9D4IrdzNGmhW6zNaHQ8g9OcH0eFs6gtPAa/WeSHdmsrKu1eKs47wNkgHuZxCaBBJ/QrN0FEXis7Krg1HDEt0oihSoUylaJwUKw0lA== X-Gm-Message-State: AOJu0Yx1+yueDEylszOVoNDLbwdBPPt7cRs/bwrAPH9RYgk7yI7HCqkI vNqaUGa2C8878reVY2IEvx/tzkt8t/uNAVoB/MsFOocn02k0us9mNroYEDxHpSM= X-Google-Smtp-Source: AGHT+IHRygqvDnnywjWcgRJH7u2cR+TWxwLzqYu/6B0OD8g3Hvi3p2zslutluZFIgpQTKdZKkV92Bg== X-Received: by 2002:a17:907:3e21:b0:a80:a1b0:12ec with SMTP id a640c23a62f3a-a80aa5a3e45mr40641366b.3.1723193450825; Fri, 09 Aug 2024 01:50:50 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d45418sm820836066b.113.2024.08.09.01.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 01:50:50 -0700 (PDT) Date: Fri, 9 Aug 2024 10:50:48 +0200 From: Daniel Vetter To: Thomas Zimmermann Cc: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, kherbst@redhat.com, lyude@redhat.com, dakr@redhat.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH 6/8] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed() Message-ID: References: <20240807084539.304014-1-tzimmermann@suse.de> <20240807084539.304014-7-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807084539.304014-7-tzimmermann@suse.de> X-Operating-System: Linux phenom 6.9.10-amd64 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Aug 07, 2024 at 10:41:38AM +0200, Thomas Zimmermann wrote: > The function is unused. Remove it. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Without the next patch to remove ->lastclose there's some confusion text left in the DOC: section in drm_fb_helper.c, but no point to split that up perfectly imo. Was just trying to find it and didn't find it only looking at the poll_changed patches ... -Sima > --- > drivers/gpu/drm/drm_fb_helper.c | 15 --------------- > include/drm/drm_fb_helper.h | 6 ------ > 2 files changed, 21 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index f6667dfba8a2..3cafb28236f7 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -2015,18 +2015,3 @@ void drm_fb_helper_lastclose(struct drm_device *dev) > > } > EXPORT_SYMBOL(drm_fb_helper_lastclose); > - > -/** > - * drm_fb_helper_output_poll_changed - DRM mode config \.output_poll_changed > - * helper for fbdev emulation > - * @dev: DRM device > - * > - * This function can be used as the > - * &drm_mode_config_funcs.output_poll_changed callback for drivers that only > - * need to call drm_fbdev.hotplug_event(). > - */ > -void drm_fb_helper_output_poll_changed(struct drm_device *dev) > -{ > - drm_fb_helper_hotplug_event(dev->fb_helper); > -} > -EXPORT_SYMBOL(drm_fb_helper_output_poll_changed); > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 375737fd6c36..699f2790b9ac 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -271,9 +271,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper); > int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper); > int drm_fb_helper_debug_enter(struct fb_info *info); > int drm_fb_helper_debug_leave(struct fb_info *info); > - > void drm_fb_helper_lastclose(struct drm_device *dev); > -void drm_fb_helper_output_poll_changed(struct drm_device *dev); > #else > static inline void drm_fb_helper_prepare(struct drm_device *dev, > struct drm_fb_helper *helper, > @@ -401,10 +399,6 @@ static inline int drm_fb_helper_debug_leave(struct fb_info *info) > static inline void drm_fb_helper_lastclose(struct drm_device *dev) > { > } > - > -static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev) > -{ > -} > #endif > > #endif > -- > 2.46.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch