From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2EA8CF6D2C for ; Wed, 2 Oct 2024 13:48:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D0F910E742; Wed, 2 Oct 2024 13:48:45 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 78B2689358 for ; Wed, 2 Oct 2024 13:48:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2F97339 for ; Wed, 2 Oct 2024 06:49:12 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CAFA83F64C for ; Wed, 2 Oct 2024 06:48:42 -0700 (PDT) Date: Wed, 2 Oct 2024 14:48:34 +0100 From: Liviu Dudau To: Thomas Zimmermann Cc: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 02/28] drm/arm/hdlcd: Use video aperture helpers Message-ID: References: <20240930130921.689876-1-tzimmermann@suse.de> <20240930130921.689876-3-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240930130921.689876-3-tzimmermann@suse.de> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Sep 30, 2024 at 03:03:00PM +0200, Thomas Zimmermann wrote: > DRM's aperture functions have long been implemented as helpers > under drivers/video/ for use with fbdev. Avoid the DRM wrappers by > calling the video functions directly. > > Signed-off-by: Thomas Zimmermann > Cc: Liviu Dudau Acked-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index f5d358f3893b..cd4389809d42 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -9,6 +9,7 @@ > * ARM HDLCD Driver > */ > > +#include > #include > #include > #include > @@ -21,7 +22,6 @@ > #include > #include > > -#include > #include > #include > #include > @@ -287,7 +287,7 @@ static int hdlcd_drm_bind(struct device *dev) > */ > if (hdlcd_read(hdlcd, HDLCD_REG_COMMAND)) { > hdlcd_write(hdlcd, HDLCD_REG_COMMAND, 0); > - drm_aperture_remove_framebuffers(&hdlcd_driver); > + aperture_remove_all_conflicting_devices(hdlcd_driver.name); > } > > drm_mode_config_reset(drm); > -- > 2.46.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯