AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: "Christian König" <christian.koenig@amd.com>, jiadong.zhu@amd.com
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>,
	Huang Rui <ray.huang@amd.com>,
	amd-gfx@lists.freedesktop.org,
	Luben Tuikov <Luben.Tuikov@amd.com>
Subject: Re: [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8)
Date: Fri, 21 Oct 2022 09:42:58 +0200	[thread overview]
Message-ID: <a182d22b-ee8a-3d17-e43d-0dec2e7c3c33@daenzer.net> (raw)
In-Reply-To: <a4e05017-ac7d-9872-dfad-257be85d1572@amd.com>

On 2022-10-20 16:59, Christian König wrote:
> Am 20.10.22 um 16:49 schrieb Michel Dänzer:
>> On 2022-10-18 11:08, jiadong.zhu@amd.com wrote:
>>> From: "Jiadong.Zhu" <Jiadong.Zhu@amd.com>
>>>
>>> The software ring is created to support priority context while there is only
>>> one hardware queue for gfx.
>>>
>>> Every software ring has its fence driver and could be used as an ordinary ring
>>> for the GPU scheduler.
>>> Multiple software rings are bound to a real ring with the ring muxer. The
>>> packages committed on the software ring are copied to the real ring.
>>>
>>> v2: Use array to store software ring entry.
>>> v3: Remove unnecessary prints.
>>> v4: Remove amdgpu_ring_sw_init/fini functions,
>>> using gtt for sw ring buffer for later dma copy
>>> optimization.
>>> v5: Allocate ring entry dynamically in the muxer.
>>> v6: Update comments for the ring muxer.
>>> v7: Modify for function naming.
>>> v8: Combine software ring functions into amdgpu_ring_mux.c
>> I tested patches 1-4 of this series (since Christian clearly nacked patch 5). I hit the oops below.
> 
> As long as you don't try to reset the GPU you can also test patch 5.

Sure, I can test it once there's a fix for the oops.


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer


  reply	other threads:[~2022-10-21  7:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  9:08 [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8) jiadong.zhu
2022-10-18  9:08 ` [PATCH 2/5] drm/amdgpu: Add software ring callbacks for gfx9 (v8) jiadong.zhu
2022-10-18  9:08 ` [PATCH 3/5] drm/amdgpu: Modify unmap_queue format for gfx9 (v4) jiadong.zhu
2022-11-22  5:46   ` Luben Tuikov
2022-10-18  9:08 ` [PATCH 4/5] drm/amdgpu: MCBP based on DRM scheduler (v8) jiadong.zhu
2022-10-31 12:01   ` Michel Dänzer
2022-11-01  1:04     ` Zhu, Jiadong
2022-11-01  9:10       ` Michel Dänzer
2022-11-01  9:58         ` Zhu, Jiadong
2022-11-01 10:09           ` Michel Dänzer
2022-11-02 11:26             ` Michel Dänzer
2022-11-03  2:58               ` Zhu, Jiadong
2022-11-03  9:04                 ` Michel Dänzer
2022-11-08  8:01                   ` Zhu, Jiadong
2022-11-10 17:00                     ` Michel Dänzer
2022-11-10 17:54                       ` Alex Deucher
2022-11-11  6:15                         ` Zhu, Jiadong
2022-11-14 17:15                       ` Michel Dänzer
2022-11-17  3:34                         ` Zhu, Jiadong
2022-11-10 19:27   ` Luben Tuikov
2022-10-18  9:08 ` [PATCH 5/5] drm/amdgpu: Improve the software ring priority scheduler jiadong.zhu
2022-10-18 11:24   ` Christian König
2022-10-19 15:14 ` [PATCH 1/5] drm/amdgpu: Introduce gfx software ring (v8) Luben Tuikov
2022-10-20 14:49 ` Michel Dänzer
2022-10-20 14:59   ` Christian König
2022-10-21  7:42     ` Michel Dänzer [this message]
2022-10-31  8:10     ` Zhu, Jiadong
2022-10-31 11:58       ` Michel Dänzer
2022-11-22  5:33 ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a182d22b-ee8a-3d17-e43d-0dec2e7c3c33@daenzer.net \
    --to=michel@daenzer.net \
    --cc=Andrey.Grodzovsky@amd.com \
    --cc=Luben.Tuikov@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=jiadong.zhu@amd.com \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox