From: Leo Liu <leo.liu-5C7GfCeVMHo@public.gmane.org>
To: James Zhu <jzhums-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: james.zhu-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu:Remove unused code
Date: Wed, 3 Oct 2018 09:14:53 -0400 [thread overview]
Message-ID: <a1de6a68-7ee7-cfc4-db49-0df93e10fa9f@amd.com> (raw)
In-Reply-To: <1538486426-5306-1-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
Reviewed-by: Leo Liu <leo.liu@amd.com>
On 10/02/2018 09:20 AM, James Zhu wrote:
> The following WREG32_SOC15_DPG_MODE will overwrite register
> mmUVD_CGC_CTRL. This code can be removed.
>
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> index 63d7f97..fbc05ef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -601,8 +601,6 @@ static void vcn_v1_0_clock_gating_dpg_mode(struct amdgpu_device *adev, uint8_t s
> reg_data = 0 << UVD_CGC_CTRL__DYN_CLOCK_MODE__SHIFT;
> reg_data |= 1 << UVD_CGC_CTRL__CLK_GATE_DLY_TIMER__SHIFT;
> reg_data |= 4 << UVD_CGC_CTRL__CLK_OFF_DELAY__SHIFT;
> - WREG32_SOC15_DPG_MODE(UVD, 0, mmUVD_CGC_CTRL, reg_data, 0xFFFFFFFF, sram_sel);
> -
> reg_data &= ~(UVD_CGC_CTRL__UDEC_RE_MODE_MASK |
> UVD_CGC_CTRL__UDEC_CM_MODE_MASK |
> UVD_CGC_CTRL__UDEC_IT_MODE_MASK |
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-10-03 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 13:20 [PATCH] drm/amdgpu:Remove unused code James Zhu
[not found] ` <1538486426-5306-1-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-10-03 13:14 ` Leo Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-04 9:16 [PATCH] drm/amdgpu : remove " jesse.zhang
2024-03-04 12:51 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1de6a68-7ee7-cfc4-db49-0df93e10fa9f@amd.com \
--to=leo.liu-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=james.zhu-5C7GfCeVMHo@public.gmane.org \
--cc=jzhums-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox