From: Bert Karwatzki <spasswolf@web.de>
To: amd-gfx@lists.freedesktop.org
Cc: Mike Lothian <mike@fireburn.co.uk>
Subject: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS
Date: Wed, 21 Dec 2022 22:12:30 +0100 [thread overview]
Message-ID: <a2525c9d1dbfe478f0969439febe55da3e150b60.camel@web.de> (raw)
Can you test if this solves the freezes:
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 919bbea2e3ac..4e684c2afc70 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -1506,7 +1509,8 @@ u64 amdgpu_bo_gpu_offset_no_check(struct
amdgpu_bo *bo)
uint32_t amdgpu_bo_get_preferred_domain(struct amdgpu_device *adev,
uint32_t domain)
{
- if (domain == (AMDGPU_GEM_DOMAIN_VRAM |
AMDGPU_GEM_DOMAIN_GTT)) {
+ if ((domain == (AMDGPU_GEM_DOMAIN_VRAM |
AMDGPU_GEM_DOMAIN_GTT)) &&
+ ((adev->asic_type == CHIP_CARRIZO) || (adev->asic_type ==
CHIP_STONEY))) {
domain = AMDGPU_GEM_DOMAIN_VRAM;
if (adev->gmc.real_vram_size <= AMDGPU_SG_THRESHOLD)
domain = AMDGPU_GEM_DOMAIN_GTT;
This solves a lot of seemingly unrelated errors:
https://gitlab.freedesktop.org/drm/amd/-/issues/2255
https://gitlab.freedesktop.org/drm/amd/-/issues/2270
https://gitlab.freedesktop.org/drm/amd/-/issues/2281
https://gitlab.freedesktop.org/drm/amd/-/issues/2282
https://gitlab.freedesktop.org/drm/amd/-/issues/2291
Bert Karwatzki
next reply other threads:[~2022-12-22 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 21:12 Bert Karwatzki [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-21 21:59 [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS Bert Karwatzki
2022-10-14 8:46 Fixes for scheduler hang when killing a process Christian König
2022-10-14 8:46 ` [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS Christian König
2022-10-24 5:55 ` Luben Tuikov
2022-12-21 15:34 ` Mike Lothian
2022-12-21 15:47 ` Mike Lothian
2022-12-21 15:52 ` Luben Tuikov
2022-12-21 15:55 ` Mike Lothian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2525c9d1dbfe478f0969439febe55da3e150b60.camel@web.de \
--to=spasswolf@web.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=mike@fireburn.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox