AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Mikhail Krylov <sqarert@gmail.com>, Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: Screen corruption using radeon kernel driver
Date: Wed, 30 Nov 2022 12:54:49 +0000	[thread overview]
Message-ID: <a5f73cfa-bd2a-3ab8-1e5c-253cfd832ea7@arm.com> (raw)
In-Reply-To: <Y4Y9SJC7gtUxP4+R@sqrt.uni.cx>

On 2022-11-29 17:11, Mikhail Krylov wrote:
> On Tue, Nov 29, 2022 at 11:05:28AM -0500, Alex Deucher wrote:
>> On Tue, Nov 29, 2022 at 10:59 AM Mikhail Krylov <sqarert@gmail.com> wrote:
>>>
>>> On Tue, Nov 29, 2022 at 09:44:19AM -0500, Alex Deucher wrote:
>>>> On Mon, Nov 28, 2022 at 3:48 PM Mikhail Krylov <sqarert@gmail.com> wrote:
>>>>>
>>>>> On Mon, Nov 28, 2022 at 09:50:50AM -0500, Alex Deucher wrote:
>>>>>
>>>>>>>> [excessive quoting removed]
>>>>>
>>>>>>> So, is there any progress on this issue? I do understand it's not a high
>>>>>>> priority one, and today I've checked it on 6.0 kernel, and
>>>>>>> unfortunately, it still persists...
>>>>>>>
>>>>>>> I'm considering writing a patch that will allow user to override
>>>>>>> need_dma32/dma_bits setting with a module parameter. I'll have some time
>>>>>>> after the New Year for that.
>>>>>>>
>>>>>>> Is it at all possible that such a patch will be merged into kernel?
>>>>>>>
>>>>>> On Mon, Nov 28, 2022 at 9:31 AM Mikhail Krylov <sqarert@gmail.com> wrote:
>>>>>> Unless someone familiar with HIMEM can figure out what is going wrong
>>>>>> we should just revert the patch.
>>>>>>
>>>>>> Alex
>>>>>
>>>>>
>>>>> Okay, I was suggesting that mostly because
>>>>>
>>>>> a) it works for me with dma_bits = 40 (I understand that's what it is
>>>>> without the original patch applied);
>>>>>
>>>>> b) there's a hint of uncertainity on this line
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/radeon/radeon_device.c#n1359
>>>>> saying that for AGP dma_bits = 32 is the safest option, so apparently there are
>>>>> setups, unlike mine, where dma_bits = 32 is better than 40.
>>>>>
>>>>> But I'm in no position to argue, just wanted to make myself clear.
>>>>> I'm okay with rebuilding the kernel for my machine until the original
>>>>> patch is reverted or any other fix is applied.
>>>>
>>>> What GPU do you have and is it AGP?  If it is AGP, does setting
>>>> radeon.agpmode=-1 also fix it?
>>>>
>>>> Alex
>>>
>>> That is ATI Radeon X1950, and, unfortunately, radeon.agpmode=-1 doesn't
>>> help, it just makes 3D acceleration in games such as OpenArena stop
>>> working.
>>
>> Just to confirm, is the board AGP or PCIe?
>>
>> Alex
> 
> It is AGP. That's an old machine.

Can you check whether dma_addressing_limited() is actually returning the 
expected result at the point of radeon_ttm_init()? Disabling highmem is 
presumably just hiding whatever problem exists, by throwing away all 
 >32-bit RAM such that use_dma32 doesn't matter.

Robin.

  reply	other threads:[~2022-11-30 14:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 16:31 Screen corruption using radeon kernel driver Krylov Michael
2022-04-25 17:22 ` Alex Deucher
2022-05-16 13:01   ` Mikhail Krylov
2022-11-28 14:31   ` Mikhail Krylov
2022-11-28 14:50     ` Alex Deucher
2022-11-28 20:48       ` Mikhail Krylov
2022-11-29 14:44         ` Alex Deucher
2022-11-29 15:59           ` Mikhail Krylov
2022-11-29 16:05             ` Alex Deucher
2022-11-29 17:11               ` Mikhail Krylov
2022-11-30 12:54                 ` Robin Murphy [this message]
2022-11-30 14:28                   ` Alex Deucher
2022-11-30 15:42                     ` Robin Murphy
2022-11-30 16:07                       ` Alex Deucher
2022-11-30 19:59                         ` Mikhail Krylov
2022-12-01 14:00                           ` Robin Murphy
2022-12-01 14:06                             ` Alex Deucher
2022-12-01 15:28                             ` Mikhail Krylov
2022-12-10 15:32                         ` Mikhail Krylov
2022-12-11  5:52                           ` Luben Tuikov
2022-12-11 11:42                             ` [PATCH] drm/radeon: Fix screen corruption Luben Tuikov
2022-12-12  2:08                               ` [PATCH] drm/radeon: Fix screen corruption (v2) Luben Tuikov
2022-12-14 21:53                                 ` Robin Murphy
2022-12-14 22:02                                   ` Alex Deucher
2022-12-14 23:08                                     ` Robin Murphy
2022-12-15  8:07                                       ` Christian König
2022-12-15  9:08                                         ` Luben Tuikov
2022-12-15  9:46                                           ` Christian König
2022-12-15 10:19                                             ` Luben Tuikov
2022-12-15 11:27                                               ` Christian König
2022-12-15 11:40                                                 ` Luben Tuikov
2022-12-15 11:53                                                   ` Robin Murphy
2022-12-15 12:07                                                     ` Luben Tuikov
2023-01-19 16:56                                                       ` Krylov Michael
2023-01-20  4:31                                                         ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5f73cfa-bd2a-3ab8-1e5c-253cfd832ea7@arm.com \
    --to=robin.murphy@arm.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sqarert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox