AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dieter Nützel" <Dieter-0hun7QTegEsDD4udEopG9Q@public.gmane.org>
To: "Christian König"
	<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: Operation context for TTM
Date: Tue, 21 Nov 2017 03:49:25 +0100	[thread overview]
Message-ID: <a7b5b5c56edbc84eac5f76a92da6971b@nuetzel-hh.de> (raw)
In-Reply-To: <cb11aafa8199f35d8ab93f7199c1f1c0-0hun7QTegEsDD4udEopG9Q@public.gmane.org>

Hello Christian,

your latest 'amd-staging-drm-next' commit
drm/amdgpu: fix VCE buffer placement restrictions v2
#9f896d936c9d4ea936a02d52eaeb14fdd209193b

static int amdgpu_vce_validate_bo(struct amdgpu_cs_parser *p, uint32_t 
ib_idx,
				  int lo, int hi, unsigned size, int32_t index)

[-]

return ttm_bo_validate(&bo->tbo, &bo->placement, false, false);

^^^^^^
'ttm_bo_validate' with 4 than 3 parameter clash.

drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c: In function 
‘amdgpu_vce_validate_bo’:
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:590:9: error: too many arguments 
to function ‘ttm_bo_validate’
   return ttm_bo_validate(&bo->tbo, &bo->placement, false, false);
          ^~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu.h:39:0,
                  from drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:33:
./include/drm/ttm/ttm_bo_api.h:334:5: note: declared here
  int ttm_bo_validate(struct ttm_buffer_object *bo,
      ^~~~~~~~~~~~~~~

New version comming?

Thanks,
Dieter


Am 20.11.2017 05:35, schrieb Dieter Nützel:
> For the series:
> 
> Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
> 
> on RX580
> amd-staging-drm-next 85d09ce5e5039644487e9508d6359f9f4cf64427
> 
> with glmark2, DiRT Rally and F1 2017 (radv)
> 
> Dieter
> 
> Am 17.11.2017 11:49, schrieb Christian König:
>> Hi everyone,
>> 
>> Michel already reviewed this back in April, but I didn't found time to
>> actually fully test it before now.
>> 
>> So sending this one out once more because it's an interface change
>> which affects all driver using TTM.
>> 
>> Please review and/or comment.
>> 
>> Regards,
>> Christian.
>> 
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-11-21  2:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 10:49 Operation context for TTM Christian König
2017-11-17 10:49 ` [PATCH 1/8] drm/ttm: add operation ctx to ttm_bo_validate v2 Christian König
     [not found]   ` <20171117104935.4150-2-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2017-11-20 10:14     ` Daniel Vetter
2017-11-17 10:49 ` [PATCH 2/8] drm/ttm: use an operation ctx for ttm_bo_init_reserved Christian König
2017-11-17 10:49 ` [PATCH 4/8] drm/ttm: use the operation context inside TTM Christian König
     [not found] ` <20171117104935.4150-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2017-11-17 10:49   ` [PATCH 3/8] drm/ttm: use an operation context for ttm_bo_mem_space v2 Christian König
2017-11-17 10:49   ` [PATCH 5/8] drm/ttm: add context to driver move callback as well Christian König
2017-11-17 10:49   ` [PATCH 6/8] drm/ttm: add number of bytes moved to the operation context Christian König
2017-11-17 10:49   ` [PATCH 8/8] drm/amdgpu: use the new TTM bytes moved counter v2 Christian König
     [not found]     ` <20171117104935.4150-9-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2017-11-20  2:38       ` Chunming Zhou
2017-11-17 14:55   ` Operation context for TTM Michel Dänzer
2017-11-17 20:26   ` Felix Kuehling
2017-11-20  4:35   ` Dieter Nützel
     [not found]     ` <cb11aafa8199f35d8ab93f7199c1f1c0-0hun7QTegEsDD4udEopG9Q@public.gmane.org>
2017-11-21  2:49       ` Dieter Nützel [this message]
2017-11-17 10:49 ` [PATCH 7/8] drm/amdgpu: forward operation context to ttm_bo_mem_space Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7b5b5c56edbc84eac5f76a92da6971b@nuetzel-hh.de \
    --to=dieter-0hun7qtegesdd4udeopg9q@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox