Re: [PATCH 1/3] drm/amd: Remove redundant pm_runtime_mark_last_busy() calls

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Alexander,

On Mon, Oct 27, 2025 at 03:52:28PM +0000, Deucher, Alexander wrote:
> [Public]
> 
> > -----Original Message-----
> > From: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Sent: Monday, October 27, 2025 9:15 AM
> > To: dri-devel@lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> > <Christian.Koenig@amd.com>; David Airlie <airlied@gmail.com>; Simona Vetter
> > <simona@ffwll.ch>; Kuehling, Felix <Felix.Kuehling@amd.com>; Feng, Kenneth
> > <Kenneth.Feng@amd.com>; Lyude Paul <lyude@redhat.com>; Danilo Krummrich
> > <dakr@kernel.org>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>;
> > Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann
> > <tzimmermann@suse.de>; Limonciello, Mario <Mario.Limonciello@amd.com>;
> > Hung, Alex <Alex.Hung@amd.com>; Antonio Quartulli <antonio@mandelbit.com>;
> > Nirujogi, Pratap <Pratap.Nirujogi@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>;
> > Dmitry Baryshkov <lumag@kernel.org>; SHANMUGAM, SRINIVASAN
> > <SRINIVASAN.SHANMUGAM@amd.com>; Wang, Yang(Kevin)
> > <KevinYang.Wang@amd.com>; Khatri, Sunil <Sunil.Khatri@amd.com>; Zhang,
> > Jesse(Jie) <Jesse.Zhang@amd.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>;
> > Liviu Dudau <liviu.dudau@arm.com>; Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>; Zhang, Hawking
> > <Hawking.Zhang@amd.com>; Prosyak, Vitaly <Vitaly.Prosyak@amd.com>; Arnd
> > Bergmann <arnd@arndb.de>; Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar
> > <mingo@kernel.org>; Liao Yuanhong <liaoyuanhong@vivo.com>; Rodrigo Siqueira
> > <siqueira@igalia.com>; Liang, Prike <Prike.Liang@amd.com>; Sharma, Shashank
> > <Shashank.Sharma@amd.com>; Paneer Selvam, Arunpravin
> > <Arunpravin.PaneerSelvam@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>;
> > Chai, Thomas <YiPeng.Chai@amd.com>; Xie, Patrick <Gangliang.Xie@amd.com>;
> > Liu, Xiang(Dean) <Xiang.Liu@amd.com>; Skvortsov, Victor
> > <Victor.Skvortsov@amd.com>; Sun, Ce(Overlord) <Ce.Sun@amd.com>; Dave
> > Airlie <airlied@redhat.com>; Jani Nikula <jani.nikula@intel.com>; Gustavo A. R.
> > Silva <gustavoars@kernel.org>; Imre Deak <imre.deak@intel.com>; Ben Skeggs
> > <bskeggs@nvidia.com>; nouveau@lists.freedesktop.org; amd-
> > gfx@lists.freedesktop.org
> > Subject: [PATCH 1/3] drm/amd: Remove redundant pm_runtime_mark_last_busy()
> > calls
> >
> > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to
> > pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> > pm_runtime_mark_last_busy().
> 
> 
> Typo: should be "now-redundant"

Oops. You're first one to notice, in fact.

> 
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> Patches 1, 3 are:
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> 
> When did mark_last_busy get pulled into the other runtime_pm functions?
> Did you want me to pick these up or did you want to send them via some
> other tree?

Yes, please merge these.

pm_runtime_mark_last_busy() has been part of autosuspend related functions
since commit 18c1fe53d186867243f4cf17f4eef60737a16c4c, i.e. v6.17.

-- 
Kind regards,

Sakari Ailus