* [PATCH] drm/amd: Add missing return for VPE idle handler
@ 2025-10-20 22:34 Mario Limonciello
2025-10-20 22:36 ` Alex Deucher
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mario Limonciello @ 2025-10-20 22:34 UTC (permalink / raw)
To: mario.limonciello, amd-gfx; +Cc: stable, Sultan Alsawaf
Adjusting the idle handler for DPM0 handling forgot a return statement
which causes the system to not be able to enter s0i3.
Add the missing return statement.
Cc: stable@vger.kernel.org
Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
index f4932339d79d..aa78c2ee9e21 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
@@ -356,6 +356,7 @@ static void vpe_idle_work_handler(struct work_struct *work)
goto reschedule;
amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE, AMD_PG_STATE_GATE);
+ return;
reschedule:
schedule_delayed_work(&adev->vpe.idle_work, VPE_IDLE_TIMEOUT);
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd: Add missing return for VPE idle handler
2025-10-20 22:34 [PATCH] drm/amd: Add missing return for VPE idle handler Mario Limonciello
@ 2025-10-20 22:36 ` Alex Deucher
2025-10-20 22:38 ` Sultan Alsawaf
2025-10-20 22:42 ` Sultan Alsawaf
2 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2025-10-20 22:36 UTC (permalink / raw)
To: Mario Limonciello; +Cc: amd-gfx, stable, Sultan Alsawaf
On Mon, Oct 20, 2025 at 6:35 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> Adjusting the idle handler for DPM0 handling forgot a return statement
> which causes the system to not be able to enter s0i3.
>
> Add the missing return statement.
>
> Cc: stable@vger.kernel.org
> Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> index f4932339d79d..aa78c2ee9e21 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> @@ -356,6 +356,7 @@ static void vpe_idle_work_handler(struct work_struct *work)
> goto reschedule;
>
> amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE, AMD_PG_STATE_GATE);
> + return;
>
> reschedule:
> schedule_delayed_work(&adev->vpe.idle_work, VPE_IDLE_TIMEOUT);
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd: Add missing return for VPE idle handler
2025-10-20 22:34 [PATCH] drm/amd: Add missing return for VPE idle handler Mario Limonciello
2025-10-20 22:36 ` Alex Deucher
@ 2025-10-20 22:38 ` Sultan Alsawaf
2025-10-20 22:42 ` Sultan Alsawaf
2 siblings, 0 replies; 6+ messages in thread
From: Sultan Alsawaf @ 2025-10-20 22:38 UTC (permalink / raw)
To: Mario Limonciello; +Cc: amd-gfx, stable
On Mon, Oct 20, 2025 at 05:34:34PM -0500, Mario Limonciello wrote:
> Adjusting the idle handler for DPM0 handling forgot a return statement
> which causes the system to not be able to enter s0i3.
>
> Add the missing return statement.
>
> Cc: stable@vger.kernel.org
> Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Sultan Alsawaf <sultan@kerneltoast.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd: Add missing return for VPE idle handler
2025-10-20 22:34 [PATCH] drm/amd: Add missing return for VPE idle handler Mario Limonciello
2025-10-20 22:36 ` Alex Deucher
2025-10-20 22:38 ` Sultan Alsawaf
@ 2025-10-20 22:42 ` Sultan Alsawaf
2025-10-20 22:45 ` Sultan Alsawaf
2 siblings, 1 reply; 6+ messages in thread
From: Sultan Alsawaf @ 2025-10-20 22:42 UTC (permalink / raw)
To: Mario Limonciello; +Cc: amd-gfx, stable
On Mon, Oct 20, 2025 at 05:34:34PM -0500, Mario Limonciello wrote:
> Adjusting the idle handler for DPM0 handling forgot a return statement
> which causes the system to not be able to enter s0i3.
>
> Add the missing return statement.
>
> Cc: stable@vger.kernel.org
> Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
I just noticed that this link doesn't work; it seems like that email of mine
didn't make it onto the amd-gfx list?
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> index f4932339d79d..aa78c2ee9e21 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> @@ -356,6 +356,7 @@ static void vpe_idle_work_handler(struct work_struct *work)
> goto reschedule;
>
> amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE, AMD_PG_STATE_GATE);
> + return;
>
> reschedule:
> schedule_delayed_work(&adev->vpe.idle_work, VPE_IDLE_TIMEOUT);
> --
> 2.49.0
>
Sultan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd: Add missing return for VPE idle handler
2025-10-20 22:42 ` Sultan Alsawaf
@ 2025-10-20 22:45 ` Sultan Alsawaf
2025-10-21 20:25 ` Mario Limonciello
0 siblings, 1 reply; 6+ messages in thread
From: Sultan Alsawaf @ 2025-10-20 22:45 UTC (permalink / raw)
To: Mario Limonciello; +Cc: amd-gfx, stable
On Mon, Oct 20, 2025 at 03:42:26PM -0700, Sultan Alsawaf wrote:
> On Mon, Oct 20, 2025 at 05:34:34PM -0500, Mario Limonciello wrote:
> > Adjusting the idle handler for DPM0 handling forgot a return statement
> > which causes the system to not be able to enter s0i3.
> >
> > Add the missing return statement.
> >
> > Cc: stable@vger.kernel.org
> > Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
> > Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
>
> I just noticed that this link doesn't work; it seems like that email of mine
> didn't make it onto the amd-gfx list?
Ouch, looks like none of my emails today are showing up on amd-gfx. :-\
Sultan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd: Add missing return for VPE idle handler
2025-10-20 22:45 ` Sultan Alsawaf
@ 2025-10-21 20:25 ` Mario Limonciello
0 siblings, 0 replies; 6+ messages in thread
From: Mario Limonciello @ 2025-10-21 20:25 UTC (permalink / raw)
To: Sultan Alsawaf; +Cc: amd-gfx, stable
On 10/20/2025 5:45 PM, Sultan Alsawaf wrote:
> On Mon, Oct 20, 2025 at 03:42:26PM -0700, Sultan Alsawaf wrote:
>> On Mon, Oct 20, 2025 at 05:34:34PM -0500, Mario Limonciello wrote:
>>> Adjusting the idle handler for DPM0 handling forgot a return statement
>>> which causes the system to not be able to enter s0i3.
>>>
>>> Add the missing return statement.
>>>
>>> Cc: stable@vger.kernel.org
>>> Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
>>> Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
>>
>> I just noticed that this link doesn't work; it seems like that email of mine
>> didn't make it onto the amd-gfx list?
>
> Ouch, looks like none of my emails today are showing up on amd-gfx. :-\
>
> Sultan
Some seem to have shown up but this one is missing. No idea why.
Anyway, it is what it is, at least it's fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-21 20:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 22:34 [PATCH] drm/amd: Add missing return for VPE idle handler Mario Limonciello
2025-10-20 22:36 ` Alex Deucher
2025-10-20 22:38 ` Sultan Alsawaf
2025-10-20 22:42 ` Sultan Alsawaf
2025-10-20 22:45 ` Sultan Alsawaf
2025-10-21 20:25 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).