From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65898CCFA1E for ; Tue, 11 Nov 2025 13:39:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED38110E5DC; Tue, 11 Nov 2025 13:39:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="Sg/1b80c"; dkim-atps=neutral Received: from mail-oa1-f65.google.com (mail-oa1-f65.google.com [209.85.160.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 39EF210E4D4 for ; Tue, 11 Nov 2025 01:17:44 +0000 (UTC) Received: by mail-oa1-f65.google.com with SMTP id 586e51a60fabf-3d47192e99bso257786fac.0 for ; Mon, 10 Nov 2025 17:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1762823863; x=1763428663; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=IjPKo3ybe4fdml1XQE+jQ3G55BcDMlVXlR9cl8yZWH4=; b=Sg/1b80cSg9HS8KmTenbbosx+1MITYNBqdE1kcZptDynIcUkI30L00lyONfLq3I+8R IR7Mky7pDomXAcSwgtXVAb4TlIpJRYH+szUIWw15lmbvzQ4GzanO5sqX5QfedGnG4T48 1vR1olFyVcZ3NHHqRxhIL9Lie3XhVVmS7a43lWvF0B8oNl/rIY15uVG6QgxtHhIXhlDf WmWbfky/Rl7x70x3Xp27x5lZaO4g+n30ueFVRv2GXlhjiDGGKC8RFmGVbPuTWB2H/b+n 4g4F/FVjQl+YyH2vKK82TGvnGQOLgMNYaeAbrwxKWjJ3yaqj8Jz4YULw8DEY9GbjnoRk azrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762823863; x=1763428663; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IjPKo3ybe4fdml1XQE+jQ3G55BcDMlVXlR9cl8yZWH4=; b=YAppF6izWYJu0KzwUvFAyw+M8JuluCDgfF55tjMqD25/VDWYBXtCnsfyrJ6uo4oaKX PFqE6DfyM1wB8YJSIrxnybKp5LeTtoCdT3fPVyqe+WphWBTCW4we8wZb4edlU+vMdtus F9E6qeu+iLEzrb4O2apevl3Arq5cVE5T0+bBsUmFMhoLlQCKLqJ6sFphkUkETPutb6uJ nerS9y4ban8hGSNK4q5ezWu4EWEFZxSakJNw4wzzTMqwClbkkMVoZJjUfeE8zfTDVlBz 8ZDGFb4pGQolfsxFUn/574y1EI0OHdpTd84sRTgFU48nkMSXoG4I6JkVbpWdcmSq73ag p9Lw== X-Forwarded-Encrypted: i=1; AJvYcCWOjlpXBe+6qAcV7tiztAmuWU9FRnJme2VA4XJ7F2MkuM+yy7vwB919HlOUco2tKlgP0hLZgbKR@lists.freedesktop.org X-Gm-Message-State: AOJu0YyibZftG7RkZbaKiAtUHM/LqoVaiqHYQeUmpXPNOYSOYfpPN2sn x0PIimq22z87m6c9Q1I+Gi8P1H2jkndyCbEMkaJvG0ZNbYnHVQs0Sm8SoKcX9G5OxmA= X-Gm-Gg: ASbGncvX++xBaP7am1w+ZIKZUXvWW07LoTHtwD+z07YnQ37MHzAi0/ew6H9GL1SVQFz +8VXbmTibScCopjHNWO7DVtdSmE9fLsk6WhlpxuheRUx17wedLnHmUP1icmJEGDyESD77Efwdi2 cqWnbqUvyxSAxG5vp3nDGaA5VLt7sP+WVOhQ0BogeimXLs5H1MmEfLLIgObMPRFS6tZP5BvgpXF FsV/zTHiWuhHO0RidmQL9f4VxEbeiPCmbmvSsG+fg0+8jJHWc9NQgTFxcvGhfvSJH5pxeGPMOGL v9Y1RQuCdiLCKd1qrq4rntpaiPXWyfTXVxZYQlmiT1WbovqkU134ydEqW/Wkl9ibGVXv94Ll1ho xvkLVpyfCzJA2A8rb1rUWhHFvMM0uDjZqqawddg8LHkEwZfA6LDAdGsUfiJ6y/Dz3A9cLCLtDep O46/QHz/HdKgq7fQ== X-Google-Smtp-Source: AGHT+IHYqlJ/DqUior2uObKb688W9mKskJnwhdBfDC1sLOPoqWKjn2HRpxRv5pN7HFxTPVj3Axvofg== X-Received: by 2002:a05:6870:46a8:b0:3e1:d34:4283 with SMTP id 586e51a60fabf-3e815aaa2a3mr850172fac.19.1762823862970; Mon, 10 Nov 2025 17:17:42 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:b4e9:19a3:cdaf:7174]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3e7d6f7a27dsm4076840fac.0.2025.11.10.17.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 17:17:41 -0800 (PST) Date: Mon, 10 Nov 2025 19:17:35 -0600 From: Corey Minyard To: Andy Shevchenko Cc: Christian K??nig , "Dr. David Alan Gilbert" , Alex Deucher , Thomas Zimmermann , Dmitry Baryshkov , Rob Clark , Matthew Brost , Hans Verkuil , Laurent Pinchart , Ulf Hansson , Vitaly Lifshits , Manivannan Sadhasivam , Niklas Cassel , Calvin Owens , Sagi Maimon , "Martin K. Petersen" , Karan Tilak Kumar , Casey Schaufler , Steven Rostedt , Petr Mladek , Max Kellermann , Takashi Iwai , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, ceph-devel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Sumit Semwal , Gustavo Padovan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Konrad Dybcio , Lucas De Marchi , Thomas Hellstr??m , Rodrigo Vivi , Mauro Carvalho Chehab , Vladimir Oltean , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Krzysztof Wilczy??ski , Kishon Vijay Abraham I , Bjorn Helgaas , Rodolfo Giometti , Jonathan Lemon , Vadim Fedorenko , Richard Cochran , Stefan Haberland , Jan Hoeppner , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Satish Kharat , Sesidhar Baddela , "James E.J. Bottomley" , Greg Kroah-Hartman , Xiubo Li , Ilya Dryomov , Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 12/23] ipmi: Switch to use %ptSp Message-ID: References: <20251110184727.666591-1-andriy.shevchenko@linux.intel.com> <20251110184727.666591-13-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251110184727.666591-13-andriy.shevchenko@linux.intel.com> X-Mailman-Approved-At: Tue, 11 Nov 2025 13:39:06 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: corey@minyard.net Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Nov 10, 2025 at 07:40:31PM +0100, Andy Shevchenko wrote: > Use %ptSp instead of open coded variants to print content of > struct timespec64 in human readable format. > > Signed-off-by: Andy Shevchenko Quite a bit neater, yes. Acked-by: Corey Minyard > --- > drivers/char/ipmi/ipmi_si_intf.c | 3 +-- > drivers/char/ipmi/ipmi_ssif.c | 6 ++---- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 70e55f5ff85e..5459ffdde8dc 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -275,8 +275,7 @@ void debug_timestamp(struct smi_info *smi_info, char *msg) > struct timespec64 t; > > ktime_get_ts64(&t); > - dev_dbg(smi_info->io.dev, "**%s: %lld.%9.9ld\n", > - msg, t.tv_sec, t.tv_nsec); > + dev_dbg(smi_info->io.dev, "**%s: %ptSp\n", msg, &t); > } > #else > #define debug_timestamp(smi_info, x) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 1b63f7d2fcda..ef1582a029f4 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1083,10 +1083,8 @@ static int sender(void *send_info, struct ipmi_smi_msg *msg) > struct timespec64 t; > > ktime_get_real_ts64(&t); > - dev_dbg(&ssif_info->client->dev, > - "**Enqueue %02x %02x: %lld.%6.6ld\n", > - msg->data[0], msg->data[1], > - (long long)t.tv_sec, (long)t.tv_nsec / NSEC_PER_USEC); > + dev_dbg(&ssif_info->client->dev, "**Enqueue %02x %02x: %ptSp\n", > + msg->data[0], msg->data[1], &t); > } > return IPMI_CC_NO_ERROR; > } > -- > 2.50.1 >