From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grodzovsky, Andrey" Subject: Re: [PATCH 3/5] drm/amdgpu: Refactor amdgpu_xgmi_add_device Date: Wed, 21 Nov 2018 19:36:13 +0000 Message-ID: References: <1542823821-15631-1-git-send-email-andrey.grodzovsky@amd.com> <1542823821-15631-4-git-send-email-andrey.grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: "Deucher, Alexander" , "Liu, Monk" , amd-gfx list DQoNCk9uIDExLzIxLzIwMTggMDI6MjkgUE0sIEFsZXggRGV1Y2hlciB3cm90ZToNCj4gT24gV2Vk LCBOb3YgMjEsIDIwMTggYXQgMToxMSBQTSBBbmRyZXkgR3JvZHpvdnNreQ0KPiA8YW5kcmV5Lmdy b2R6b3Zza3lAYW1kLmNvbT4gd3JvdGU6DQo+PiBUaGlzIGlzIHByZXAgd29yayBmb3IgdXBkYXRp bmcgZWFjaCBQU1AgRlcgaW4gaGl2ZSBhZnRlcg0KPj4gR1BVIHJlc2V0Lg0KPj4gU3BsaXQgaW50 byBidWlsZCB0b3BvbG9neSBTVyBzdGF0ZSBhbmQgdXBkYXRlIGVhY2ggUFNQIEZXIGluIHRoZSBo aXZlLg0KPj4gU2F2ZSB0b3BvbG9neSBhbmQgY291bnQgb2YgWEdNSSBkZXZpY2VzIGZvciByZXVz ZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkgR3JvZHpvdnNreSA8YW5kcmV5Lmdyb2R6 b3Zza3lAYW1kLmNvbT4NCj4+IC0tLQ0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHUuaCAgICAgIHwgIDUgKysrDQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV94Z21pLmMgfCA1NSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQ0KPj4gICAy IGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQ0KPj4NCj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaCBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oDQo+PiBpbmRleCAyYzgwNDUzLi4zZTViZWRl IDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgNCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oDQo+PiBAQCAtMTIyNiw2 ICsxMjI2LDExIEBAIGxvbmcgYW1kZ3B1X2ttc19jb21wYXRfaW9jdGwoc3RydWN0IGZpbGUgKmZp bHAsIHVuc2lnbmVkIGludCBjbWQsDQo+PiAgIC8qDQo+PiAgICAqIGZ1bmN0aW9ucyB1c2VkIGJ5 IGFtZGdwdV94Z21pLmMNCj4+ICAgICovDQo+PiArDQo+PiArc3RydWN0IGFtZGdwdV9oaXZlX2lu Zm87DQo+PiArDQo+PiArc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmFtZGdwdV9nZXRfeGdtaV9o aXZlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsNCj4+ICtpbnQgYW1kZ3B1X3hnbWlfdXBk YXRlX3RvcG9sb2d5KHN0cnVjdCBhbWRncHVfaGl2ZV9pbmZvICpoaXZlKTsNCj4+ICAgaW50IGFt ZGdwdV94Z21pX2FkZF9kZXZpY2Uoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpOw0KPiBXZSBz aG91bGQgbW92ZSB0aGVzZSB0byB0aGVpciBvd24gaGVhZGVyLCBhbWRncHVfeGdtaS5oLCByYXRo ZXIgdGhhbg0KPiBkdW1waW5nIHRoZW0gaW4gYW1kZ3B1LmgNCj4NCj4+ICAgLyoNCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfeGdtaS5jIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3hnbWkuYw0KPj4gaW5kZXggOTA5MjE2YS4uMjNl NGUxNiAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94 Z21pLmMNCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmMN Cj4+IEBAIC0zNCwxMiArMzQsMTQgQEAgc3RhdGljIERFRklORV9NVVRFWCh4Z21pX211dGV4KTsN Cj4+ICAgc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gew0KPj4gICAgICAgICAgdWludDY0X3QgICAg ICAgICAgICAgICAgaGl2ZV9pZDsNCj4+ICAgICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgICAgICAg IGRldmljZV9saXN0Ow0KPj4gKyAgICAgICBzdHJ1Y3QgcHNwX3hnbWlfdG9wb2xvZ3lfaW5mbyAg IHRvcG9sb2d5X2luZm87DQo+PiArICAgICAgIGludCBudW1iZXJfZGV2aWNlczsNCj4+ICAgfTsN Cj4+DQo+PiAgIHN0YXRpYyBzdHJ1Y3QgYW1kZ3B1X2hpdmVfaW5mbyB4Z21pX2hpdmVzW0FNREdQ VV9NQVhfWEdNSV9ISVZFXTsNCj4+ICAgc3RhdGljIHVuc2lnbmVkIGhpdmVfY291bnQgPSAwOw0K Pj4NCj4+IC1zdGF0aWMgc3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKmFtZGdwdV9nZXRfeGdtaV9o aXZlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQ0KPj4gK3N0cnVjdCBhbWRncHVfaGl2ZV9p bmZvICphbWRncHVfZ2V0X3hnbWlfaGl2ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikNCj4g QW55IHJlYXNvbiB0byBtYWtlIHRoaXMgcHVibGljPw0KDQpJdCBpcyB1c2VkIGluIFBhdGNoIDUu DQoNCkFuZHJleQ0KDQo+DQo+PiAgIHsNCj4+ICAgICAgICAgIGludCBpOw0KPj4gICAgICAgICAg c3RydWN0IGFtZGdwdV9oaXZlX2luZm8gKnRtcDsNCj4+IEBAIC02MSwxMiArNjMsMzMgQEAgc3Rh dGljIHN0cnVjdCBhbWRncHVfaGl2ZV9pbmZvICphbWRncHVfZ2V0X3hnbWlfaGl2ZShzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldikNCj4+ICAgICAgICAgIHJldHVybiB0bXA7DQo+PiAgIH0NCj4+ DQo+PiAraW50IGFtZGdwdV94Z21pX3VwZGF0ZV90b3BvbG9neShzdHJ1Y3QgYW1kZ3B1X2hpdmVf aW5mbyAqaGl2ZSwgc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpDQo+PiArew0KPj4gKyAgICAg ICBpbnQgcmV0ID0gLUVJTlZBTDsNCj4+ICsNCj4+ICsgICAgICAgLyogRWFjaCBwc3AgbmVlZCB0 byBzZXQgdGhlIGxhdGVzdCB0b3BvbG9neSAqLw0KPj4gKyAgICAgICAgICAgICAgIHJldCA9IHBz cF94Z21pX3NldF90b3BvbG9neV9pbmZvKCZhZGV2LT5wc3AsDQo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGl2ZS0+bnVtYmVyX2RldmljZXMsDQo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmhpdmUt PnRvcG9sb2d5X2luZm8pOw0KPj4gKyAgICAgICAgICAgICAgIGlmIChyZXQpDQo+PiArICAgICAg ICAgICAgICAgICAgICAgICBkZXZfZXJyKGFkZXYtPmRldiwNCj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIlhHTUk6IFNldCB0b3BvbG9neSBmYWlsdXJlIG9uIGRldmljZSAlbGx4 LCBoaXZlICVsbHgsIHJldCAlZCIsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGFkZXYtPmdtYy54Z21pLm5vZGVfaWQsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGFkZXYtPmdtYy54Z21pLmhpdmVfaWQsIHJldCk7DQo+PiArICAgICAgICAgICAgICAgZWxz ZQ0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2X2luZm8oYWRldi0+ZGV2LCAiWEdNSTog QWRkIG5vZGUgJWQgdG8gaGl2ZSAweCVsbHguXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYWRldi0+Z21jLnhnbWkucGh5c2ljYWxfbm9kZV9pZCwNCj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFkZXYtPmdtYy54Z21pLmhpdmVfaWQpOw0KPj4gKw0K Pj4gKyAgICAgICByZXR1cm4gcmV0Ow0KPj4gK30NCj4gSW5kZW50YXRpb24gaW4gdGhpcyBmdW5j dGlvbiBsb29rcyB3cm9uZy4NCj4NCj4+ICsNCj4+ICAgaW50IGFtZGdwdV94Z21pX2FkZF9kZXZp Y2Uoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpDQo+PiAgIHsNCj4+IC0gICAgICAgc3RydWN0 IHBzcF94Z21pX3RvcG9sb2d5X2luZm8gKnRtcF90b3BvbG9neTsNCj4+ICsgICAgICAgc3RydWN0 IHBzcF94Z21pX3RvcG9sb2d5X2luZm8gKmhpdmVfdG9wb2xvZ3k7DQo+PiAgICAgICAgICBzdHJ1 Y3QgYW1kZ3B1X2hpdmVfaW5mbyAqaGl2ZTsNCj4+ICAgICAgICAgIHN0cnVjdCBhbWRncHVfeGdt aSAgICAgICplbnRyeTsNCj4+IC0gICAgICAgc3RydWN0IGFtZGdwdV9kZXZpY2UgICAgKnRtcF9h ZGV2Ow0KPj4gKyAgICAgICBzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqdG1wX2FkZXYgPSBOVUxMOw0K Pj4NCj4+ICAgICAgICAgIGludCBjb3VudCA9IDAsIHJldCA9IC1FSU5WQUw7DQo+Pg0KPj4gQEAg LTc2LDIxICs5OSwyMSBAQCBpbnQgYW1kZ3B1X3hnbWlfYWRkX2RldmljZShzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldikNCj4+ICAgICAgICAgIGFkZXYtPmdtYy54Z21pLm5vZGVfaWQgPSBwc3Bf eGdtaV9nZXRfbm9kZV9pZCgmYWRldi0+cHNwKTsNCj4+ICAgICAgICAgIGFkZXYtPmdtYy54Z21p LmhpdmVfaWQgPSBwc3BfeGdtaV9nZXRfaGl2ZV9pZCgmYWRldi0+cHNwKTsNCj4+DQo+PiAtICAg ICAgIHRtcF90b3BvbG9neSA9IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBwc3BfeGdtaV90b3BvbG9n eV9pbmZvKSwgR0ZQX0tFUk5FTCk7DQo+PiAtICAgICAgIGlmICghdG1wX3RvcG9sb2d5KQ0KPj4g LSAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPj4gICAgICAgICAgbXV0ZXhfbG9jaygm eGdtaV9tdXRleCk7DQo+PiAgICAgICAgICBoaXZlID0gYW1kZ3B1X2dldF94Z21pX2hpdmUoYWRl dik7DQo+PiAgICAgICAgICBpZiAoIWhpdmUpDQo+PiAgICAgICAgICAgICAgICAgIGdvdG8gZXhp dDsNCj4+DQo+PiArICAgICAgIGhpdmVfdG9wb2xvZ3kgPSAmaGl2ZS0+dG9wb2xvZ3lfaW5mbzsN Cj4+ICsNCj4+ICAgICAgICAgIGxpc3RfYWRkX3RhaWwoJmFkZXYtPmdtYy54Z21pLmhlYWQsICZo aXZlLT5kZXZpY2VfbGlzdCk7DQo+PiAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGVudHJ5 LCAmaGl2ZS0+ZGV2aWNlX2xpc3QsIGhlYWQpDQo+PiAtICAgICAgICAgICAgICAgdG1wX3RvcG9s b2d5LT5ub2Rlc1tjb3VudCsrXS5ub2RlX2lkID0gZW50cnktPm5vZGVfaWQ7DQo+PiArICAgICAg ICAgICAgICAgaGl2ZV90b3BvbG9neS0+bm9kZXNbY291bnQrK10ubm9kZV9pZCA9IGVudHJ5LT5u b2RlX2lkOw0KPj4gKyAgICAgICBoaXZlLT5udW1iZXJfZGV2aWNlcyA9IGNvdW50Ow0KPj4NCj4+ ICAgICAgICAgIC8qIEVhY2ggcHNwIG5lZWQgdG8gZ2V0IHRoZSBsYXRlc3QgdG9wb2xvZ3kgKi8N Cj4+ICAgICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkodG1wX2FkZXYsICZoaXZlLT5kZXZpY2Vf bGlzdCwgZ21jLnhnbWkuaGVhZCkgew0KPj4gLSAgICAgICAgICAgICAgIHJldCA9IHBzcF94Z21p X2dldF90b3BvbG9neV9pbmZvKCZ0bXBfYWRldi0+cHNwLCBjb3VudCwgdG1wX3RvcG9sb2d5KTsN Cj4+ICsgICAgICAgICAgICAgICByZXQgPSBwc3BfeGdtaV9nZXRfdG9wb2xvZ3lfaW5mbygmdG1w X2FkZXYtPnBzcCwgY291bnQsIGhpdmVfdG9wb2xvZ3kpOw0KPj4gICAgICAgICAgICAgICAgICBp ZiAocmV0KSB7DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2X2Vycih0bXBfYWRldi0+ ZGV2LA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlhHTUk6IEdldCB0b3Bv bG9neSBmYWlsdXJlIG9uIGRldmljZSAlbGx4LCBoaXZlICVsbHgsIHJldCAlZCIsDQo+PiBAQCAt MTAxLDI1ICsxMjQsMTMgQEAgaW50IGFtZGdwdV94Z21pX2FkZF9kZXZpY2Uoc3RydWN0IGFtZGdw dV9kZXZpY2UgKmFkZXYpDQo+PiAgICAgICAgICAgICAgICAgIH0NCj4+ICAgICAgICAgIH0NCj4+ DQo+PiAtICAgICAgIC8qIEVhY2ggcHNwIG5lZWQgdG8gc2V0IHRoZSBsYXRlc3QgdG9wb2xvZ3kg Ki8NCj4+ICAgICAgICAgIGxpc3RfZm9yX2VhY2hfZW50cnkodG1wX2FkZXYsICZoaXZlLT5kZXZp Y2VfbGlzdCwgZ21jLnhnbWkuaGVhZCkgew0KPj4gLSAgICAgICAgICAgICAgIHJldCA9IHBzcF94 Z21pX3NldF90b3BvbG9neV9pbmZvKCZ0bXBfYWRldi0+cHNwLCBjb3VudCwgdG1wX3RvcG9sb2d5 KTsNCj4+IC0gICAgICAgICAgICAgICBpZiAocmV0KSB7DQo+PiAtICAgICAgICAgICAgICAgICAg ICAgICBkZXZfZXJyKHRtcF9hZGV2LT5kZXYsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJYR01JOiBTZXQgdG9wb2xvZ3kgZmFpbHVyZSBvbiBkZXZpY2UgJWxseCwgaGl2ZSAl bGx4LCByZXQgJWQiLA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0bXBfYWRl di0+Z21jLnhnbWkubm9kZV9pZCwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dG1wX2FkZXYtPmdtYy54Z21pLmhpdmVfaWQsIHJldCk7DQo+PiAtICAgICAgICAgICAgICAgICAg ICAgICAvKiBUbyBkbyA6IGNvbnRpbnVlIHdpdGggc29tZSAgbm9kZSBmYWlsZWQgb3IgZGlzYWJs ZSB0aGUgIHdob2xlICBoaXZlICovDQo+PiArICAgICAgICAgICAgICAgcmV0ID0gYW1kZ3B1X3hn bWlfdXBkYXRlX3RvcG9sb2d5KGhpdmUsIHRtcF9hZGV2KTsNCj4+ICsgICAgICAgICAgICAgICBp ZiAocmV0KQ0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gLSAgICAgICAg ICAgICAgIH0NCj4+ICAgICAgICAgIH0NCj4+IC0gICAgICAgaWYgKCFyZXQpDQo+PiAtICAgICAg ICAgICAgICAgZGV2X2luZm8oYWRldi0+ZGV2LCAiWEdNSTogQWRkIG5vZGUgJWQgdG8gaGl2ZSAw eCVsbHguXG4iLA0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgYWRldi0+Z21jLnhnbWkucGh5 c2ljYWxfbm9kZV9pZCwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgIGFkZXYtPmdtYy54Z21p LmhpdmVfaWQpOw0KPj4NCj4+ICAgZXhpdDoNCj4+ICAgICAgICAgIG11dGV4X3VubG9jaygmeGdt aV9tdXRleCk7DQo+PiAtICAgICAgIGtmcmVlKHRtcF90b3BvbG9neSk7DQo+PiAgICAgICAgICBy ZXR1cm4gcmV0Ow0KPj4gICB9DQo+PiAtLQ0KPj4gMi43LjQNCj4+DQo+PiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPj4gYW1kLWdmeCBtYWlsaW5nIGxp c3QNCj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+PiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngNCg0KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==