From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Subject: Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences
 in amdgpu_dm_atomic_commit_tail
Date: Tue, 28 Nov 2017 09:33:22 -0500
Message-ID: <aaa5474d-56f0-de5c-7672-7ad145abc649@amd.com>
References: <20171127145700.GA18395@embeddedor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20171127145700.GA18395@embeddedor.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>, Alex Deucher <alexander.deucher@amd.com>, =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>, David Airlie <airlied@linux.ie>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: amd-gfx.lists.freedesktop.org

UmV2aWV3ZWQtYnk6IEFuZHJleSBHcm9kem92c2t5IDxhbmRyZXkuZ3JvZHpvdnNreUBhbWQuY29t
PgoKVGhhbmtzLAoKQW5kcmV5CgpPbiAxMS8yNy8yMDE3IDA5OjU3IEFNLCBHdXN0YXZvIEEuIFIu
IFNpbHZhIHdyb3RlOgo+IGRtX25ld19jcnRjX3N0YXRlLT5zdHJlYW0gYW5kIGRpc2Nvbm5lY3Rl
ZF9hY3J0YyBhcmUgYmVpbmcgZGVyZWZlcmVuY2VkCj4gYmVmb3JlIHRoZXkgYXJlIG51bGwgY2hl
Y2tlZCwgaGVuY2UgdGhlcmUgaXMgYSBwb3RlbnRpYWwgbnVsbCBwb2ludGVyCj4gZGVyZWZlcmVu
Y2UuCj4KPiBGaXggdGhpcyBieSBudWxsIGNoZWNraW5nIHN1Y2ggcG9pbnRlcnMgYmVmb3JlIHRo
ZXkgYXJlIGRlcmVmZXJlbmNlZC4KPgo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQyMzc0NSAo
IkRlcmVmZXJlbmNlIGJlZm9yZSBudWxsIGNoZWNrIikKPiBBZGRyZXNzZXMtQ292ZXJpdHktSUQ6
IDE0MjM4MzMgKCJEZXJlZmVyZW5jZSBiZWZvcmUgbnVsbCBjaGVjayIpCj4gRml4ZXM6IGU3YjA3
Y2VlZjJhNiAoImRybS9hbWQvZGlzcGxheTogTWVyZ2UgYW1kZ3B1X2RtX3R5cGVzIGFuZCBhbWRn
cHVfZG0iKQo+IEZpeGVzOiA1NGQ3NjU3NTI0NjcgKCJkcm0vYW1kL2Rpc3BsYXk6IFVuaWZ5IGFt
ZGdwdV9kbSBzdGF0ZSB2YXJpYWJsZSBuYW1pbmdzLiIpCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2
byBBLiBSLiBTaWx2YSA8Z2Fyc2lsdmFAZW1iZWRkZWRvci5jb20+Cj4gLS0tCj4gICBkcml2ZXJz
L2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIHwgMTIgKysrKysrKy0t
LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1k
Z3B1X2RtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9k
bS5jCj4gaW5kZXggODg5ZWQyNC4uM2JkZDEzNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+IEBAIC00MTkwLDYgKzQxOTAs
OSBAQCBzdGF0aWMgdm9pZCBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1f
YXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgIAo+ICAgCQlkbV9uZXdfY3J0Y19zdGF0ZSA9IHRvX2Rt
X2NydGNfc3RhdGUobmV3X2NydGNfc3RhdGUpOwo+ICAgCj4gKwkJaWYgKCFkbV9uZXdfY3J0Y19z
dGF0ZS0+c3RyZWFtKQo+ICsJCQljb250aW51ZTsKPiArCj4gICAJCXVwZGF0ZV9zdHJlYW1fc2Nh
bGluZ19zZXR0aW5ncygmZG1fbmV3X2Nvbl9zdGF0ZS0+YmFzZS5jcnRjLT5tb2RlLAo+ICAgCQkJ
CWRtX25ld19jb25fc3RhdGUsIChzdHJ1Y3QgZGNfc3RyZWFtX3N0YXRlICopZG1fbmV3X2NydGNf
c3RhdGUtPnN0cmVhbSk7Cj4gICAKPiBAQCAtNDE5Nyw5ICs0MjAwLDYgQEAgc3RhdGljIHZvaWQg
YW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3Rh
dGUpCj4gICAJCVdBUk5fT04oIXN0YXR1cyk7Cj4gICAJCVdBUk5fT04oIXN0YXR1cy0+cGxhbmVf
Y291bnQpOwo+ICAgCj4gLQkJaWYgKCFkbV9uZXdfY3J0Y19zdGF0ZS0+c3RyZWFtKQo+IC0JCQlj
b250aW51ZTsKPiAtCj4gICAJCS8qVE9ETyBIb3cgaXQgd29ya3Mgd2l0aCBNUE8gPyovCj4gICAJ
CWlmICghZGNfY29tbWl0X3BsYW5lc190b19zdHJlYW0oCj4gICAJCQkJZG0tPmRjLAo+IEBAIC00
MzMyLDkgKzQzMzIsMTEgQEAgdm9pZCBkbV9yZXN0b3JlX2RybV9jb25uZWN0b3Jfc3RhdGUoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldiwKPiAgIAkJcmV0dXJuOwo+ICAgCj4gICAJZGlzY29ubmVjdGVk
X2FjcnRjID0gdG9fYW1kZ3B1X2NydGMoY29ubmVjdG9yLT5lbmNvZGVyLT5jcnRjKTsKPiAtCWFj
cnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0ZShkaXNjb25uZWN0ZWRfYWNydGMtPmJhc2Uuc3Rh
dGUpOwo+ICsJaWYgKCFkaXNjb25uZWN0ZWRfYWNydGMpCj4gKwkJcmV0dXJuOwo+ICAgCj4gLQlp
ZiAoIWRpc2Nvbm5lY3RlZF9hY3J0YyB8fCAhYWNydGNfc3RhdGUtPnN0cmVhbSkKPiArCWFjcnRj
X3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0ZShkaXNjb25uZWN0ZWRfYWNydGMtPmJhc2Uuc3RhdGUp
Owo+ICsJaWYgKCFhY3J0Y19zdGF0ZS0+c3RyZWFtKQo+ICAgCQlyZXR1cm47Cj4gICAKPiAgIAkv
KgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl
dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==