From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two Date: Tue, 11 Sep 2018 13:16:59 +0200 Message-ID: References: <20180909180339.1910-1-christian.koenig@amd.com> <20180909180339.1910-2-christian.koenig@amd.com> <20180911095027.GA5590@hr-amur2> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180911095027.GA5590@hr-amur2> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Huang Rui Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTEuMDkuMjAxOCB1bSAxMTo1MCBzY2hyaWViIEh1YW5nIFJ1aToKPiBPbiBTdW4sIFNlcCAw OSwgMjAxOCBhdCAwODowMzoyOVBNICswMjAwLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBU cnkgdG8gYWxsb2NhdGUgVlJBTSBpbiBwb3dlciBvZiB0d28gc2l6ZXMgYW5kIG9ubHkgZmFsbGJh Y2sgdG8gdnJhbQo+PiBzcGxpdCBzaXplcyBpZiB0aGF0IGZhaWxzLgo+Pgo+PiBTaWduZWQtb2Zm LWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4+IC0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jIHwgNTIgKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNlcnRp b25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3ZyYW1fbWdyLmMKPj4gaW5kZXggOWNmYThhOWFkYTkyLi4zZjlkNWQwMGM5YjMg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21n ci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5j Cj4+IEBAIC0xMjQsNiArMTI0LDI4IEBAIHU2NCBhbWRncHVfdnJhbV9tZ3JfYm9fdmlzaWJsZV9z aXplKHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+PiAgIAlyZXR1cm4gdXNhZ2U7Cj4+ICAgfQo+PiAg IAo+PiArLyoqCj4+ICsgKiBhbWRncHVfdnJhbV9tZ3JfdmlydF9zdGFydCAtIHVwZGF0ZSB2aXJ0 dWFsIHN0YXJ0IGFkZHJlc3MKPj4gKyAqCj4+ICsgKiBAbWVtOiB0dG1fbWVtX3JlZyB0byB1cGRh dGUKPj4gKyAqIEBub2RlOiBqdXN0IGFsbG9jYXRlZCBub2RlCj4+ICsgKgo+PiArICogQ2FsY3Vs YXRlIGEgdmlydHVhbCBCTyBzdGFydCBhZGRyZXNzIHRvIGVhc2lseSBjaGVjayBpZiBldmVyeXRo aW5nIGlzIENQVQo+PiArICogYWNjZXNzaWJsZS4KPj4gKyAqLwo+PiArc3RhdGljIHZvaWQgYW1k Z3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQoc3RydWN0IHR0bV9tZW1fcmVnICptZW0sCj4+ICsJCQkJ ICAgICAgIHN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZSkKPj4gK3sKPj4gKwl1bnNpZ25lZCBsb25n IHN0YXJ0Owo+PiArCj4+ICsJc3RhcnQgPSBub2RlLT5zdGFydCArIG5vZGUtPnNpemU7Cj4+ICsJ aWYgKHN0YXJ0ID4gbWVtLT5udW1fcGFnZXMpCj4+ICsJCXN0YXJ0IC09IG1lbS0+bnVtX3BhZ2Vz Owo+PiArCWVsc2UKPj4gKwkJc3RhcnQgPSAwOwo+PiArCW1lbS0+c3RhcnQgPSBtYXgobWVtLT5z dGFydCwgc3RhcnQpOwo+PiArfQo+PiArCj4gSG93IGFib3V0IG1vdmUgdGhpcyBmdW5jdGlvbiBp bnRvIHR0bSAodHRtX2JvX21hbmFnZXIuYykgdGhlbiBleHBvcnQgdGhlCj4gc3ltYm9sLCBpdCBs b29rcyBtb3JlIGxpa2UgYSB0dG0gaGVscGVyIGZ1bmN0aW9uLgoKTm8sIHRoYXQgaXMgYSBjb21w bGV0ZWx5IGFtZGdwdSBzcGVjaWZpYyBoYWNrLgoKV2UganVzdCBwcm92aWRlIGEgdmlydHVhbCBz dGFydCBhZGRyZXNzIHNvIHRoYXQgdGhlIHBhZ2UgZmF1bHQgZnVuY3Rpb24gCmNhbiBxdWlja2x5 IGNoZWNrIGlmIHRoZSBCTyBpcyBpbiBDUFUgdmlzaWJsZSBWUkFNIG9yIG5vdC4KClJlZ2FyZHMs CkNocmlzdGlhbi4KCj4KPiBUaGFua3MsCj4gUmF5Cj4KPj4gICAvKioKPj4gICAgKiBhbWRncHVf dnJhbV9tZ3JfbmV3IC0gYWxsb2NhdGUgbmV3IHJhbmdlcwo+PiAgICAqCj4+IEBAIC0xNzYsMTAg KzE5OCwyNSBAQCBzdGF0aWMgaW50IGFtZGdwdV92cmFtX21ncl9uZXcoc3RydWN0IHR0bV9tZW1f dHlwZV9tYW5hZ2VyICptYW4sCj4+ICAgCXBhZ2VzX2xlZnQgPSBtZW0tPm51bV9wYWdlczsKPj4g ICAKPj4gICAJc3Bpbl9sb2NrKCZtZ3ItPmxvY2spOwo+PiAtCWZvciAoaSA9IDA7IGkgPCBudW1f bm9kZXM7ICsraSkgewo+PiArCWZvciAoaSA9IDA7IHBhZ2VzX2xlZnQgPj0gcGFnZXNfcGVyX25v ZGU7ICsraSkgewo+PiArCQl1bnNpZ25lZCBsb25nIHBhZ2VzID0gcm91bmRkb3duX3Bvd19vZl90 d28ocGFnZXNfbGVmdCk7Cj4+ICsKPj4gKwkJciA9IGRybV9tbV9pbnNlcnRfbm9kZV9pbl9yYW5n ZShtbSwgJm5vZGVzW2ldLCBwYWdlcywKPj4gKwkJCQkJCXBhZ2VzX3Blcl9ub2RlLCAwLAo+PiAr CQkJCQkJcGxhY2UtPmZwZm4sIGxwZm4sCj4+ICsJCQkJCQltb2RlKTsKPj4gKwkJaWYgKHVubGlr ZWx5KHIpKQo+PiArCQkJYnJlYWs7Cj4+ICsKPj4gKwkJdXNhZ2UgKz0gbm9kZXNbaV0uc2l6ZSA8 PCBQQUdFX1NISUZUOwo+PiArCQl2aXNfdXNhZ2UgKz0gYW1kZ3B1X3ZyYW1fbWdyX3Zpc19zaXpl KGFkZXYsICZub2Rlc1tpXSk7Cj4+ICsJCWFtZGdwdV92cmFtX21ncl92aXJ0X3N0YXJ0KG1lbSwg Jm5vZGVzW2ldKTsKPj4gKwkJcGFnZXNfbGVmdCAtPSBwYWdlczsKPj4gKwl9Cj4+ICsKPj4gKwlm b3IgKDsgcGFnZXNfbGVmdDsgKytpKSB7Cj4+ICAgCQl1bnNpZ25lZCBsb25nIHBhZ2VzID0gbWlu KHBhZ2VzX2xlZnQsIHBhZ2VzX3Blcl9ub2RlKTsKPj4gICAJCXVpbnQzMl90IGFsaWdubWVudCA9 IG1lbS0+cGFnZV9hbGlnbm1lbnQ7Cj4+IC0JCXVuc2lnbmVkIGxvbmcgc3RhcnQ7Cj4+ICAgCj4+ ICAgCQlpZiAocGFnZXMgPT0gcGFnZXNfcGVyX25vZGUpCj4+ICAgCQkJYWxpZ25tZW50ID0gcGFn ZXNfcGVyX25vZGU7Cj4+IEBAIC0xOTMsMTYgKzIzMCw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3Zy YW1fbWdyX25ldyhzdHJ1Y3QgdHRtX21lbV90eXBlX21hbmFnZXIgKm1hbiwKPj4gICAKPj4gICAJ CXVzYWdlICs9IG5vZGVzW2ldLnNpemUgPDwgUEFHRV9TSElGVDsKPj4gICAJCXZpc191c2FnZSAr PSBhbWRncHVfdnJhbV9tZ3JfdmlzX3NpemUoYWRldiwgJm5vZGVzW2ldKTsKPj4gLQo+PiAtCQkv KiBDYWxjdWxhdGUgYSB2aXJ0dWFsIEJPIHN0YXJ0IGFkZHJlc3MgdG8gZWFzaWx5IGNoZWNrIGlm Cj4+IC0JCSAqIGV2ZXJ5dGhpbmcgaXMgQ1BVIGFjY2Vzc2libGUuCj4+IC0JCSAqLwo+PiAtCQlz dGFydCA9IG5vZGVzW2ldLnN0YXJ0ICsgbm9kZXNbaV0uc2l6ZTsKPj4gLQkJaWYgKHN0YXJ0ID4g bWVtLT5udW1fcGFnZXMpCj4+IC0JCQlzdGFydCAtPSBtZW0tPm51bV9wYWdlczsKPj4gLQkJZWxz ZQo+PiAtCQkJc3RhcnQgPSAwOwo+PiAtCQltZW0tPnN0YXJ0ID0gbWF4KG1lbS0+c3RhcnQsIHN0 YXJ0KTsKPj4gKwkJYW1kZ3B1X3ZyYW1fbWdyX3ZpcnRfc3RhcnQobWVtLCAmbm9kZXNbaV0pOwo+ PiAgIAkJcGFnZXNfbGVmdCAtPSBwYWdlczsKPj4gICAJfQo+PiAgIAlzcGluX3VubG9jaygmbWdy LT5sb2NrKTsKPj4gLS0gCj4+IDIuMTQuMQo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiBhbWQtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeAo=