From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FC6FF531C4 for ; Mon, 13 Apr 2026 19:08:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7E3310E518; Mon, 13 Apr 2026 19:08:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QttfARdc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D429C10E075; Mon, 13 Apr 2026 19:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776107318; x=1807643318; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=4CaM7wenZxKtG66qKgsfsJsukc+IvRC3EJ8tB66RfKQ=; b=QttfARdcQv/8J8zr+fH/UMN73lL1dXP4cDGDxNeu9a86JNs5D/uAtalE nCAphRjp8czS6uWHkIP6aE6z+MXDGPRSRujRpohgNNyxK+33sNTWb8Uwz rwdYVb6CJQd3EHsfua9UelhGLy+6B0mzda8fNkV8CcHO6tI3k3DGfh3Rn +QlyTsEfQz+iaYPjXwQq1pK5Z5AVkTgBCwqHX59oRAcWkrti1basnvLZY 080tsLXp1V0uVZWwYjkEBcQyVB0HKA996SsKwa1s6AgqoonJL6NiA2tfK E6T0dYQVzY9+EwzN+INBPsYE7B8Q6UKCpT+9kdjDiGpzBV+c2IegyNsNF g==; X-CSE-ConnectionGUID: UT3Eq5kOSHaEnEITyJsunA== X-CSE-MsgGUID: 91UE6bOvS8OG3GciI2LJzw== X-IronPort-AV: E=McAfee;i="6800,10657,11758"; a="80914443" X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="80914443" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 12:08:37 -0700 X-CSE-ConnectionGUID: LLoqwsUcSQadMQwd692Pcg== X-CSE-MsgGUID: c3AdYV8HRbyVMj2WycmQ6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="225137667" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.97]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 12:08:26 -0700 Date: Mon, 13 Apr 2026 22:08:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v13 12/27] drm/i915/dp: Add YCBCR444 handling for sink formats Message-ID: References: <20260413-color-format-v13-0-ab37d4dfba48@collabora.com> <20260413-color-format-v13-12-ab37d4dfba48@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260413-color-format-v13-12-ab37d4dfba48@collabora.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Apr 13, 2026 at 12:07:26PM +0200, Nicolas Frattaroli wrote: > In anticipation of userspace being able to explicitly select supported > sink formats, add handling of the YCBCR444 sink format. The AUTO path > does not choose this format, but with explicit format selection added to > the driver, it becomes a possibility. > > Check for sink support of YCBCR444 to intel_dp_sink_format_valid. > > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 35b8fb5740aa..47bd3d59ea93 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -1364,6 +1364,11 @@ intel_dp_sink_format_valid(struct intel_connector *connector, > > return MODE_OK; > case INTEL_OUTPUT_FORMAT_RGB: > + return MODE_OK; > + case INTEL_OUTPUT_FORMAT_YCBCR444: > + if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444))) > + return MODE_BAD; The DP situation is a lot more more fuzzy than the HDMI situation due to the PCON stuff. So I'm not quite sure what we should do here. At the very least I think we want the equivalent of intel_dp_can_ycbcr420() for 444, and the same intel_dp_has_hdmi_sink() check that we have for 420. > + > return MODE_OK; > default: > MISSING_CASE(sink_format); > > -- > 2.53.0 -- Ville Syrjälä Intel