AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luben Tuikov <luben.tuikov@amd.com>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu/powerplay: Only apply optimized mclk dpm policy on polaris
Date: Wed, 28 Oct 2020 13:13:26 -0400	[thread overview]
Message-ID: <ad4aefe8-bf7f-73b2-3bc7-65c1a167b32e@amd.com> (raw)
In-Reply-To: <20201028150805.2400403-1-alexander.deucher@amd.com>

Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>

I assume that the default ("else") case is what is wanted
by this patch and has been vetted-i.e. it what fixes it.

Regards,
Luben

On 2020-10-28 11:08, Alex Deucher wrote:
> Leads to improper dpm on older parts.
> 
> Bug: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1353&amp;data=04%7C01%7Cluben.tuikov%40amd.com%7C154766ca87eb40cce45508d87b534dba%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637394945025356066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=RB%2FDlyoqyasJWWkmB6dL0jxzVM9Auc223YNkEmpIj54%3D&amp;reserved=0
> Fixes: 8d89b96fe797 ("drm/amd/powerplay: optimize the mclk dpm policy settings")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  .../drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c   | 30 +++++++++++--------
>  1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> index 49db61a89505..d642dc95e9ea 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1713,18 +1713,24 @@ static void smu7_init_dpm_defaults(struct pp_hwmgr *hwmgr)
>  	data->current_profile_setting.sclk_down_hyst = 100;
>  	data->current_profile_setting.sclk_activity = SMU7_SCLK_TARGETACTIVITY_DFLT;
>  	data->current_profile_setting.bupdate_mclk = 1;
> -	if (adev->gmc.vram_width == 256) {
> -		data->current_profile_setting.mclk_up_hyst = 10;
> -		data->current_profile_setting.mclk_down_hyst = 60;
> -		data->current_profile_setting.mclk_activity = 25;
> -	} else if (adev->gmc.vram_width == 128) {
> -		data->current_profile_setting.mclk_up_hyst = 5;
> -		data->current_profile_setting.mclk_down_hyst = 16;
> -		data->current_profile_setting.mclk_activity = 20;
> -	} else if (adev->gmc.vram_width == 64) {
> -		data->current_profile_setting.mclk_up_hyst = 3;
> -		data->current_profile_setting.mclk_down_hyst = 16;
> -		data->current_profile_setting.mclk_activity = 20;
> +	if (hwmgr->chip_id >= CHIP_POLARIS10) {
> +		if (adev->gmc.vram_width == 256) {
> +			data->current_profile_setting.mclk_up_hyst = 10;
> +			data->current_profile_setting.mclk_down_hyst = 60;
> +			data->current_profile_setting.mclk_activity = 25;
> +		} else if (adev->gmc.vram_width == 128) {
> +			data->current_profile_setting.mclk_up_hyst = 5;
> +			data->current_profile_setting.mclk_down_hyst = 16;
> +			data->current_profile_setting.mclk_activity = 20;
> +		} else if (adev->gmc.vram_width == 64) {
> +			data->current_profile_setting.mclk_up_hyst = 3;
> +			data->current_profile_setting.mclk_down_hyst = 16;
> +			data->current_profile_setting.mclk_activity = 20;
> +		}
> +	} else {
> +		data->current_profile_setting.mclk_up_hyst = 0;
> +		data->current_profile_setting.mclk_down_hyst = 100;
> +		data->current_profile_setting.mclk_activity = SMU7_MCLK_TARGETACTIVITY_DFLT;
>  	}
>  	hwmgr->workload_mask = 1 << hwmgr->workload_prority[PP_SMC_POWER_PROFILE_FULLSCREEN3D];
>  	hwmgr->power_profile_mode = PP_SMC_POWER_PROFILE_FULLSCREEN3D;
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-10-28 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 15:08 [PATCH] drm/amdgpu/powerplay: Only apply optimized mclk dpm policy on polaris Alex Deucher
2020-10-28 17:13 ` Luben Tuikov [this message]
2020-10-30  3:59 ` Quan, Evan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad4aefe8-bf7f-73b2-3bc7-65c1a167b32e@amd.com \
    --to=luben.tuikov@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox