Re: [PATCH 00/18] drm/amd/display: Enable writeback for amdgpu

[Alex Hung <alex.hung@amd.com>]

On 2023-09-05 08:20, Harry Wentland wrote:
> Can we boot the system if we only apply patces 1-3? If not, we might
> want to move patch 2 to the end of the series.

The system boots with the first three patches namely

drm/amd/display: Initialize writeback connector
drm/amd/display: Create one virtual connector in DC
drm/amd/display: Skip entire amdgpu_dm build if !CONFIG_DRM_AMD_DC


> 
> A bunch of these patches are from me. Would be good if they can get a
> Reviewed-by from you (or someone else, other than me) before merging.

"Reviewed-by" are sent to Harry's patches.

> 
> Series is
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> 
> Harry
> 
> On 2023-08-16 17:26, Alex Hung wrote:
>> This patchset adds drm_writeback connector supports and enables display
>> writeback block (DWB) in AMD hardware.
>>
>> The function can be tested by IGT's kms_writeback test which also
>> requires a number of patches to enable 10bit (DRM_FORMAT_XRGB2101010).
>> Patches are available @ https://patchwork.freedesktop.org/series/122536/
>>
>> Alex Hung (10):
>>    drm/amd/display: Initialize writeback connector
>>    drm/amd/display: Hande writeback request from userspace
>>    drm/amd/display: Add writeback enable/disable in dc
>>    drm/amd/display: Fix writeback_info never got updated
>>    drm/amd/display: Validate hw_points_num before using it
>>    drm/amd/display: Fix writeback_info is not removed
>>    drm/amd/display: Add writeback enable field (wb_enabled)
>>    drm/amd/display: Setup for mmhubbub3_warmup_mcif with big buffer
>>    drm/amd/display: Add new set_fc_enable to struct dwbc_funcs
>>    drm/amd/display: Disable DWB frame capture to emulate oneshot
>>
>> Harry Wentland (8):
>>    drm/amd/display: Skip entire amdgpu_dm build if !CONFIG_DRM_AMD_DC
>>    drm/amd/display: Create one virtual connector in DC
>>    drm/amd/display: Skip writeback connector when we get
>>      amdgpu_dm_connector
>>    drm/amd/display: Return drm_connector from
>>      find_first_crtc_matching_connector
>>    drm/amd/display: Use drm_connector in create_stream_for_sink
>>    drm/amd/display: Use drm_connector in create_validate_stream_for_sink
>>    drm/amd/display: Create amdgpu_dm_wb_connector
>>    drm/amd/display: Create fake sink and stream for writeback connector
>>
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |   4 +
>>   .../gpu/drm/amd/display/amdgpu_dm/Makefile    |  14 +-
>>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 375 ++++++++++++++++--
>>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  12 +-
>>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c |   3 +
>>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c |  22 +-
>>   .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |   8 +-
>>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c  | 215 ++++++++++
>>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.h  |  36 ++
>>   .../gpu/drm/amd/display/dc/core/dc_stream.c   |  80 +++-
>>   drivers/gpu/drm/amd/display/dc/dc_stream.h    |   4 +
>>   .../gpu/drm/amd/display/dc/dcn30/dcn30_dwb.c  |  23 ++
>>   .../gpu/drm/amd/display/dc/dcn30/dcn30_dwb.h  |   2 +
>>   .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c   |   3 +
>>   .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |   4 +
>>   .../drm/amd/display/dc/dcn31/dcn31_hwseq.c    |   3 +-
>>   drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h   |   4 +
>>   17 files changed, 742 insertions(+), 70 deletions(-)
>>   create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c
>>   create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.h
>>
>