* [PATCH] drm/amdgpu: Refine gmc9 VM fault print.
@ 2018-08-27 18:22 Andrey Grodzovsky
[not found] ` <1535394165-12564-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Andrey Grodzovsky @ 2018-08-27 18:22 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Andrey Grodzovsky, Marek.Olsak-5C7GfCeVMHo
The fault reports the page number where the fault happend and not
the exact faulty address. Update the print message to reflect that.
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 6763570..d44c5e2 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -270,7 +270,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
entry->src_id, entry->ring_id, entry->vmid,
entry->pasid, task_info.process_name, task_info.tgid,
task_info.task_name, task_info.pid);
- dev_err(adev->dev, " at address 0x%016llx from %d\n",
+ dev_err(adev->dev, " in page starting at address 0x%016llx from %d\n",
addr, entry->client_id);
if (!amdgpu_sriov_vf(adev))
dev_err(adev->dev,
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Refine gmc9 VM fault print.
[not found] ` <1535394165-12564-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
@ 2018-08-27 18:55 ` Alex Deucher
[not found] ` <CADnq5_MdoeSQLrQdBMZDE8gc6bTzUg9Rgd-+Ad__6KoMq2ojtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2018-08-27 18:55 UTC (permalink / raw)
To: Andrey Grodzovsky; +Cc: Marek Olšák, amd-gfx list
On Mon, Aug 27, 2018 at 2:23 PM Andrey Grodzovsky
<andrey.grodzovsky@amd.com> wrote:
>
> The fault reports the page number where the fault happend and not
> the exact faulty address. Update the print message to reflect that.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 6763570..d44c5e2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -270,7 +270,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
> entry->src_id, entry->ring_id, entry->vmid,
> entry->pasid, task_info.process_name, task_info.tgid,
> task_info.task_name, task_info.pid);
> - dev_err(adev->dev, " at address 0x%016llx from %d\n",
> + dev_err(adev->dev, " in page starting at address 0x%016llx from %d\n",
> addr, entry->client_id);
> if (!amdgpu_sriov_vf(adev))
> dev_err(adev->dev,
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Refine gmc9 VM fault print.
[not found] ` <CADnq5_MdoeSQLrQdBMZDE8gc6bTzUg9Rgd-+Ad__6KoMq2ojtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-08-27 19:25 ` Marek Olšák
[not found] ` <CAAxE2A4w3i4PPiQxxM7ZL1ENd-e3jt_dM9W9NKqwe16+B3OBeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Marek Olšák @ 2018-08-27 19:25 UTC (permalink / raw)
To: Alex Deucher; +Cc: Andrey Grodzovsky, Marek Olšák, amd-gfx list
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Marek
On Mon, Aug 27, 2018 at 2:55 PM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Mon, Aug 27, 2018 at 2:23 PM Andrey Grodzovsky
> <andrey.grodzovsky@amd.com> wrote:
>>
>> The fault reports the page number where the fault happend and not
>> the exact faulty address. Update the print message to reflect that.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> index 6763570..d44c5e2 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> @@ -270,7 +270,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
>> entry->src_id, entry->ring_id, entry->vmid,
>> entry->pasid, task_info.process_name, task_info.tgid,
>> task_info.task_name, task_info.pid);
>> - dev_err(adev->dev, " at address 0x%016llx from %d\n",
>> + dev_err(adev->dev, " in page starting at address 0x%016llx from %d\n",
>> addr, entry->client_id);
>> if (!amdgpu_sriov_vf(adev))
>> dev_err(adev->dev,
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Refine gmc9 VM fault print.
[not found] ` <CAAxE2A4w3i4PPiQxxM7ZL1ENd-e3jt_dM9W9NKqwe16+B3OBeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-08-28 11:18 ` Christian König
0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2018-08-28 11:18 UTC (permalink / raw)
To: Marek Olšák, Alex Deucher
Cc: Andrey Grodzovsky, Marek Olšák, amd-gfx list
Reviewed-by: Christian König <christian.koenig@amd.com>
Am 27.08.2018 um 21:25 schrieb Marek Olšák:
> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
>
> Marek
>
> On Mon, Aug 27, 2018 at 2:55 PM, Alex Deucher <alexdeucher@gmail.com> wrote:
>> On Mon, Aug 27, 2018 at 2:23 PM Andrey Grodzovsky
>> <andrey.grodzovsky@amd.com> wrote:
>>> The fault reports the page number where the fault happend and not
>>> the exact faulty address. Update the print message to reflect that.
>>>
>>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> index 6763570..d44c5e2 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>>> @@ -270,7 +270,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
>>> entry->src_id, entry->ring_id, entry->vmid,
>>> entry->pasid, task_info.process_name, task_info.tgid,
>>> task_info.task_name, task_info.pid);
>>> - dev_err(adev->dev, " at address 0x%016llx from %d\n",
>>> + dev_err(adev->dev, " in page starting at address 0x%016llx from %d\n",
>>> addr, entry->client_id);
>>> if (!amdgpu_sriov_vf(adev))
>>> dev_err(adev->dev,
>>> --
>>> 2.7.4
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-28 11:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-27 18:22 [PATCH] drm/amdgpu: Refine gmc9 VM fault print Andrey Grodzovsky
[not found] ` <1535394165-12564-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
2018-08-27 18:55 ` Alex Deucher
[not found] ` <CADnq5_MdoeSQLrQdBMZDE8gc6bTzUg9Rgd-+Ad__6KoMq2ojtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-27 19:25 ` Marek Olšák
[not found] ` <CAAxE2A4w3i4PPiQxxM7ZL1ENd-e3jt_dM9W9NKqwe16+B3OBeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-28 11:18 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).