From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BD97F99357 for ; Thu, 23 Apr 2026 08:52:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1379310EFF4; Thu, 23 Apr 2026 08:52:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PGx1MrPg"; dkim-atps=neutral Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id A84CB10E11A for ; Thu, 23 Apr 2026 07:09:27 +0000 (UTC) Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-65492d097acso207379d50.3 for ; Thu, 23 Apr 2026 00:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776928167; x=1777532967; darn=lists.freedesktop.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=+G5xDeM2eEmKTciid+jelsafennvBZ1THzAZAjB59Gk=; b=PGx1MrPgdVRDIecpo16TdPSHyFVo/7Zobq2bipHeGPIeweC26NfHoGKDt5twpviXrY h2TiUhca/z8Bm6CcUALCDXznxdYGfcCveY89/4P0pmu9rb3Y1y7FQETgzH+LKYc2pKUN okvdwEcAAMNLOqGzFHuj5ygH3XJGmekpBl3xK/+YM2D7ZVCXr4hNKsZFk+LCrjFVN993 +8MR+kJdiuamWTTzSW8k6UJJqlirnYUTzRplo0uJut9STpxujL75Ua7t9A8fVOoR15Sv XyoiyhrcOsh5Q1u52Pk6HRD+Pv5fjM8rkB4jK1aW9Sr4kGHtC6baliwM6qo2y4A9lM/6 wlTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776928167; x=1777532967; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+G5xDeM2eEmKTciid+jelsafennvBZ1THzAZAjB59Gk=; b=tGsKNs8EsrT+ve/l9Evd6/biGmwuIjIi/wy4KkfN66BVpfs3zMmXYIuhqZjX8uiG2a c//fXo1n+yw8gant2zKIRHHgSVfMqLbPhQ/yAL4MhKaxdHn9tSo3Z0yI4YUTHEQpBWnK 2Op5q8acj+2ty0E3ZTJywQquKjk69VzL5WqMrszFFk7niwCEsQbDozWxsJNGVPh5qXRh qPKWnpcUEfdtmGp8TDBBFtPfkLSdsvKCKywGGLM1h/6+jB3Qkdgtf9yxAwviyALQeoPq M1coensBlL6boigleZMDmrDtrTvtNOD3h24E+o8/jAZHjqdiP5xSicNoKwIT2zpqCT5L OZPA== X-Forwarded-Encrypted: i=1; AFNElJ8JTwjW70pYntoP7QEMXGEKfkxOCzlO7oVas/FxFgXqEO9xVjTGZ/yipDsBGVl/orufyBci+l6/@lists.freedesktop.org X-Gm-Message-State: AOJu0YzThLJfwelDacIetIYP8oiiVeYuTGfY2xpXGNdIDpuS/ByjFJre MEy4cC/OcomNLUKFEi5t+aZvIB4PHIfAQv5fLubS7QjEvGmuVgzdvGEq X-Gm-Gg: AeBDieumb5w0FnJ2BcKDUXgsD8ueiEsqGqHIKbGJJkzR8E1SFm6ktuJd0M09Rf3hlD/ Pv0sk64gFg+IPmh6NXYTqxzAG4/NK9nhwllVBAMLrWtK501dkPdnGay95KnQyClRwPm4ARMZOGV H8K3bMGm6Apyyc64COpV9n90iKk9SkknVEo2F7K3YfFqOad6ExhtFfTwSvEGjDoQ3t2dS/LTXr6 JhSI5bE2r/Yoo4Hi64asTTCPghEl+GDL3F9LEdQvdlXavqta0IKXucZpQRcNGFP+sXitTUAzlcF kjzHHZQa6nuGh2sW/wf29U5LqLO0zo3KjjbcavukdPviY/he5BwsK48zBjoQyvEZmbITSFaZUSq bwMb84CTwBS/aqym4OSt2Cd8x9xfaf+SBFmktsEAnATaWRn6GmYpwVvXI7Nymfmh+1gN8tIMLlm mlMjLlZx9/Q3U4HJsugCr8act0vgtr X-Received: by 2002:a05:690e:4850:b0:649:e871:3eb7 with SMTP id 956f58d0204a3-65310b03ee5mr15847316d50.57.1776928166757; Thu, 23 Apr 2026 00:09:26 -0700 (PDT) Received: from localhost ([172.216.252.33]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65314e328d6sm8799738d50.11.2026.04.23.00.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 00:09:26 -0700 (PDT) Date: Thu, 23 Apr 2026 10:09:20 +0300 From: Dan Carpenter To: Harry Wentland Cc: Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Chenyu Chen , Ray Wu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/amd/display: Clean up allocation in initialize_backlight_caps() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Mailman-Approved-At: Thu, 23 Apr 2026 08:52:16 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Just a small cleanup: 1) Remove unnecessary initialization. 2) Use the new kzalloc_obj() macro. 3) Reformat the NULL check to make checkpatch happy. 4) Remove the unnecessary NULL check before kfree() since the pointer is not NULL and anyway kfree() accepts NULL pointers. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/display/modules/power/power.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c index 6c73fecf57d5..68b5b3b967be 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power.c +++ b/drivers/gpu/drm/amd/display/modules/power/power.c @@ -470,7 +470,7 @@ static bool validate_ext_backlight_caps( static void initialize_backlight_caps(struct core_power *core_power, unsigned int inst) { unsigned int i; - struct dm_acpi_atif_backlight_caps *ext_backlight_caps = NULL; + struct dm_acpi_atif_backlight_caps *ext_backlight_caps; bool custom_curve_present = false; unsigned int num_levels = 0; struct dc *dc = NULL; @@ -486,11 +486,8 @@ static void initialize_backlight_caps(struct core_power *core_power, unsigned in /* Allocate memory for ATIF output * (do not want to use 256 bytes on the stack) */ - ext_backlight_caps = (struct dm_acpi_atif_backlight_caps *) - (kzalloc(sizeof(struct dm_acpi_atif_backlight_caps), - GFP_KERNEL)); - - if (ext_backlight_caps == NULL) + ext_backlight_caps = kzalloc_obj(*ext_backlight_caps); + if (!ext_backlight_caps) return; /* Retrieve ACPI extended brightness caps */ @@ -611,8 +608,7 @@ static void initialize_backlight_caps(struct core_power *core_power, unsigned in } } - if (ext_backlight_caps != NULL) - kfree(ext_backlight_caps); + kfree(ext_backlight_caps); /* Successfully initialized */ core_power->bl_prop[inst].backlight_caps_valid = true; -- 2.53.0