From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E9A606A335 for ; Thu, 29 Oct 2026 13:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=ilvokhin.com header.i=@ilvokhin.com header.a=rsa-sha256 header.s=mail header.b=WUo05cr+ Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B63171122A4; Thu, 29 Oct 2026 13:00:50 +0000 (UTC) Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) by gabe.freedesktop.org (Postfix) with ESMTPS id B87A7112246; Thu, 29 Oct 2026 12:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1793275747; bh=RocjA1LFJ8nCgW+tO2y+Fh4wXXWjfdPFo024IhF5Wq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WUo05cr+foO7RPlP7534YSiBgZ8CQPkwQY40XhGkYZY6+6/4j3XkS/IFDfGv+Pkoh y9zJIn2BFoMmtdWooRjNBcjjjJtArbTwyJLsxt66JLoWE/gVCnnA7sNVi3UolL8xve VDmnu4pCCOxy8JC/MQlwNqsBS6P1OvE3N85vIIf8= Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 2E446101220; Thu, 29 Oct 2026 12:09:07 +0000 (UTC) Date: Thu, 29 Oct 2026 12:09:03 +0000 From: Dmitry Ilvokhin To: Randy Dunlap Cc: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Lee Jones , Pavel Machek , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Kees Cook , Andy Shevchenko , Matthew Wilcox , Andrew Morton , Andy Whitcroft , Joe Perches , Jonathan Corbet , Shuah Khan , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Miguel Ojeda Subject: Re: [PATCH 00/10] treewide: switch to __nonnull_args() macro Message-ID: References: X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 29 Oct 2026 13:00:50 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "amd-gfx" X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Oct 28, 2026 at 01:44:59PM -0700, Randy Dunlap wrote: > > > On 10/28/26 1:19 AM, Dmitry Ilvokhin wrote: > > Commit 22302af28d3f ("cleanup: Annotate guard constructors with > > nonnull") added the __nonnull_args() macro to wrap the raw compiler > > attribute, keeping the attribute's quirks in one place rather than > > open-coded at every call site. > > > > This series replaces the remaining open-coded __attribute__((nonnull)) > > users with __nonnull_args() to standardize nonnull attribute usage > > across the tree. > > > > Each patch can be applied separately by the respective maintainers. The > > only dependency is kernel-doc: the string and lib/list_sort patches need > > patch 1 ("docs: xforms_lists: support __nonnull_args()") in the same > > release, otherwise strends() and list_sort() drop out of the generated > > documentation. > > > > Latest Sparse release could not properly parse __nonnull_args() without > > arguments. Fix was proposed [1] and merged, but until updated version of > > Sparse will reach wide masses it might trip on __nonnull_args() without > > arguments. > > > > There are few more instances of __attribute__((nonnull)) usages left in > > the tools subdirectory, they are perf related copied files and can > > (should?) be updated separately after this patchset lands. > > > > Build-tested allmodconfig with GCC 11.5.0 and clang 22.1.8. > > What ARCH(es)? Fair point, I should have mentioned that I run this on x86_64 and aarch64. > > Did you mean to use such an "old" version of GCC? There is no grand plan behind that to be honest, I used it, because this is a version of GCC that comes with CentOS Stream 9 on the box I tested the change. To be on the safe side, I checked patchset still builds on GCC 16.2.1 on allmodconfig x86_64.