From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05215606A31D for ; Fri, 30 Oct 2026 09:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=ilvokhin.com header.i=@ilvokhin.com header.a=rsa-sha256 header.s=mail header.b=vALBjl5t Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EF1B1126B3; Fri, 30 Oct 2026 09:13:39 +0000 (UTC) Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) by gabe.freedesktop.org (Postfix) with ESMTPS id A99D310E582; Thu, 29 Oct 2026 13:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1793279528; bh=4cruogtXfNCOrJCvoodcyrTOzahFlsASVgaus3wd4bs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=vALBjl5tg/HLHwAe5LnWN0I+FZe/ilBHT2lZAbbXATHMbz98KZlNi97W3j84M5MIm EgXRxUJW0KRszvy4pqxbaKoourAWAFiwAZJY+Ct2Jbwg3k04WPlzyGUItH+c8SnyYr SQLCcctV6enovEyNRJB4QlV0k1lXcskW58pkHYoY= Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id D6809101233; Thu, 29 Oct 2026 13:12:07 +0000 (UTC) Date: Thu, 29 Oct 2026 13:12:06 +0000 From: Dmitry Ilvokhin To: Miguel Ojeda Cc: Thomas Zimmermann , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Lee Jones , Pavel Machek , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Maarten Lankhorst , Maxime Ripard , Kees Cook , Andy Shevchenko , Matthew Wilcox , Andrew Morton , Andy Whitcroft , Joe Perches , Jonathan Corbet , Shuah Khan , Randy Dunlap , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 07/10] drm/gem: Switch to __nonnull_args() macro Message-ID: References: <5bfdc1491d297b5e98cf42322c790f06481c28c7.1793027261.git.d@ilvokhin.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Approved-At: Fri, 30 Oct 2026 09:13:37 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "amd-gfx" X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Oct 29, 2026 at 02:00:28PM +0100, Miguel Ojeda wrote: > On Thu, Oct 29, 2026 at 8:32 AM Thomas Zimmermann wrote: > > > > Should gem.h now include ? > > No, it should be included for you (unless you are doing something > custom with the compiler flags etc.). Just to add a bit more colour to Miguel's reply. I believe idea behind include/linux/compiler_attributes.h is to make attribute wrappers as simple and transparent to use as native compiler attributes. In particular, this means they should be available in every kernel compilation unit without any additional effort. For this reason, all the nessesary plumbing is handled at the build machinery level (see scripts/Makefile.lib:171), where '-include' compiler flag is used to pull in include/linux/compiler_types.h, which in turn pulls include/linux/compiler_attributes.h.