From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: amd-gfx@lists.freedesktop.org, Wenjing Liu <wenjing.liu@amd.com>,
Alex Hung <alex.hung@amd.com>, Roman Li <roman.li@amd.com>,
Tom Chung <chiahsuan.chung@amd.com>
Subject: Re: [PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update()
Date: Mon, 18 Mar 2024 07:05:18 -0600 [thread overview]
Message-ID: <b094279c-e40a-4827-87e6-39acb9350014@amd.com> (raw)
In-Reply-To: <20240318125027.2238100-1-srinivasan.shanmugam@amd.com>
On 3/18/24 6:50 AM, Srinivasan Shanmugam wrote:
> Adds descriptions for 'new_context', 'srf_updates', and 'surface_count',
> and removes the excess description for 'context'.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'new_context' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'srf_updates' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or member 'surface_count' not described in 'commit_minimal_transition_state_in_dc_update'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Excess function parameter 'context' description in 'commit_minimal_transition_state_in_dc_update'
>
> Cc: Wenjing Liu <wenjing.liu@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 119eee2c97d4..08ca97bb4160 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -4391,8 +4391,10 @@ static bool commit_minimal_transition_based_on_current_context(struct dc *dc,
> * on current or new context
> *
> * @dc: DC structure, used to get the current state
> - * @context: New context
> + * @new_context: New context
> * @stream: Stream getting the update for the flip
> + * @srf_updates: Surface updates
> + * @surface_count: Number of surfaces
> *
> * The function takes in current state and new state and determine a minimal
> * transition state as the intermediate step which could make the transition
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
prev parent reply other threads:[~2024-03-18 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 12:50 [PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update() Srinivasan Shanmugam
2024-03-18 13:05 ` Rodrigo Siqueira Jordao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b094279c-e40a-4827-87e6-39acb9350014@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=alex.hung@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=roman.li@amd.com \
--cc=srinivasan.shanmugam@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox