From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Felix Kuehling <felix.kuehling@amd.com>,
Alex Deucher <alexdeucher@gmail.com>,
amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: default noretry=0 for navi1x and newer (v2)
Date: Mon, 30 Nov 2020 21:30:34 +0100 [thread overview]
Message-ID: <b0d69a06-e998-920f-986b-96d967105d07@gmail.com> (raw)
In-Reply-To: <9075d858-0008-2583-974d-08cc4ae31fed@amd.com>
Am 30.11.20 um 20:52 schrieb Felix Kuehling:
> Am 2020-11-30 um 2:25 p.m. schrieb Alex Deucher:
>> There are no performance advantages to setting it to 1 and
>> it causes stability issues in some cases.
> See my later email on the other thread. There was another consideration
> besides performance. It had to do with retry fault handling, which
> depended on being able to reroute the interrupts to the IH1 ring, which
> the security policy doesn't allow on many boards. With Christian's
> recent changes to reroute retry interrupts to a software ring, this
> dependency is gone and it should now be safe to enable retry on most boards.
It's not the best solution from a performance point of view, but it
indeed seems to get things working as expected.
>
>
>> v2: simplify the code
>>
>> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
>
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
>> index fede84509dbc..b07c47cacd28 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
>> @@ -422,11 +422,6 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
>>
>> switch (adev->asic_type) {
>> case CHIP_VEGA20:
>> - case CHIP_NAVI10:
>> - case CHIP_NAVI14:
>> - case CHIP_SIENNA_CICHLID:
>> - case CHIP_NAVY_FLOUNDER:
>> - case CHIP_DIMGREY_CAVEFISH:
>> /*
>> * noretry = 0 will cause kfd page fault tests fail
>> * for some ASICs, so set default to 1 for these ASICs.
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-11-30 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 19:25 [PATCH] drm/amdgpu: default noretry=0 for navi1x and newer (v2) Alex Deucher
2020-11-30 19:52 ` Felix Kuehling
2020-11-30 20:30 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0d69a06-e998-920f-986b-96d967105d07@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).