AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Leo Ma <hanghong.ma@amd.com>,
	Mikita Lipski <mikita.lipski@amd.com>,
	Aric Cyr <aric.cyr@amd.com>
Subject: Re: [PATCH 1/2] drm/amdgpu/display: fix warning about indentation
Date: Tue, 14 Sep 2021 11:08:33 -0400	[thread overview]
Message-ID: <b25690b4-fe4b-7154-1b29-0b5b0a6f9ba3@amd.com> (raw)
In-Reply-To: <20210914145912.1569716-1-alexander.deucher@amd.com>

On 2021-09-14 10:59, Alex Deucher wrote:
> Looks like this code block was missing parens.
> 
> Fixes: c0ffd1945147 ("drm/amd/display: Add DPCD writes at key points")
> Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
> Cc: Mikita Lipski <mikita.lipski@amd.com>
> Cc: Aric Cyr <aric.cyr@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index ac4896ff912c..6663cfc4eb71 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -2370,12 +2370,11 @@ bool perform_link_training_with_retries(
>  	/* We need to do this before the link training to ensure the idle pattern in SST
>  	 * mode will be sent right after the link training
>  	 */
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
> -	if (dp_get_link_encoding_format(&current_setting) == DP_8b_10b_ENCODING)
> -#endif
> +	if (dp_get_link_encoding_format(&current_setting) == DP_8b_10b_ENCODING) {
>  		link_enc->funcs->connect_dig_be_to_fe(link_enc,
>  							pipe_ctx->stream_res.stream_enc->id, true);
>  		dp_source_sequence_trace(link, DPCD_SOURCE_SEQ_AFTER_CONNECT_DIG_FE_BE);
> +	}
>  
>  	for (j = 0; j < attempts; ++j) {
>  
> 


      parent reply	other threads:[~2021-09-14 15:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 14:59 [PATCH 1/2] drm/amdgpu/display: fix warning about indentation Alex Deucher
2021-09-14 14:59 ` [PATCH 2/2] drm/amdgpu/display: add a proper license to dc_link_dp.c Alex Deucher
2021-09-14 15:07   ` Harry Wentland
2021-09-14 15:08 ` Harry Wentland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b25690b4-fe4b-7154-1b29-0b5b0a6f9ba3@amd.com \
    --to=harry.wentland@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aric.cyr@amd.com \
    --cc=hanghong.ma@amd.com \
    --cc=mikita.lipski@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox