From: Danilo Krummrich <dakr@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
kherbst@redhat.com, lyude@redhat.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()
Date: Mon, 12 Aug 2024 20:55:14 +0200 [thread overview]
Message-ID: <b29016ab-b75d-4822-968b-ea54187f76cf@kernel.org> (raw)
In-Reply-To: <b29c367f-1a46-4ddb-a8c2-a508f2b54b0d@suse.de>
On 8/12/24 2:34 PM, Thomas Zimmermann wrote:
> Hi
>
> Am 12.08.24 um 14:17 schrieb Danilo Krummrich:
>> On 8/12/24 10:28 AM, Thomas Zimmermann wrote:
>>> Replace the call to drm_fb_helper_output_poll_changed() with a call
>>> to drm_client_dev_hotplug(). It is equivalent in functionality, but
>>> uses the DRM client infrastructure.
>>>
>>> v2:
>>> - fix commit description
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Acked-by: Danilo Krummrich <dakr@kernel.org>
>
> Thanks for the acks. Can I merge the nouveau patches through drm-misc-next?
Sure.
>
> Best regards
> Thomas
>
>>
>>> ---
>>> drivers/gpu/drm/nouveau/nouveau_vga.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
>>> index ee637f1fe03d..ab4e11dc0b8a 100644
>>> --- a/drivers/gpu/drm/nouveau/nouveau_vga.c
>>> +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
>>> @@ -58,8 +58,9 @@ static void
>>> nouveau_switcheroo_reprobe(struct pci_dev *pdev)
>>> {
>>> struct nouveau_drm *drm = pci_get_drvdata(pdev);
>>> + struct drm_device *dev = drm->dev;
>>> - drm_fb_helper_output_poll_changed(drm->dev);
>>> + drm_client_dev_hotplug(dev);
>>> }
>>> static bool
>
next prev parent reply other threads:[~2024-08-12 18:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 8:28 [PATCH v2 0/9] drm/{amdgpu,nouveau}: Remove old fbdev hooks Thomas Zimmermann
2024-08-12 8:28 ` [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose() Thomas Zimmermann
2024-08-12 9:23 ` Daniel Vetter
2024-08-12 10:18 ` Daniel Vetter
2024-08-12 10:41 ` Thomas Zimmermann
2024-08-12 14:40 ` Daniel Vetter
2024-08-12 18:47 ` Alex Deucher
2024-08-12 19:05 ` Alex Deucher
[not found] ` <CABwHSOsWh_Mbf9dkNqznwZwJbKZqndb79OGCA1xFqc1xzMFXCw@mail.gmail.com>
2024-08-20 20:56 ` Getting off this list Lyude Paul
2024-08-12 8:28 ` [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose Thomas Zimmermann
2024-08-12 9:24 ` Daniel Vetter
2024-08-12 19:05 ` Alex Deucher
2024-08-12 19:07 ` Alex Deucher
2024-08-12 8:28 ` [PATCH v2 3/9] drm/nouveau: " Thomas Zimmermann
2024-08-12 9:24 ` Daniel Vetter
2024-08-12 12:02 ` Danilo Krummrich
2024-08-12 8:28 ` [PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed Thomas Zimmermann
2024-08-12 12:11 ` Danilo Krummrich
2024-08-12 8:28 ` [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug() Thomas Zimmermann
2024-08-12 12:17 ` Danilo Krummrich
2024-08-12 12:34 ` Thomas Zimmermann
2024-08-12 18:55 ` Danilo Krummrich [this message]
2024-08-12 8:28 ` [PATCH v2 6/9] drm/fbdev-helper: Update documentation on obsolete callbacks Thomas Zimmermann
2024-08-12 9:25 ` Daniel Vetter
2024-08-12 8:28 ` [PATCH v2 7/9] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed() Thomas Zimmermann
2024-08-12 9:25 ` Daniel Vetter
2024-08-12 8:28 ` [PATCH v2 8/9] drm: Remove struct drm_driver.lastclose Thomas Zimmermann
2024-08-12 8:28 ` [PATCH v2 9/9] drm: Remove struct drm_mode_config_funcs.output_poll_changed Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29016ab-b75d-4822-968b-ea54187f76cf@kernel.org \
--to=dakr@kernel.org \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox