From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: Pekka Paalanen <ppaalanen@gmail.com>
Cc: stylon.wang@amd.com, shashank.sharma@amd.com, thong.thai@amd.com,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
amd-gfx@lists.freedesktop.org, "Daniel Vetter" <daniel@ffwll.ch>,
wayne.lin@amd.com, alexander.deucher@amd.com,
nicholas.kazlauskas@amd.com
Subject: Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode
Date: Mon, 18 Jan 2021 09:36:47 -0500 [thread overview]
Message-ID: <b38e46b7707ba9a899384baedc7efe4e70c439bf.camel@amd.com> (raw)
In-Reply-To: <20210114111445.1d2bbf62@eldfell>
On Thu, 2021-01-14 at 11:14 +0200, Pekka Paalanen wrote:
>
> Hi,
>
> please document somewhere that ends up in git history (commit
> message,
> code comments, description of the parameter would be the best but
> maybe
> there isn't enough space?) what Christian König explained in
>
>
> https://lists.freedesktop.org/archives/dri-devel/2020-December/291254.html
>
> that this is a stop-gap feature intended to be removed as soon as
> possible (when a better solution comes up, which could be years).
>
> So far I have not seen a single mention of this intention in your
> patch
> submissions, and I think it is very important to make known.
Hi,
Thanks for the headsup, I shall add the relevant info in the next
verison.
>
> I also did not see an explanation of why this instead of
> manufacturing
> these video modes in userspace (an idea mentioned by Christian in the
> referenced email). I think that too should be part of a commit
> message.
This is an opt-in feature, which shall be superseded by a better
solution. We also add a set of common modes for scaling similarly.
Userspace can still add whatever mode they want. So I dont see a reason
why this cant be in the kernel.
--
Regards,
Aurabindo Pillai
>
>
> Thanks,
> pq
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-18 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 21:07 [PATCH v3 0/3] Experimental freesync video mode optimization Aurabindo Pillai
2021-01-04 21:07 ` [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode Aurabindo Pillai
2021-01-14 9:14 ` Pekka Paalanen
2021-01-18 14:36 ` Aurabindo Pillai [this message]
2021-01-19 8:35 ` Pekka Paalanen
2021-01-19 13:11 ` Daniel Vetter
2021-01-19 16:08 ` Pillai, Aurabindo
2021-01-19 18:58 ` Daniel Vetter
2021-01-04 21:07 ` [PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes Aurabindo Pillai
2021-01-04 21:08 ` [PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change Aurabindo Pillai
2021-01-06 20:02 ` Kazlauskas, Nicholas
2021-01-17 19:52 ` Aurabindo Pillai
-- strict thread matches above, loose matches on Subject: below --
2020-12-14 22:20 [PATCH v3 0/3] Experimental freesync video mode optimization Aurabindo Pillai
2020-12-14 22:20 ` [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode Aurabindo Pillai
2020-12-17 19:11 ` Alex Deucher
2020-12-17 22:37 ` Aurabindo Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38e46b7707ba9a899384baedc7efe4e70c439bf.camel@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=ppaalanen@gmail.com \
--cc=shashank.sharma@amd.com \
--cc=stylon.wang@amd.com \
--cc=thong.thai@amd.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox