From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>,
amd-gfx list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amd/amdgpu: Fix debugfs wave reader
Date: Fri, 14 Oct 2016 11:33:57 +0200 [thread overview]
Message-ID: <b67032d0-0ffb-936a-a756-bb343eae6030@vodafone.de> (raw)
In-Reply-To: <CADnq5_PUtVDe_LTPcTDn_t5APuFz9J_x_aMCVBVF=rMLtnvTXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 14.10.2016 um 01:13 schrieb Alex Deucher:
> On Thu, Oct 13, 2016 at 12:16 PM, Tom St Denis <tstdenis82@gmail.com> wrote:
>> On non VI/CZ platforms it would not free
>> the grbm index lock.
>>
>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
>> ---
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 304f66ae484f..d141f7f6f225 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -3025,13 +3025,14 @@ static ssize_t amdgpu_debugfs_wave_read(struct file *f, char __user *buf,
>> data[x++] = wave_read_ind(adev, 0x2378, 0x2379, simd, wave, 0x14);
>> data[x++] = wave_read_ind(adev, 0x2378, 0x2379, simd, wave, 0x1A);
>> data[x++] = wave_read_ind(adev, 0x2378, 0x2379, simd, wave, 0x1B);
>> - } else {
>> - return -EINVAL;
>> }
>>
>> amdgpu_gfx_select_se_sh(adev, 0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF);
>> mutex_unlock(&adev->grbm_idx_mutex);
>>
>> + if (!x)
>> + return -EINVAL;
>> +
>> while (size && (*pos < x * 4)) {
>> uint32_t value;
>>
>> --
>> 2.10.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2016-10-14 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 16:16 Fix lock imbalance in debugfs wave reader Tom St Denis
[not found] ` <20161013161649.8089-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2016-10-13 16:16 ` [PATCH] drm/amd/amdgpu: Fix " Tom St Denis
[not found] ` <20161013161649.8089-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2016-10-13 23:13 ` Alex Deucher
[not found] ` <CADnq5_PUtVDe_LTPcTDn_t5APuFz9J_x_aMCVBVF=rMLtnvTXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-14 9:33 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67032d0-0ffb-936a-a756-bb343eae6030@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=tom.stdenis-5C7GfCeVMHo@public.gmane.org \
--cc=tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox