Re: [PATCH] drm/amdgpu: Add parameter documentation for amdgpu_sync_fence

["Christian König" <christian.koenig@amd.com>]

Am 21.03.25 um 02:25 schrieb Srinivasan Shanmugam:
> The 'flags' parameter, which specifies memory allocation behavior while
> creating a sync entry,
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c:162: warning: Function parameter or struct member 'flags' not described in 'amdgpu_sync_fence'
>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> index c5f9db6b32a4..5576ed0b508f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> @@ -154,6 +154,7 @@ static bool amdgpu_sync_add_later(struct amdgpu_sync *sync, struct dma_fence *f)
>   *
>   * @sync: sync object to add fence to
>   * @f: fence to sync to
> + * @flags: memory allocation flags to use when allocating sync entry
>   *
>   * Add the fence to the sync object.
>   */