From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 04/12] drm/amdgpu: move IV prescreening into the GMC code Date: Wed, 10 Oct 2018 09:08:01 +0200 Message-ID: References: <20180926135330.2218-1-christian.koenig@amd.com> <20180926135330.2218-4-christian.koenig@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org WWVhaCwgZXhhY3RseSBteSB0aGlua2luZy4KCkJhc2ljYWxseSB0aGUgbG9uZyB0ZXJtIGdvYWwg aXMgdG8gbW92ZSBtb3N0IG9mIHRoZSByZXBvcnRpbmcgYW5kIApoYW5kbGluZyBvZiBmYXVsdHMg aW50byBhbWRncHVfZ21jLmMuIE90aGVyd2lzZSB3ZSB3b3VsZCBkdXBsaWNhdGUgYSBsb3QgCm9m IGhhbmRsaW5nIGZvciBmdXR1cmUgaHcgZ2VuZXJhdGlvbnMuCgpPbiB0aGUgb3RoZXIgaGFuZCBp ZiB0aGUgYXBwcm9hY2ggd2l0aCB0aGUgc2Vjb25kIElIIHJpbmcgYnVmZmVyIHdvcmtzIAphcyBl eHBlY3RlZCB3ZSBtb3N0IGxpa2VseSB3b24ndCBuZWVkIHRoZSBwcmUtc2NyZWVuaW5nIGFueW1v cmUgYXQgYWxsLiAKQnV0IHRoYXQgbmVlZHMgbW9yZSB3b3JrIHRvIGJlIDEwMCUgc3VyZS4KCkNo cmlzdGlhbi4KCkFtIDEwLjEwLjIwMTggdW0gMDE6NDYgc2NocmllYiBGZWxpeCBLdWVobGluZzoK PiBJIHJlYWxpemVkIHRoYXQgbW9zdCBvZiB0aGUgY29kZSBpbiBnbWNfdjlfMF9wc2VzY3JlZW5f aXYgaXMgbm90Cj4gYWN0dWFsbHkgaGFyZHdhcmUtc3BlY2lmaWMuIElmIGl0IHdhcyBub3QgcHJl c2NyZWVuaW5nLCBidXQgdXNpbmcgYW4KPiBhbWRncHVfaXZfZW50cnkgdGhhdCB3YXMgYWxyZWFk eSBwYXJzZWQsIEkgdGhpbmsgaXQgY291bGQganVzdCBiZSBhCj4gZ2VuZXJpYyBmdW5jdGlvbiBm b3IgcHJvY2Vzc2luZyByZXRyeSBmYXVsdHM6Cj4KPiAgICAqIGxvb2tpbmcgdXAgdGhlIFZNIG9m IGEgZmF1bHQKPiAgICAqIHN0b3JpbmcgcmV0cnkgZmF1bHRzIGluIGEgcGVyLVZNIGZpZm8KPiAg ICAqIGRyb3BwaW5nIGZhdWx0cyB0aGF0IGhhdmUgYWxyZWFkeSBiZWVuIHNlZW4KPgo+IEluIG90 aGVyIHdvcmRzLCBpdCdzIGp1c3QgYSBnZW5lcmljIHRvcCBoYWxmIGludGVycnVwdCBoYW5kbGVy IGZvciByZXRyeQo+IGZhdWx0cyB3aGlsZSB0aGUgYm90dG9tIGhhbGYgKHdvcmtlciB0aHJlYWQp IHdvdWxkIHVzZSB0aGUgcGVyLVZNIEZJRk9zCj4gdG8gaGFuZGxlIHRob3NlIHBlbmRpbmcgcmV0 cnkgZmF1bHRzLgo+Cj4gUmVnYXJkcywKPiAgwqAgRmVsaXgKPgo+Cj4gT24gMjAxOC0wOS0yNiAw OTo1MyBBTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPj4gVGhlIEdNQy9WTSBzdWJzeXN0ZW0g aXMgY2F1c2luZyB0aGUgZmF1bHRzLCBzbyBtb3ZlIHRoZSBoYW5kbGluZyBoZXJlIGFzCj4+IHdl bGwuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2Vu aWdAYW1kLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5 XzAuYyAgfCA1OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L3ZlZ2ExMF9paC5jIHwgNjkgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgNjkgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9n bWNfdjlfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+PiBpbmRl eCA3MjlhMmMyMzBmOTEuLmY4ZDY5YWI4NWZjMyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9nbWNfdjlfMC5jCj4+IEBAIC0yNDQsNiArMjQ0LDYyIEBAIHN0YXRpYyBpbnQgZ21jX3Y5 XzBfdm1fZmF1bHRfaW50ZXJydXB0X3N0YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ PiAgIAlyZXR1cm4gMDsKPj4gICB9Cj4+ICAgCj4+ICsvKioKPj4gKyAqIHZlZ2ExMF9paF9wcmVz Y3JlZW5faXYgLSBwcmVzY3JlZW4gYW4gaW50ZXJydXB0IHZlY3Rvcgo+PiArICoKPj4gKyAqIEBh ZGV2OiBhbWRncHVfZGV2aWNlIHBvaW50ZXIKPj4gKyAqCj4+ICsgKiBSZXR1cm5zIHRydWUgaWYg dGhlIGludGVycnVwdCB2ZWN0b3Igc2hvdWxkIGJlIGZ1cnRoZXIgcHJvY2Vzc2VkLgo+PiArICov Cj4+ICtzdGF0aWMgYm9vbCBnbWNfdjlfMF9wcmVzY3JlZW5faXYoc3RydWN0IGFtZGdwdV9kZXZp Y2UgKmFkZXYsCj4+ICsJCQkJICBzdHJ1Y3QgYW1kZ3B1X2l2X2VudHJ5ICplbnRyeSwKPj4gKwkJ CQkgIHVpbnQ2NF90IGFkZHIpCj4+ICt7Cj4+ICsJc3RydWN0IGFtZGdwdV92bSAqdm07Cj4+ICsJ dTY0IGtleTsKPj4gKwlpbnQgcjsKPj4gKwo+PiArCS8qIE5vIFBBU0lELCBjYW4ndCBpZGVudGlm eSBmYXVsdGluZyBwcm9jZXNzICovCj4+ICsJaWYgKCFlbnRyeS0+cGFzaWQpCj4+ICsJCXJldHVy biB0cnVlOwo+PiArCj4+ICsJLyogTm90IGEgcmV0cnkgZmF1bHQgKi8KPj4gKwlpZiAoIShlbnRy eS0+c3JjX2RhdGFbMV0gJiAweDgwKSkKPj4gKwkJcmV0dXJuIHRydWU7Cj4+ICsKPj4gKwkvKiBU cmFjayByZXRyeSBmYXVsdHMgaW4gcGVyLVZNIGZhdWx0IEZJRk8uICovCj4+ICsJc3Bpbl9sb2Nr KCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2xvY2spOwo+PiArCXZtID0gaWRyX2ZpbmQoJmFkZXYt PnZtX21hbmFnZXIucGFzaWRfaWRyLCBlbnRyeS0+cGFzaWQpOwo+PiArCWlmICghdm0pIHsKPj4g KwkJLyogVk0gbm90IGZvdW5kLCBwcm9jZXNzIGl0IG5vcm1hbGx5ICovCj4+ICsJCXNwaW5fdW5s b2NrKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2xvY2spOwo+PiArCQlyZXR1cm4gdHJ1ZTsKPj4g Kwl9Cj4+ICsKPj4gKwlrZXkgPSBBTURHUFVfVk1fRkFVTFQoZW50cnktPnBhc2lkLCBhZGRyKTsK Pj4gKwlyID0gYW1kZ3B1X3ZtX2FkZF9mYXVsdCh2bS0+ZmF1bHRfaGFzaCwga2V5KTsKPj4gKwo+ PiArCS8qIEhhc2ggdGFibGUgaXMgZnVsbCBvciB0aGUgZmF1bHQgaXMgYWxyZWFkeSBiZWluZyBw cm9jZXNzZWQsCj4+ICsJICogaWdub3JlIGZ1cnRoZXIgcGFnZSBmYXVsdHMKPj4gKwkgKi8KPj4g KwlpZiAociAhPSAwKSB7Cj4+ICsJCXNwaW5fdW5sb2NrKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lk X2xvY2spOwo+PiArCQlyZXR1cm4gZmFsc2U7Cj4+ICsJfQo+PiArCS8qIE5vIGxvY2tpbmcgcmVx dWlyZWQgd2l0aCBzaW5nbGUgd3JpdGVyIGFuZCBzaW5nbGUgcmVhZGVyICovCj4+ICsJciA9IGtm aWZvX3B1dCgmdm0tPmZhdWx0cywga2V5KTsKPj4gKwlpZiAoIXIpIHsKPj4gKwkJLyogRklGTyBp cyBmdWxsLiBJZ25vcmUgaXQgdW50aWwgdGhlcmUgaXMgc3BhY2UgKi8KPj4gKwkJYW1kZ3B1X3Zt X2NsZWFyX2ZhdWx0KHZtLT5mYXVsdF9oYXNoLCBrZXkpOwo+PiArCQlzcGluX3VubG9jaygmYWRl di0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPj4gKwkJcmV0dXJuIGZhbHNlOwo+PiArCX0KPj4g Kwo+PiArCXNwaW5fdW5sb2NrKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2xvY2spOwo+PiArCS8q IEl0J3MgdGhlIGZpcnN0IGZhdWx0IGZvciB0aGlzIGFkZHJlc3MsIHByb2Nlc3MgaXQgbm9ybWFs bHkgKi8KPj4gKwlyZXR1cm4gdHJ1ZTsKPj4gK30KPj4gKwo+PiAgIHN0YXRpYyBpbnQgZ21jX3Y5 XzBfcHJvY2Vzc19pbnRlcnJ1cHQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4+ICAgCQkJ CXN0cnVjdCBhbWRncHVfaXJxX3NyYyAqc291cmNlLAo+PiAgIAkJCQlzdHJ1Y3QgYW1kZ3B1X2l2 X2VudHJ5ICplbnRyeSkKPj4gQEAgLTI1NSw2ICszMTEsOSBAQCBzdGF0aWMgaW50IGdtY192OV8w X3Byb2Nlc3NfaW50ZXJydXB0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+PiAgIAlhZGRy ID0gKHU2NCllbnRyeS0+c3JjX2RhdGFbMF0gPDwgMTI7Cj4+ICAgCWFkZHIgfD0gKCh1NjQpZW50 cnktPnNyY19kYXRhWzFdICYgMHhmKSA8PCA0NDsKPj4gICAKPj4gKwlpZiAoIWdtY192OV8wX3By ZXNjcmVlbl9pdihhZGV2LCBlbnRyeSwgYWRkcikpCj4+ICsJCXJldHVybiAxOwo+PiArCj4+ICAg CWlmICghYW1kZ3B1X3NyaW92X3ZmKGFkZXYpKSB7Cj4+ICAgCQlzdGF0dXMgPSBSUkVHMzIoaHVi LT52bV9sMl9wcm9fZmF1bHRfc3RhdHVzKTsKPj4gICAJCVdSRUczMl9QKGh1Yi0+dm1fbDJfcHJv X2ZhdWx0X2NudGwsIDEsIH4xKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L3ZlZ2ExMF9paC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvdmVnYTEwX2lo LmMKPj4gaW5kZXggMGY1MGJlZjg3MTYzLi4wZjY4YTBjZDFmYmYgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3ZlZ2ExMF9paC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L3ZlZ2ExMF9paC5jCj4+IEBAIC0yMjgsNzYgKzIyOCw3IEBAIHN0YXRp YyB1MzIgdmVnYTEwX2loX2dldF93cHRyKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+PiAg ICAqLwo+PiAgIHN0YXRpYyBib29sIHZlZ2ExMF9paF9wcmVzY3JlZW5faXYoc3RydWN0IGFtZGdw dV9kZXZpY2UgKmFkZXYpCj4+ICAgewo+PiAtCXUzMiByaW5nX2luZGV4ID0gYWRldi0+aXJxLmlo LnJwdHIgPj4gMjsKPj4gLQl1MzIgZHcwLCBkdzMsIGR3NCwgZHc1Owo+PiAtCXUxNiBwYXNpZDsK Pj4gLQl1NjQgYWRkciwga2V5Owo+PiAtCXN0cnVjdCBhbWRncHVfdm0gKnZtOwo+PiAtCWludCBy Owo+PiAtCj4+IC0JZHcwID0gbGUzMl90b19jcHUoYWRldi0+aXJxLmloLnJpbmdbcmluZ19pbmRl eCArIDBdKTsKPj4gLQlkdzMgPSBsZTMyX3RvX2NwdShhZGV2LT5pcnEuaWgucmluZ1tyaW5nX2lu ZGV4ICsgM10pOwo+PiAtCWR3NCA9IGxlMzJfdG9fY3B1KGFkZXYtPmlycS5paC5yaW5nW3Jpbmdf aW5kZXggKyA0XSk7Cj4+IC0JZHc1ID0gbGUzMl90b19jcHUoYWRldi0+aXJxLmloLnJpbmdbcmlu Z19pbmRleCArIDVdKTsKPj4gLQo+PiAtCS8qIEZpbHRlciByZXRyeSBwYWdlIGZhdWx0cywgbGV0 IG9ubHkgdGhlIGZpcnN0IG9uZSBwYXNzLiBJZgo+PiAtCSAqIHRoZXJlIGFyZSB0b28gbWFueSBv dXRzdGFuZGluZyBmYXVsdHMsIGlnbm9yZSB0aGVtIHVudGlsCj4+IC0JICogc29tZSBmYXVsdHMg Z2V0IGNsZWFyZWQuCj4+IC0JICovCj4+IC0Jc3dpdGNoIChkdzAgJiAweGZmKSB7Cj4+IC0JY2Fz ZSBTT0MxNV9JSF9DTElFTlRJRF9WTUM6Cj4+IC0JY2FzZSBTT0MxNV9JSF9DTElFTlRJRF9VVENM MjoKPj4gLQkJYnJlYWs7Cj4+IC0JZGVmYXVsdDoKPj4gLQkJLyogTm90IGEgVk0gZmF1bHQgKi8K Pj4gLQkJcmV0dXJuIHRydWU7Cj4+IC0JfQo+PiAtCj4+IC0JcGFzaWQgPSBkdzMgJiAweGZmZmY7 Cj4+IC0JLyogTm8gUEFTSUQsIGNhbid0IGlkZW50aWZ5IGZhdWx0aW5nIHByb2Nlc3MgKi8KPj4g LQlpZiAoIXBhc2lkKQo+PiAtCQlyZXR1cm4gdHJ1ZTsKPj4gLQo+PiAtCS8qIE5vdCBhIHJldHJ5 IGZhdWx0ICovCj4+IC0JaWYgKCEoZHc1ICYgMHg4MCkpCj4+IC0JCXJldHVybiB0cnVlOwo+PiAt Cj4+IC0JLyogVHJhY2sgcmV0cnkgZmF1bHRzIGluIHBlci1WTSBmYXVsdCBGSUZPLiAqLwo+PiAt CXNwaW5fbG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPj4gLQl2bSA9IGlkcl9m aW5kKCZhZGV2LT52bV9tYW5hZ2VyLnBhc2lkX2lkciwgcGFzaWQpOwo+PiAtCWFkZHIgPSAoKHU2 NCkoZHc1ICYgMHhmKSA8PCA0NCkgfCAoKHU2NClkdzQgPDwgMTIpOwo+PiAtCWtleSA9IEFNREdQ VV9WTV9GQVVMVChwYXNpZCwgYWRkcik7Cj4+IC0JaWYgKCF2bSkgewo+PiAtCQkvKiBWTSBub3Qg Zm91bmQsIHByb2Nlc3MgaXQgbm9ybWFsbHkgKi8KPj4gLQkJc3Bpbl91bmxvY2soJmFkZXYtPnZt X21hbmFnZXIucGFzaWRfbG9jayk7Cj4+IC0JCXJldHVybiB0cnVlOwo+PiAtCX0gZWxzZSB7Cj4+ IC0JCXIgPSBhbWRncHVfdm1fYWRkX2ZhdWx0KHZtLT5mYXVsdF9oYXNoLCBrZXkpOwo+PiAtCj4+ IC0JCS8qIEhhc2ggdGFibGUgaXMgZnVsbCBvciB0aGUgZmF1bHQgaXMgYWxyZWFkeSBiZWluZyBw cm9jZXNzZWQsCj4+IC0JCSAqIGlnbm9yZSBmdXJ0aGVyIHBhZ2UgZmF1bHRzCj4+IC0JCSAqLwo+ PiAtCQlpZiAociAhPSAwKSB7Cj4+IC0JCQlzcGluX3VubG9jaygmYWRldi0+dm1fbWFuYWdlci5w YXNpZF9sb2NrKTsKPj4gLQkJCWdvdG8gaWdub3JlX2l2Owo+PiAtCQl9Cj4+IC0JfQo+PiAtCS8q IE5vIGxvY2tpbmcgcmVxdWlyZWQgd2l0aCBzaW5nbGUgd3JpdGVyIGFuZCBzaW5nbGUgcmVhZGVy ICovCj4+IC0JciA9IGtmaWZvX3B1dCgmdm0tPmZhdWx0cywga2V5KTsKPj4gLQlpZiAoIXIpIHsK Pj4gLQkJLyogRklGTyBpcyBmdWxsLiBJZ25vcmUgaXQgdW50aWwgdGhlcmUgaXMgc3BhY2UgKi8K Pj4gLQkJYW1kZ3B1X3ZtX2NsZWFyX2ZhdWx0KHZtLT5mYXVsdF9oYXNoLCBrZXkpOwo+PiAtCQlz cGluX3VubG9jaygmYWRldi0+dm1fbWFuYWdlci5wYXNpZF9sb2NrKTsKPj4gLQkJZ290byBpZ25v cmVfaXY7Cj4+IC0JfQo+PiAtCj4+IC0Jc3Bpbl91bmxvY2soJmFkZXYtPnZtX21hbmFnZXIucGFz aWRfbG9jayk7Cj4+IC0JLyogSXQncyB0aGUgZmlyc3QgZmF1bHQgZm9yIHRoaXMgYWRkcmVzcywg cHJvY2VzcyBpdCBub3JtYWxseSAqLwo+PiAgIAlyZXR1cm4gdHJ1ZTsKPj4gLQo+PiAtaWdub3Jl X2l2Ogo+PiAtCWFkZXYtPmlycS5paC5ycHRyICs9IDMyOwo+PiAtCXJldHVybiBmYWxzZTsKPj4g ICB9Cj4+ICAgCj4+ICAgLyoqCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK