From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Campbell Subject: Re: [PATCH v2 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Fri, 7 Jun 2019 15:13:00 -0700 Message-ID: References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> <6833be96-12a3-1a1c-1514-c148ba2dd87b@nvidia.com> <20190607191302.GR14802@ziepe.ca> <20190607204427.GU14802@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190607204427.GU14802@ziepe.ca> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Gunthorpe Cc: Andrea Arcangeli , linux-rdma@vger.kernel.org, John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org Ck9uIDYvNy8xOSAxOjQ0IFBNLCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4gT24gRnJpLCBKdW4g MDcsIDIwMTkgYXQgMDE6MjE6MTJQTSAtMDcwMCwgUmFscGggQ2FtcGJlbGwgd3JvdGU6Cj4gCj4+ PiBXaGF0IEkgd2FudCB0byBnZXQgdG8gaXMgYSBwYXR0ZXJuIGxpa2UgdGhpczoKPj4+Cj4+PiBw YWdlZmF1bHQoKToKPj4+Cj4+PiAgICAgIGhtbV9yYW5nZV9yZWdpc3RlcigmcmFuZ2UpOwo+Pj4g YWdhaW46Cj4+PiAgICAgIC8qIE9uIHRoZSBzbG93IHBhdGgsIGlmIHdlIGFwcGVhciB0byBiZSBs aXZlIGxvY2tlZCB0aGVuIHdlIGdldAo+Pj4gICAgICAgICB0aGUgd3JpdGUgc2lkZSBvZiBtbWFw X3NlbSB3aGljaCB3aWxsIGJyZWFrIHRoZSBsaXZlIGxvY2ssCj4+PiAgICAgICAgIG90aGVyd2lz ZSB0aGlzIGdldHMgdGhlIHJlYWQgbG9jayAqLwo+Pj4gICAgICBpZiAoaG1tX3JhbmdlX3N0YXJ0 X2FuZF9sb2NrKCZyYW5nZSkpCj4+PiAgICAgICAgICAgIGdvdG8gZXJyOwo+Pj4KPj4+ICAgICAg bG9ja2RlcF9hc3NlcnRfaGVsZChyYW5nZS0+bW0tPm1tYXBfc2VtKTsKPj4+Cj4+PiAgICAgIC8v IE9wdGlvbmFsOiBBdm9pZCB1c2VsZXNzIGV4cGVuc2l2ZSB3b3JrCj4+PiAgICAgIGlmIChobW1f cmFuZ2VfbmVlZHNfcmV0cnkoJnJhbmdlKSkKPj4+ICAgICAgICAgZ290byBhZ2FpbjsKPj4+ICAg ICAgaG1tX3JhbmdlXyh0b3VjaCB2bWFzKQo+Pj4KPj4+ICAgICAgdGFrZV9sb2NrKGRyaXZlci0+ dXBkYXRlKTsKPj4+ICAgICAgaWYgKGhtbV9yYW5nZV9lbmQoJnJhbmdlKSB7Cj4+PiAgICAgICAg ICByZWxlYXNlX2xvY2soZHJpdmVyLT51cGRhdGUpOwo+Pj4gICAgICAgICAgZ290byBhZ2FpbjsK Pj4+ICAgICAgfQo+Pj4gICAgICAvLyBGaW5pc2ggZHJpdmVyIHVwZGF0ZXMKPj4+ICAgICAgcmVs ZWFzZV9sb2NrKGRyaXZlci0+dXBkYXRlKTsKPj4+Cj4+PiAgICAgIC8vIFJlbGVhc2VzIG1tYXBf c2VtCj4+PiAgICAgIGhtbV9yYW5nZV91bnJlZ2lzdGVyX2FuZF91bmxvY2soJnJhbmdlKTsKPj4+ Cj4+PiBXaGF0IGRvIHlvdSB0aGluaz8KPj4+Cj4+PiBJcyBpdCBjbGVhcj8KPj4+Cj4+PiBKYXNv bgo+Pj4KPj4KPj4gQXJlIHlvdSB0YWxraW5nIGFib3V0IGFjcXVpcmluZyBtbWFwX3NlbSBpbiBo bW1fcmFuZ2Vfc3RhcnRfYW5kX2xvY2soKT8KPj4gVXN1YWxseSwgdGhlIGZhdWx0IGNvZGUgaGFz IHRvIGxvY2sgbW1hcF9zZW0gZm9yIHJlYWQgaW4gb3JkZXIgdG8KPj4gY2FsbCBmaW5kX3ZtYSgp IHNvIGl0IGNhbiBzZXQgcmFuZ2Uudm1hLgo+IAo+PiBJZiBITU0gZHJvcHMgbW1hcF9zZW0gLSB3 aGljaCBJIGRvbid0IHRoaW5rIGl0IHNob3VsZCwganVzdCByZXR1cm4gYW4KPj4gZXJyb3IgdG8g dGVsbCB0aGUgY2FsbGVyIHRvIGRyb3AgbW1hcF9zZW0gYW5kIHJldHJ5IC0gdGhlIGZpbmRfdm1h KCkKPj4gd2lsbCBuZWVkIHRvIGJlIHJlcGVhdGVkIGFzIHdlbGwuCj4gCj4gT3ZlcmFsbCBJIGRv bid0IHRoaW5rIGl0IG1ha2VzIGEgbG90IG9mIHNlbnNlIHRvIHNsZWVwIGZvciByZXRyeSBpbgo+ IGhtbV9yYW5nZV9zdGFydF9hbmRfbG9jaygpIHdoaWxlIGhvbGRpbmcgbW1hcF9zZW0uIEl0IHdv dWxkIGJlIGJldHRlcgo+IHRvIGRyb3AgdGhhdCBsb2NrLCBzbGVlcCwgdGhlbiByZS1hY3F1aXJl IGl0IGFzIHBhcnQgb2YgdGhlIGhtbSBsb2dpYy4KPiAKPiBUaGUgZmluZF92bWEgc2hvdWxkIGJl IGRvbmUgaW5zaWRlIHRoZSBjcml0aWNhbCBzZWN0aW9uIGNyZWF0ZWQgYnkKPiBobW1fcmFuZ2Vf c3RhcnRfYW5kX2xvY2soKSwgbm90IGJlZm9yZSBpdC4gSWYgd2UgYXJlIHJldHJ5aW5nIHRoZW4g d2UKPiBhbHJlYWR5IHNsZXB0IGFuZCB0aGUgYWRkaXRpb25hbCBDUFUgY29zdCB0byByZXBlYXQg dGhlIGZpbmRfdm1hIGlzCj4gaW1tYXRlcmlhbCwgSU1ITz8KPiAKPiBEbyB5b3Ugc2VlIGEgcmVh c29uIHdoeSB0aGUgZmluZF92bWEoKSBldmVyIG5lZWRzIHRvIGJlIGJlZm9yZSB0aGUKPiAnYWdh aW4nIGluIG15IGFib3ZlIGV4YW1wbGU/IHJhbmdlLnZtYSBkb2VzIG5vdCBuZWVkIHRvIGJlIHNl dCBmb3IKPiByYW5nZV9yZWdpc3Rlci4KClllcywgZm9yIHRoZSBHUFUgY2FzZSwgdGhlcmUgY2Fu IGJlIG1hbnkgZmF1bHRzIGluIGFuIGV2ZW50IHF1ZXVlCmFuZCB0aGUgZ29hbCBpcyB0byB0cnkg dG8gaGFuZGxlIG1vcmUgdGhhbiBvbmUgcGFnZSBhdCBhIHRpbWUuClRoZSB2bWEgaXMgbmVlZGVk IHRvIGxpbWl0IHRoZSBhbW91bnQgb2YgY29hbGVzY2luZyBhbmQgY2hlY2tpbmcKZm9yIHBhZ2Vz IHRoYXQgY291bGQgYmUgc3BlY3VsYXRpdmVseSBtaWdyYXRlZCBvciBtYXBwZWQuCgo+PiBJJ20g YWxzbyBub3Qgc3VyZSBhYm91dCBhY3F1aXJpbmcgdGhlIG1tYXBfc2VtIGZvciB3cml0ZSBhcyB3 YXkgdG8KPj4gbWl0aWdhdGUgdGhyYXNoaW5nLiBJdCBzZWVtcyB0byBtZSB0aGF0IGlmIGEgZGV2 aWNlIGFuZCBhIENQVSBhcmUKPj4gYm90aCBmYXVsdGluZyBvbiB0aGUgc2FtZSBwYWdlLAo+IAo+ IE9uZSBvZiB0aGUgcmVhc29ucyB0byBwcmVmZXIgdGhpcyBhcHByb2FjaCBpcyB0aGF0IGl0IG1l YW5zIHdlIGRvbid0Cj4gbmVlZCB0byBrZWVwIHRyYWNrIG9mIHdoaWNoIHJhbmdlcyB3ZSBhcmUg ZmF1bHRpbmcsIGFuZCBpZiB0aGVyZSBpcyBhCj4gbG90IG9mICp1bnJlbGF0ZWQqIGZhdWx0IGFj dGl2aXR5ICh1bmxpa2VseT8pIHdlIGNhbiByZXNvbHZlIGl0IHVzaW5nCj4gbW1hcCBzZW0gaW5z dGVhZCBvZiB0aGlzIGVsYWJvcmF0ZSByYW5nZXMgc2NoZW1lIGFuZCByZWxhdGVkCj4gbG9ja2lu Zy4KPiAKPiBUaGlzIHdvdWxkIHJlZHVjZSB0aGUgb3ZlcmFsbCB3b3JrIGluIHRoZSBwYWdlIGZh dWx0IGFuZAo+IGludmFsaWRhdGVfc3RhcnQvZW5kIHBhdGhzIGZvciB0aGUgY29tbW9uIHVuY29u dGVuZGVkIGNhc2VzLgo+IAo+PiBzb21lIHNvcnQgb2YgYmFja29mZiBkZWxheSBpcyBuZWVkZWQg dG8gbGV0IG9uZSBzaWRlIG9yIHRoZSBvdGhlcgo+PiBtYWtlIHNvbWUgcHJvZ3Jlc3MuCj4gCj4g V2hhdCB0aGUgd3JpdGUgc2lkZSBvZiB0aGUgbW1hcF9zZW0gd291bGQgZG8gaXMgZm9yY2UgdGhl IENQVSBhbmQKPiBkZXZpY2UgdG8gY2xlYW5seSB0YWtlIHR1cm5zLiBPbmNlIHRoZSBkZXZpY2Ug cGFnZXMgYXJlIHJlZ2lzdGVyZWQKPiB1bmRlciB0aGUgd3JpdGUgc2lkZSB0aGUgQ1BVIHdpbGwg aGF2ZSB0byB3YWl0IGluIGludmFsaWRhdGVfc3RhcnQgZm9yCj4gdGhlIGRyaXZlciB0byBjb21w bGV0ZSBhIHNob290ZG93biwgdGhlbiB0aGUgd2hvbGUgdGhpbmcgc3RhcnRzIGFsbAo+IG92ZXIg YWdhaW4uCj4gCj4gSXQgaXMgY2VydGFpbmx5IGltYWdpbmFibGUgc29tZXRoaW5nIGNvdWxkIGhh dmUgYSAnbWluIGxpZmUnIHRpbWVyIGZvcgo+IGEgZGV2aWNlIG1hcHBpbmcgYW5kIGhvbGQgbW0g aW52YWxpZGF0ZV9zdGFydCwgYW5kIGRldmljZSBwYWdlZmF1bHQKPiBmb3IgdGhhdCBtaW4gdGlt ZSB0byBwcm9tb3RlIGJldHRlciBzaGFyaW5nLgo+IAo+IEJ1dCwgaWYgd2UgZG9uJ3QgdXNlIHRo ZSBtbWFwX3NlbSB0aGVuIHdlIGNhbiBsaXZlbG9jayBhbmQgdGhlIGRldmljZQo+IHdpbGwgc2Vl IGFuIHVucmVjb3ZlcmFibGUgZXJyb3IgZnJvbSB0aGUgdGltZW91dCB3aGljaCBtZWFucyB3ZSBo YXZlCj4gcmlzayB0aGF0IHVuZGVyIGxvYWQgdGhlIHN5c3RlbSB3aWxsIHNpbXBseSBvYnNjdXJl bHkgZmFpbC4gVGhpcyBzZWVtcwo+IHVuYWNjZXB0YWJsZSB0byBtZS4uCj4gCj4gUGFydGljdWxh cmx5IHNpbmNlIGZvciB0aGUgT0RQIHVzZSBjYXNlIHRoZSBpc3N1ZSBpcyBub3QgdHJhc2hpbmcK PiBtaWdyYXRpb24gYXMgYSBHUFUgbWlnaHQgaGF2ZSwgYnV0IHNpbXBsZSBzeXN0ZW0gc3RhYmls aXR5IHVuZGVyIHN3YXAKPiBsb2FkLiBXZSBkbyBub3Qgd2FudCB0aGUgT0RQIHBhZ2VmYXVsdCB0 byBwZXJtYW5lbnRseSBmYWlsIGR1ZSB0bwo+IHRpbWVvdXQgaWYgdGhlIFZNQSBpcyBzdGlsbCB2 YWxpZC4uCj4gCj4gSmFzb24KPiAKCk9LLCBJIHVuZGVyc3RhbmQuCklmIHlvdSBjb21lIHVwIHdp dGggYSBzZXQgb2YgY2hhbmdlcywgSSBjYW4gdHJ5IHRlc3RpbmcgdGhlbS4KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs