From: Felix Kuehling <felix.kuehling@amd.com>
To: Alex Sierra <alex.sierra@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdkfd: set attribute access for default ranges
Date: Thu, 22 Apr 2021 11:27:06 -0400 [thread overview]
Message-ID: <be3a698c-0fbd-0797-e350-84463e6afc5d@amd.com> (raw)
In-Reply-To: <20210421195156.24250-2-alex.sierra@amd.com>
Am 2021-04-21 um 3:51 p.m. schrieb Alex Sierra:
> Attribute access value for default ranges is set, based on
> process xnack on/off.
> XNACK ON has GPU access attribute for unregistered ranges through page
> fault. While XNACK OFF has no access attribute for unregistered ranges.
>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
This patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index cb025a6f30d5..62cf342d254c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -2963,12 +2963,11 @@ svm_range_get_attr(struct kfd_process *p, uint64_t start, uint64_t size,
> pr_debug("range attrs not found return default values\n");
> svm_range_set_default_attributes(&location, &prefetch_loc,
> &granularity, &flags);
> - /* TODO: Automatically create SVM ranges and map them on
> - * GPU page faults
> if (p->xnack_enabled)
> bitmap_fill(bitmap_access, MAX_GPU_INSTANCE);
> - */
> -
> + else
> + bitmap_zero(bitmap_access, MAX_GPU_INSTANCE);
> + bitmap_zero(bitmap_aip, MAX_GPU_INSTANCE);
> goto fill_values;
> }
> bitmap_fill(bitmap_access, MAX_GPU_INSTANCE);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-04-22 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 19:51 [PATCH 1/2] drm/amdkfd: svm ranges creation for unregistered memory Alex Sierra
2021-04-21 19:51 ` [PATCH 2/2] drm/amdkfd: set attribute access for default ranges Alex Sierra
2021-04-22 15:27 ` Felix Kuehling [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-21 19:40 [PATCH 1/2] drm/amdkfd: svm ranges creation for unregistered memory Alex Sierra
2021-04-21 19:40 ` [PATCH 2/2] drm/amdkfd: set attribute access for default ranges Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be3a698c-0fbd-0797-e350-84463e6afc5d@amd.com \
--to=felix.kuehling@amd.com \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox