From: Eric Huang <jinhuieric.huang-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/pp: Clean register first to avoid read original value
Date: Fri, 30 Mar 2018 10:36:21 -0400 [thread overview]
Message-ID: <c42b3004-8b75-60d2-0f2b-45e1e9a2f1f6@amd.com> (raw)
In-Reply-To: <1522395206-5860-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
It is not necessary to do that. The register will reset to 0 after reading.
Eric
On 03/30/2018 03:33 AM, Rex Zhu wrote:
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index aaa9f5b..38cf3a1 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -3368,6 +3368,19 @@ static int smu7_get_gpu_power(struct pp_hwmgr *hwmgr,
> "Failed to start pm status log!",
> return -1);
>
> + cgs_write_ind_register(hwmgr->device,
> + CGS_IND_REG__SMC,
> + ixSMU_PM_STATUS_40, 0);
> + cgs_write_ind_register(hwmgr->device,
> + CGS_IND_REG__SMC,
> + ixSMU_PM_STATUS_49, 0);
> + cgs_write_ind_register(hwmgr->device,
> + CGS_IND_REG__SMC,
> + ixSMU_PM_STATUS_94, 0);
> + cgs_write_ind_register(hwmgr->device,
> + CGS_IND_REG__SMC,
> + ixSMU_PM_STATUS_95, 0);
> +
> /* Sampling period from 50ms to 4sec */
> msleep_interruptible(200);
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-03-30 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:33 [PATCH] drm/amd/pp: Clean register first to avoid read original value Rex Zhu
[not found] ` <1522395206-5860-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-03-30 12:53 ` Deucher, Alexander
2018-03-30 14:36 ` Eric Huang [this message]
[not found] ` <c42b3004-8b75-60d2-0f2b-45e1e9a2f1f6-5C7GfCeVMHo@public.gmane.org>
2018-03-30 15:22 ` Eric Huang
[not found] ` <9bac98b9-4add-6214-f461-bfd91d5636ad-5C7GfCeVMHo@public.gmane.org>
2018-03-31 0:28 ` Zhu, Rex
[not found] ` <CY4PR12MB16872AF3D8207BF4ACBC023FFBA00-rpdhrqHFk06Y0SjTqZDccQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-31 1:45 ` Eric Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42b3004-8b75-60d2-0f2b-45e1e9a2f1f6@amd.com \
--to=jinhuieric.huang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox