From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73EF5E68145 for ; Tue, 17 Feb 2026 08:22:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA06C10E460; Tue, 17 Feb 2026 08:21:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="J014N6Ua"; dkim-atps=neutral Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by gabe.freedesktop.org (Postfix) with ESMTPS id D228410E063; Tue, 17 Feb 2026 08:21:56 +0000 (UTC) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4fFXg513Dfz9t5M; Tue, 17 Feb 2026 09:21:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1771316513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pi28vdSvaRdgQlZvv9XjaVuEVLRh69xvypyxyKxT0lc=; b=J014N6UaPVvmn7gwPG+BTYpubqlD2QsIK4jg8FBkOuzaC6QFwdu1TvSHl8fstX2aqRwJB/ fIUvEJlbfaIqN2hKXCrhIzfsa5iwFHnwThEm86ekPhiAy0XezA2l47AVoCqhi0gzIqNRKv Eq91lCoWbWQyca0/e9T+sd6gAr09IX3t0VJdKo85MA3wqKOjwpX7sgNOKWbidL1gbVF/ru MSaRfzt4+FzW/o12SxFt70rQ512+bt199Rj2Pi+hkBt6rxnc4vdAsuACfBSIhMn9RWqXbn m9YtGajhbFCPYIGivvOuJfc9XWT1Ig2Zbf2E/ch9hZ+0nO1F5i4X7W0C+CTe5A== Message-ID: Date: Tue, 17 Feb 2026 09:21:46 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v4 23/27] drm: Add passive_vrr_disabled property to crtc To: =?UTF-8?Q?Tomasz_Paku=C5=82a?= , alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.berger@gmail.com, daniel@fooishbar.org References: <20260216164516.36803-1-tomasz.pakula.oficjalny@gmail.com> <20260216164516.36803-24-tomasz.pakula.oficjalny@gmail.com> From: =?UTF-8?Q?Michel_D=C3=A4nzer?= Content-Language: en-CA In-Reply-To: <20260216164516.36803-24-tomasz.pakula.oficjalny@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-ID: bab2b5f730da6c68bdb X-MBO-RS-META: e7z64sqjybjr64r3sok1s13kged1xk8c X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 2/16/26 17:45, Tomasz Pakuła wrote: > Many TVs and other HDMI sinks suffer from blanking and possibly other > glitches when VRR is toggled. With VRR present on such sinks and > vrr_on_desktop enabled, they behave like the signal is always variable, > even in fixed refresh rate situations. DisplayPort and eDP enforce > seamless VRR transitions but HDMI unfortunately doesn't. > > Keep VRR toggled if it's supported and not explicitly disabled. It can > be used for any VRR sinks, but this is mainly targeted for HDMI. > > Functionally, for an end user, this is the same as normal, fixed refresh > rate mode. The only difference is that sink is kept in VRR state which > enables seamless transitions into/out of variable refresh rate. > > Basically, the driver shouldn't change it's behavior around VRR_ENABLED > set to false, jut keep sending info packets/frames with VRR/FreeSync/ > G-Sync/HDMI VRR active. > > Enabled by default for sinks that claim it's support Having a negation term like "disabled" in the property name can be confusing (as it involves double negation when the property value is 0) and is better avoided. -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast